* [PATCH 1/1] nvme-rdma: fix typo in comment
@ 2023-04-19 23:17 Max Gurtovoy
2023-05-12 20:32 ` Christoph Hellwig
2023-05-15 17:14 ` Keith Busch
0 siblings, 2 replies; 6+ messages in thread
From: Max Gurtovoy @ 2023-04-19 23:17 UTC (permalink / raw)
To: sagi, hch, linux-nvme; +Cc: kbusch, israelr, oren, Max Gurtovoy
There is no ib_stop_cq API and the need for the +1 is for ib_drain_qp.
Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
Reviewed-by: Israel Rukshin <israelr@nvidia.com>
Signed-off-by: Max Gurtovoy <mgurtovoy@nvidia.com>
---
drivers/nvme/host/rdma.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/nvme/host/rdma.c b/drivers/nvme/host/rdma.c
index 79412e4bfe3e..50b260410f9c 100644
--- a/drivers/nvme/host/rdma.c
+++ b/drivers/nvme/host/rdma.c
@@ -506,7 +506,7 @@ static int nvme_rdma_create_queue_ib(struct nvme_rdma_queue *queue)
}
ibdev = queue->device->dev;
- /* +1 for ib_stop_cq */
+ /* +1 for ib_drain_qp */
queue->cq_size = cq_factor * queue->queue_size + 1;
ret = nvme_rdma_create_cq(ibdev, queue);
--
2.18.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] nvme-rdma: fix typo in comment
2023-04-19 23:17 [PATCH 1/1] nvme-rdma: fix typo in comment Max Gurtovoy
@ 2023-05-12 20:32 ` Christoph Hellwig
2023-05-15 17:14 ` Keith Busch
1 sibling, 0 replies; 6+ messages in thread
From: Christoph Hellwig @ 2023-05-12 20:32 UTC (permalink / raw)
To: Max Gurtovoy; +Cc: sagi, hch, linux-nvme, kbusch, israelr, oren
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] nvme-rdma: fix typo in comment
2023-04-19 23:17 [PATCH 1/1] nvme-rdma: fix typo in comment Max Gurtovoy
2023-05-12 20:32 ` Christoph Hellwig
@ 2023-05-15 17:14 ` Keith Busch
1 sibling, 0 replies; 6+ messages in thread
From: Keith Busch @ 2023-05-15 17:14 UTC (permalink / raw)
To: Max Gurtovoy; +Cc: sagi, hch, linux-nvme, israelr, oren
Thanks, applied to nvme-6.5.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] nvme-rdma: fix typo in comment
2022-05-25 14:59 Max Gurtovoy
2023-03-30 9:30 ` Max Gurtovoy
@ 2023-03-30 16:18 ` Sagi Grimberg
1 sibling, 0 replies; 6+ messages in thread
From: Sagi Grimberg @ 2023-03-30 16:18 UTC (permalink / raw)
To: Max Gurtovoy, linux-nvme, hch; +Cc: oren, israelr, kbusch
Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] nvme-rdma: fix typo in comment
2022-05-25 14:59 Max Gurtovoy
@ 2023-03-30 9:30 ` Max Gurtovoy
2023-03-30 16:18 ` Sagi Grimberg
1 sibling, 0 replies; 6+ messages in thread
From: Max Gurtovoy @ 2023-03-30 9:30 UTC (permalink / raw)
To: sagi, linux-nvme, hch; +Cc: oren, israelr, kbusch
Hi Christoph/Sagi,
I've noticed that the bellow patch wasn't merged.
Can we take it for next cycle please ?
On 25/05/2022 17:59, Max Gurtovoy wrote:
> There is no ib_stop_cq API and the need for the +1 is for ib_drain_qp.
>
> Reviewed-by: Israel Rukshin <israelr@nvidia.com>
> Signed-off-by: Max Gurtovoy <mgurtovoy@nvidia.com>
> ---
> drivers/nvme/host/rdma.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/nvme/host/rdma.c b/drivers/nvme/host/rdma.c
> index d9f19d901313..12c7ea61ed0c 100644
> --- a/drivers/nvme/host/rdma.c
> +++ b/drivers/nvme/host/rdma.c
> @@ -509,7 +509,7 @@ static int nvme_rdma_create_queue_ib(struct nvme_rdma_queue *queue)
> }
> ibdev = queue->device->dev;
>
> - /* +1 for ib_stop_cq */
> + /* +1 for ib_drain_qp */
> queue->cq_size = cq_factor * queue->queue_size + 1;
>
> ret = nvme_rdma_create_cq(ibdev, queue);
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 1/1] nvme-rdma: fix typo in comment
@ 2022-05-25 14:59 Max Gurtovoy
2023-03-30 9:30 ` Max Gurtovoy
2023-03-30 16:18 ` Sagi Grimberg
0 siblings, 2 replies; 6+ messages in thread
From: Max Gurtovoy @ 2022-05-25 14:59 UTC (permalink / raw)
To: sagi, linux-nvme, hch; +Cc: oren, israelr, kbusch, Max Gurtovoy
There is no ib_stop_cq API and the need for the +1 is for ib_drain_qp.
Reviewed-by: Israel Rukshin <israelr@nvidia.com>
Signed-off-by: Max Gurtovoy <mgurtovoy@nvidia.com>
---
drivers/nvme/host/rdma.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/nvme/host/rdma.c b/drivers/nvme/host/rdma.c
index d9f19d901313..12c7ea61ed0c 100644
--- a/drivers/nvme/host/rdma.c
+++ b/drivers/nvme/host/rdma.c
@@ -509,7 +509,7 @@ static int nvme_rdma_create_queue_ib(struct nvme_rdma_queue *queue)
}
ibdev = queue->device->dev;
- /* +1 for ib_stop_cq */
+ /* +1 for ib_drain_qp */
queue->cq_size = cq_factor * queue->queue_size + 1;
ret = nvme_rdma_create_cq(ibdev, queue);
--
2.18.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-05-15 17:14 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-04-19 23:17 [PATCH 1/1] nvme-rdma: fix typo in comment Max Gurtovoy
2023-05-12 20:32 ` Christoph Hellwig
2023-05-15 17:14 ` Keith Busch
-- strict thread matches above, loose matches on Subject: below --
2022-05-25 14:59 Max Gurtovoy
2023-03-30 9:30 ` Max Gurtovoy
2023-03-30 16:18 ` Sagi Grimberg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).