From: Eduard Hasenleithner <email@example.com>
To: Keith Busch <firstname.lastname@example.org>
Cc: Sagi Grimberg <email@example.com>, firstname.lastname@example.org
Subject: Re: [RFC PATCH] Workaround for discard on non-conformant nvme devices
Date: Wed, 6 Nov 2019 22:10:58 +0100 [thread overview]
Message-ID: <email@example.com> (raw)
On 06.11.19 21:43, Keith Busch wrote:
> On Wed, Nov 06, 2019 at 09:22:00PM +0100, Eduard Hasenleithner wrote:
>> Couldn't we just simply use the discard_page for all discards?
> That's normally just a fallback to ensure forward progress under memory
> pressure. It's not particularly performant, though.
So we are accepting a considerable performance impact for the "broken"
>> Are there even nvme devices out there which have conformant behavior in this
> I believe most of them do conform, but I don't have a large sample size
> to confirm.
Do you have an IO-MMU active on your setup? In my setup it is active and
the nvme is directly attached to the CPU. So the CPU exactly knows the
intiator and the IO-MMU page table defines with page granularity which
memory the nvme may read or write. I'm under the impression that
slightly older setups may be less restrictive wrt DMA IO.
Another aspect is that vendors probably only test with windows and I'm
guessing that windows doesn't bother with maintaining anything but page
sized/aligned memory for issuing discard commands.
Linux-nvme mailing list
next prev parent reply other threads:[~2019-11-06 21:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-04 21:47 [RFC PATCH] Workaround for discard on non-conformant nvme devices Eduard Hasenleithner
2019-11-06 16:52 ` Sagi Grimberg
2019-11-06 18:23 ` Keith Busch
2019-11-06 20:22 ` Eduard Hasenleithner
2019-11-06 20:43 ` Keith Busch
2019-11-06 21:10 ` Eduard Hasenleithner [this message]
2019-11-06 21:34 ` Keith Busch
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).