Linux-OMAP Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] clk: ti: am43xx: Fix clock parent for RTC clock
@ 2020-02-21 17:10 Tony Lindgren
  2020-02-21 18:49 ` Stephen Boyd
  0 siblings, 1 reply; 5+ messages in thread
From: Tony Lindgren @ 2020-02-21 17:10 UTC (permalink / raw)
  To: Michael Turquette, Stephen Boyd, Tero Kristo
  Cc: devicetree, linux-clk, linux-omap

Currently enabling clkctrl clock on am4 can fail for RTC as the clock
parent is wrong for RTC.

Fixes: 76a1049b84dd ("clk: ti: am43xx: add new clkctrl data for am43xx")
Signed-off-by: Tony Lindgren <tony@atomide.com>
---

It is unclear if we can end up with RTC hung with the current mainline
kernel in some cases. Probing RTC with device tree data only seems to
trigger this every time.

---
 drivers/clk/ti/clk-43xx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clk/ti/clk-43xx.c b/drivers/clk/ti/clk-43xx.c
--- a/drivers/clk/ti/clk-43xx.c
+++ b/drivers/clk/ti/clk-43xx.c
@@ -78,7 +78,7 @@ static const struct omap_clkctrl_reg_data am4_gfx_l3_clkctrl_regs[] __initconst
 };
 
 static const struct omap_clkctrl_reg_data am4_l4_rtc_clkctrl_regs[] __initconst = {
-	{ AM4_L4_RTC_RTC_CLKCTRL, NULL, CLKF_SW_SUP, "clk_32768_ck" },
+	{ AM4_L4_RTC_RTC_CLKCTRL, NULL, CLKF_SW_SUP, "clkdiv32k_ick" },
 	{ 0 },
 };
 
-- 
2.25.1

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] clk: ti: am43xx: Fix clock parent for RTC clock
  2020-02-21 17:10 [PATCH] clk: ti: am43xx: Fix clock parent for RTC clock Tony Lindgren
@ 2020-02-21 18:49 ` Stephen Boyd
  2020-03-16 14:48   ` Tero Kristo
  0 siblings, 1 reply; 5+ messages in thread
From: Stephen Boyd @ 2020-02-21 18:49 UTC (permalink / raw)
  To: Michael Turquette, Stephen Boyd, Tero Kristo, Tony Lindgren
  Cc: devicetree, linux-clk, linux-omap

Quoting Tony Lindgren (2020-02-21 09:10:30)
> Currently enabling clkctrl clock on am4 can fail for RTC as the clock
> parent is wrong for RTC.
> 
> Fixes: 76a1049b84dd ("clk: ti: am43xx: add new clkctrl data for am43xx")
> Signed-off-by: Tony Lindgren <tony@atomide.com>
> ---
> 
> It is unclear if we can end up with RTC hung with the current mainline
> kernel in some cases. Probing RTC with device tree data only seems to
> trigger this every time.

It's small enough and if it's annoying enough we can probably put it
into clk-fixes to get it fixed for this release instead of waiting. Can
Tero ack it?

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] clk: ti: am43xx: Fix clock parent for RTC clock
  2020-02-21 18:49 ` Stephen Boyd
@ 2020-03-16 14:48   ` Tero Kristo
  2020-03-16 18:28     ` Stephen Boyd
  2020-03-16 18:28     ` Stephen Boyd
  0 siblings, 2 replies; 5+ messages in thread
From: Tero Kristo @ 2020-03-16 14:48 UTC (permalink / raw)
  To: Stephen Boyd, Michael Turquette, Stephen Boyd, Tony Lindgren
  Cc: devicetree, linux-clk, linux-omap

On 21/02/2020 20:49, Stephen Boyd wrote:
> Quoting Tony Lindgren (2020-02-21 09:10:30)
>> Currently enabling clkctrl clock on am4 can fail for RTC as the clock
>> parent is wrong for RTC.
>>
>> Fixes: 76a1049b84dd ("clk: ti: am43xx: add new clkctrl data for am43xx")
>> Signed-off-by: Tony Lindgren <tony@atomide.com>
>> ---
>>
>> It is unclear if we can end up with RTC hung with the current mainline
>> kernel in some cases. Probing RTC with device tree data only seems to
>> trigger this every time.
> 
> It's small enough and if it's annoying enough we can probably put it
> into clk-fixes to get it fixed for this release instead of waiting. Can
> Tero ack it?
> 

Sure,

Acked-by: Tero Kristo <t-kristo@ti.com>
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] clk: ti: am43xx: Fix clock parent for RTC clock
  2020-03-16 14:48   ` Tero Kristo
@ 2020-03-16 18:28     ` Stephen Boyd
  2020-03-16 18:28     ` Stephen Boyd
  1 sibling, 0 replies; 5+ messages in thread
From: Stephen Boyd @ 2020-03-16 18:28 UTC (permalink / raw)
  To: Michael Turquette, Stephen Boyd, Tero Kristo, Tony Lindgren
  Cc: devicetree, linux-clk, linux-omap

Quoting Tero Kristo (2020-03-16 07:48:30)
> On 21/02/2020 20:49, Stephen Boyd wrote:
> > Quoting Tony Lindgren (2020-02-21 09:10:30)
> >> Currently enabling clkctrl clock on am4 can fail for RTC as the clock
> >> parent is wrong for RTC.
> >>
> >> Fixes: 76a1049b84dd ("clk: ti: am43xx: add new clkctrl data for am43xx")
> >> Signed-off-by: Tony Lindgren <tony@atomide.com>
> >> ---
> >>
> >> It is unclear if we can end up with RTC hung with the current mainline
> >> kernel in some cases. Probing RTC with device tree data only seems to
> >> trigger this every time.
> > 
> > It's small enough and if it's annoying enough we can probably put it
> > into clk-fixes to get it fixed for this release instead of waiting. Can
> > Tero ack it?
> > 
> 
> Sure,
> 
> Acked-by: Tero Kristo <t-kristo@ti.com>
> --
> Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] clk: ti: am43xx: Fix clock parent for RTC clock
  2020-03-16 14:48   ` Tero Kristo
  2020-03-16 18:28     ` Stephen Boyd
@ 2020-03-16 18:28     ` Stephen Boyd
  1 sibling, 0 replies; 5+ messages in thread
From: Stephen Boyd @ 2020-03-16 18:28 UTC (permalink / raw)
  To: Michael Turquette, Stephen Boyd, Tero Kristo, Tony Lindgren
  Cc: devicetree, linux-clk, linux-omap

Quoting Tero Kristo (2020-03-16 07:48:30)
> On 21/02/2020 20:49, Stephen Boyd wrote:
> > Quoting Tony Lindgren (2020-02-21 09:10:30)
> >> Currently enabling clkctrl clock on am4 can fail for RTC as the clock
> >> parent is wrong for RTC.
> >>
> >> Fixes: 76a1049b84dd ("clk: ti: am43xx: add new clkctrl data for am43xx")
> >> Signed-off-by: Tony Lindgren <tony@atomide.com>
> >> ---
> >>
> >> It is unclear if we can end up with RTC hung with the current mainline
> >> kernel in some cases. Probing RTC with device tree data only seems to
> >> trigger this every time.
> > 
> > It's small enough and if it's annoying enough we can probably put it
> > into clk-fixes to get it fixed for this release instead of waiting. Can
> > Tero ack it?
> > 
> 
> Sure,
> 
> Acked-by: Tero Kristo <t-kristo@ti.com>

Woops, hit send too fast. Thanks! Picked it into clk-fixes.

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, back to index

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-21 17:10 [PATCH] clk: ti: am43xx: Fix clock parent for RTC clock Tony Lindgren
2020-02-21 18:49 ` Stephen Boyd
2020-03-16 14:48   ` Tero Kristo
2020-03-16 18:28     ` Stephen Boyd
2020-03-16 18:28     ` Stephen Boyd

Linux-OMAP Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-omap/0 linux-omap/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-omap linux-omap/ https://lore.kernel.org/linux-omap \
		linux-omap@vger.kernel.org
	public-inbox-index linux-omap

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-omap


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git