From: David Brownell <david-b@pacbell.net>
To: Mark Brown <broonie@sirena.org.uk>
Cc: Liam Girdwood <lrg@slimlogic.co.uk>,
lkml <linux-kernel@vger.kernel.org>,
OMAP <linux-omap@vger.kernel.org>
Subject: Re: [patch 2.6.29-rc7 regulator-next] regulator: refcount fixes
Date: Thu, 12 Mar 2009 12:35:24 -0800 [thread overview]
Message-ID: <200903121335.25368.david-b@pacbell.net> (raw)
In-Reply-To: <20090312103744.GA24376@sirena.org.uk>
On Thursday 12 March 2009, Mark Brown wrote:
> On Wed, Mar 11, 2009 at 04:43:34PM -0800, David Brownell wrote:
>
> > Buggy consumers could notice different bug symptoms. The main
> > example would be refcounting bugs; also, any (out-of-tree) users
> > of the experimental regulator_set_optimum_mode() stuff which
> > don't call it when they're done using a regulator.
>
> I'm OK with this from a code point of view so
>
> Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
>
> However any consumers that take advantage of this won't be able to
> safely share a regulator without extra work since they have no way of
> telling why a regulator is in the state that it's in without extra
> stuff.
Depends what you mean by "safely". If they weren't buggy
already, I don't see how they'd notice any difference.
Having buggy consumers become non-buggy isn't exactly a
job for the framework itself.
> We should probably have something along the lines of a
> regulator_get_exclusive() for them. Previously the consumer counting
> would have stopped them interfering with enables done by other
> consumers.
I'd like to see get()/put() match the design pattern used
elsewhere in the kernel: those calls signify refcount
operations.
Agreed that the "consumer" access model probably needs a few
interface updates. I'm not sure what they would be though;
one notion would be to focus on the constraints they apply
(including "enabled") instead of what they do now.
> There will be other consumers that can't safely share a regulator anyway
> (eg, requiring additional code to notice and handle voltage changes) so
> it'd be a good thing to have.
next prev parent reply other threads:[~2009-03-12 20:36 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-12 0:43 [patch 2.6.29-rc7 regulator-next] regulator: refcount fixes David Brownell
2009-03-12 2:32 ` [patch 2.6.29-rc7 regulator-next] regulator: init fixes David Brownell
2009-03-12 12:01 ` Mark Brown
2009-03-15 0:25 ` [patch 2.6.29-rc8 regulator-next] regulator: init fixes (v4) David Brownell
2009-03-15 0:37 ` Mark Brown
2009-03-15 4:05 ` David Brownell
2009-03-16 21:54 ` Mark Brown
2009-03-17 18:15 ` David Brownell
2009-03-17 20:08 ` Mark Brown
2009-03-18 19:25 ` David Brownell
2009-03-18 20:33 ` Mark Brown
2009-03-18 21:02 ` David Brownell
2009-03-19 19:27 ` Mark Brown
2009-03-18 21:14 ` David Brownell
2009-03-19 16:59 ` Mark Brown
2009-03-15 4:16 ` [patch 2.6.29-rc7 regulator-next] regulator: init fixes David Brownell
2009-03-12 10:37 ` [patch 2.6.29-rc7 regulator-next] regulator: refcount fixes Mark Brown
2009-03-12 20:35 ` David Brownell [this message]
2009-03-12 21:05 ` Mark Brown
2009-03-12 23:02 ` David Brownell
2009-03-13 1:38 ` Mark Brown
2009-03-14 21:29 ` David Brownell
2009-03-15 0:30 ` Mark Brown
2009-03-15 4:27 ` David Brownell
2009-03-12 10:56 ` Liam Girdwood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200903121335.25368.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=broonie@sirena.org.uk \
--cc=dbrownell@users.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).