From: David Brownell <david-b@pacbell.net>
To: Mark Brown <broonie@sirena.org.uk>
Cc: Liam Girdwood <lrg@slimlogic.co.uk>,
lkml <linux-kernel@vger.kernel.org>,
OMAP <linux-omap@vger.kernel.org>
Subject: Re: [patch 2.6.29-rc7 regulator-next] regulator: refcount fixes
Date: Sat, 14 Mar 2009 21:27:26 -0700 [thread overview]
Message-ID: <200903142127.26182.david-b@pacbell.net> (raw)
In-Reply-To: <20090315003039.GA11052@sirena.org.uk>
On Saturday 14 March 2009, Mark Brown wrote:
> Looking at things from the point of view of the consumer I just don't
> find that it makes any difference since as far as the consumer is
> concerned it's all opaque objects manipulated via an API.
These put()/get() calls are not refcount calls. They're
what might be called alloc()/free() calls instead.
> foo = foo_get(dev, name);
The normal idiom is
bar = foo_get(foo)
which just increments a refcount. Then if "bar" were handed
to something else ("baz") right here, and "baz" needed to keep a
copy of that reference, it would be expected to grab its own
refcount via foo_get(bar), and later release via foo_put(bar).
> foo_enable(foo);
> foo_disable(foo);
> foo_put(foo);
Until "baz" called foo_put(bar), that reference would still be
usable. But ... regulator_put(foo) does a kfree, it's not
just updating refcounts.
next prev parent reply other threads:[~2009-03-15 4:27 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-12 0:43 [patch 2.6.29-rc7 regulator-next] regulator: refcount fixes David Brownell
2009-03-12 2:32 ` [patch 2.6.29-rc7 regulator-next] regulator: init fixes David Brownell
2009-03-12 12:01 ` Mark Brown
2009-03-15 0:25 ` [patch 2.6.29-rc8 regulator-next] regulator: init fixes (v4) David Brownell
2009-03-15 0:37 ` Mark Brown
2009-03-15 4:05 ` David Brownell
2009-03-16 21:54 ` Mark Brown
2009-03-17 18:15 ` David Brownell
2009-03-17 20:08 ` Mark Brown
2009-03-18 19:25 ` David Brownell
2009-03-18 20:33 ` Mark Brown
2009-03-18 21:02 ` David Brownell
2009-03-19 19:27 ` Mark Brown
2009-03-18 21:14 ` David Brownell
2009-03-19 16:59 ` Mark Brown
2009-03-15 4:16 ` [patch 2.6.29-rc7 regulator-next] regulator: init fixes David Brownell
2009-03-12 10:37 ` [patch 2.6.29-rc7 regulator-next] regulator: refcount fixes Mark Brown
2009-03-12 20:35 ` David Brownell
2009-03-12 21:05 ` Mark Brown
2009-03-12 23:02 ` David Brownell
2009-03-13 1:38 ` Mark Brown
2009-03-14 21:29 ` David Brownell
2009-03-15 0:30 ` Mark Brown
2009-03-15 4:27 ` David Brownell [this message]
2009-03-12 10:56 ` Liam Girdwood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200903142127.26182.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=broonie@sirena.org.uk \
--cc=dbrownell@users.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).