From: Hans Verkuil <hverkuil@xs4all.nl>
To: "Aguirre Rodriguez, Sergio Alberto" <saaguirre@ti.com>
Cc: Sakari Ailus <sakari.ailus@maxwell.research.nokia.com>,
"camera@ok.research.nokia.com" <camera@ok.research.nokia.com>,
"Menon, Nishanth" <nm@ti.com>, "Lakhani, Amish" <amish@ti.com>,
"Nagalla, Hari" <hnagalla@ti.com>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"linux-media@vger.kernel.org" <linux-media@vger.kernel.org>
Subject: Re: Some possible missing v4l2_subdev IOCTLs.
Date: Fri, 20 Mar 2009 08:19:17 +0100 [thread overview]
Message-ID: <200903200819.18011.hverkuil@xs4all.nl> (raw)
In-Reply-To: <A24693684029E5489D1D202277BE89442E6B1E33@dlee02.ent.ti.com>
On Friday 20 March 2009 03:24:49 Aguirre Rodriguez, Sergio Alberto wrote:
> Hi Hans,
>
> I did a quick analysis of the subdev, and noticed that some video ioctls
> for the subdevices aren't there...
>
> [gs]_crop
> [gs]_parm
> enum_frameintervals
> enum_framesizes
> enum_fmt_cap
>
> I noticed this because we currently use them for a "best sensor output"
> selection before sending the image to the OMAP3 ISP.
>
> Any particular reason why these aren't there?
Because no other i2c drivers needed them until now. I try to avoid adding
code that nobody is using.
Note that gs_parm was just added. And in video_ops there is already an
enum_fmt. Feel free to add crop and the enum_frame* ops. If you mail me a
patch, then I'll commit it.
Regards,
Hans
--
Hans Verkuil - video4linux developer - sponsored by TANDBERG
prev parent reply other threads:[~2009-03-20 7:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-20 2:24 Some possible missing v4l2_subdev IOCTLs Aguirre Rodriguez, Sergio Alberto
2009-03-20 7:19 ` Hans Verkuil [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200903200819.18011.hverkuil@xs4all.nl \
--to=hverkuil@xs4all.nl \
--cc=amish@ti.com \
--cc=camera@ok.research.nokia.com \
--cc=hnagalla@ti.com \
--cc=linux-media@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=nm@ti.com \
--cc=saaguirre@ti.com \
--cc=sakari.ailus@maxwell.research.nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).