From: Lee Jones <lee.jones@linaro.org>
To: Vignesh R <vigneshr@ti.com>
Cc: Jonathan Cameron <jic23@kernel.org>,
Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
linux-iio@vger.kernel.org, linux-omap@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] mfd: ti_am335x_tscadc: Provide unique name for child mfd cells
Date: Wed, 28 Nov 2018 11:03:21 +0000 [thread overview]
Message-ID: <20181128110321.GG4272@dell> (raw)
In-Reply-To: <16f2b753-1fde-3d20-6ddf-5dc5e4f13a15@ti.com>
On Wed, 28 Nov 2018, Vignesh R wrote:
> Hi,
>
> On 28/11/18 2:37 PM, Lee Jones wrote:
> > On Mon, 19 Nov 2018, Vignesh R wrote:
> >
> >> Provide unique names for child mfd cells, this is required in order to
> >> support registering of multiple instances of same ti_am335x_tscadc IP.
> >
> > I don't think it is. What is the error you are receiving?
>
> W/o this patch I get:
>
> [ 2.296839] sysfs: cannot create duplicate filename '/bus/platform/devices/TI-am335x-adc'
> [ 2.305085] CPU: 0 PID: 31 Comm: kworker/0:1 Not tainted 4.20.0-rc3-next-20181123-00018-g
> 7791ce8f123f-dirty #182
> [ 2.315254] Hardware name: Texas Instruments AM654 Base Board (DT)
> [ 2.321447] Workqueue: events deferred_probe_work_func
> [ 2.326585] Call trace:
> [ 2.329036] dump_backtrace+0x0/0x1c0
> [ 2.332699] show_stack+0x14/0x20
> [ 2.336017] dump_stack+0x9c/0xbc
> [ 2.339333] sysfs_warn_dup+0x60/0x78
> [ 2.342995] sysfs_do_create_link_sd.isra.0+0xdc/0xe8
> [ 2.348042] sysfs_create_link+0x20/0x40
> [ 2.351963] bus_add_device+0x68/0x130
> [ 2.355711] device_add+0x398/0x618
> [ 2.359199] platform_device_add+0x120/0x290
> [ 2.363469] mfd_add_device+0x23c/0x2e8
> [ 2.367302] mfd_add_devices+0xb4/0x158
> [ 2.371136] ti_tscadc_probe+0x35c/0x4c8
> [ 2.375056] platform_drv_probe+0x50/0xa0
> [ 2.379062] really_probe+0x204/0x2a8
> [ 2.382722] driver_probe_device+0x58/0x100
> [ 2.386903] __device_attach_driver+0x98/0xf0
> [ 2.391258] bus_for_each_drv+0x64/0xc8
> [ 2.395091] __device_attach+0xd8/0x138
> [ 2.398923] device_initial_probe+0x10/0x18
> [ 2.403103] bus_probe_device+0x90/0x98
> [ 2.406938] deferred_probe_work_func+0x74/0xb0
> [ 2.411470] process_one_work+0x1e0/0x330
> [ 2.415478] worker_thread+0x238/0x460
> [ 2.419225] kthread+0x128/0x130
> [ 2.422452] ret_from_fork+0x10/0x1c
> [ 2.426195] ti_am3359-tscadc: probe of 40210000.tscadc failed with error -1
That's because of the way the cells are being registered:
err = mfd_add_devices(&pdev->dev, pdev->id, tscadc->cells,
tscadc->used_cells, NULL, 0, NULL);
The cells are not numbered (tscadc->cells->id is always 0) and you are
forcing the use of the platform ID from the parent platform device
(with pdev->id here). Instead you should s/pdev->id/PLATFORM_DEVID_AUTO/
or number the cells manually. I suggest the former.
> >> Signed-off-by: Vignesh R <vigneshr@ti.com>
> >> ---
> >> drivers/mfd/ti_am335x_tscadc.c | 6 ++++--
> >> 1 file changed, 4 insertions(+), 2 deletions(-)
> >>
> >> diff --git a/drivers/mfd/ti_am335x_tscadc.c b/drivers/mfd/ti_am335x_tscadc.c
> >> index c2d47d78705b..ee08af34f81d 100644
> >> --- a/drivers/mfd/ti_am335x_tscadc.c
> >> +++ b/drivers/mfd/ti_am335x_tscadc.c
> >> @@ -248,7 +248,8 @@ static int ti_tscadc_probe(struct platform_device *pdev)
> >> if (tsc_wires > 0) {
> >> tscadc->tsc_cell = tscadc->used_cells;
> >> cell = &tscadc->cells[tscadc->used_cells++];
> >> - cell->name = "TI-am335x-tsc";
> >> + cell->name = devm_kasprintf(&pdev->dev, GFP_KERNEL, "%s:%s",
> >> + dev_name(&pdev->dev), "tsc");
> >> cell->of_compatible = "ti,am3359-tsc";
> >> cell->platform_data = &tscadc;
> >> cell->pdata_size = sizeof(tscadc);
> >> @@ -258,7 +259,8 @@ static int ti_tscadc_probe(struct platform_device *pdev)
> >> if (adc_channels > 0) {
> >> tscadc->adc_cell = tscadc->used_cells;
> >> cell = &tscadc->cells[tscadc->used_cells++];
> >> - cell->name = "TI-am335x-adc";
> >> + cell->name = devm_kasprintf(&pdev->dev, GFP_KERNEL, "%s:%s",
> >> + dev_name(&pdev->dev), "adc");
> >> cell->of_compatible = "ti,am3359-adc";
> >> cell->platform_data = &tscadc;
> >> cell->pdata_size = sizeof(tscadc);
> >
>
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2018-11-28 11:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-19 6:42 [PATCH 0/2] tscadc: Couple of fixes Vignesh R
2018-11-19 6:42 ` [PATCH 1/2] mfd: ti_am335x_tscadc: Provide unique name for child mfd cells Vignesh R
2018-11-28 9:07 ` Lee Jones
2018-11-28 9:21 ` Vignesh R
2018-11-28 11:03 ` Lee Jones [this message]
2018-11-28 11:43 ` Vignesh R
2018-11-19 6:42 ` [PATCH 2/2] iio: adc: ti_am335x_tscadc: Improve accuracy of measurement Vignesh R
2018-11-25 13:46 ` Jonathan Cameron
2018-11-28 9:14 ` Lee Jones
2018-12-01 15:04 ` Jonathan Cameron
2018-12-03 7:01 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181128110321.GG4272@dell \
--to=lee.jones@linaro.org \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).