From: Lee Jones <lee.jones@linaro.org>
To: Jonathan Cameron <jic23@kernel.org>
Cc: Vignesh R <vigneshr@ti.com>, Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
linux-iio@vger.kernel.org, linux-omap@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] iio: adc: ti_am335x_tscadc: Improve accuracy of measurement
Date: Mon, 3 Dec 2018 07:01:17 +0000 [thread overview]
Message-ID: <20181203070117.GI6009@dell> (raw)
In-Reply-To: <20181201150400.09706f47@archlinux>
On Sat, 01 Dec 2018, Jonathan Cameron wrote:
> On Wed, 28 Nov 2018 09:14:32 +0000
> Lee Jones <lee.jones@linaro.org> wrote:
>
> > On Mon, 19 Nov 2018, Vignesh R wrote:
> >
> > > When performing single ended measurements with TSCADC, its recommended
> > > to set negative input (SEL_INM_SWC_3_0) of ADC step to ADC's VREFN in the
> > > corresponding STEP_CONFIGx register.
> > > Also, the positive(SEL_RFP_SWC_2_0) and negative(SEL_RFM_SWC_1_0)
> > > reference voltage for ADC step needs to be set to VREFP and VREFN
> > > respectively in STEP_CONFIGx register.
> > > Without these changes, there may be variation of as much as ~2% in the
> > > ADC's digital output which is bad for precise measurement.
> > >
> > > Signed-off-by: Vignesh R <vigneshr@ti.com>
> > > ---
> > > drivers/iio/adc/ti_am335x_adc.c | 5 ++++-
> >
> > > include/linux/mfd/ti_am335x_tscadc.h | 4 ++++
> >
> > Acked-by: Lee Jones <lee.jones@linaro.org>
> >
> I'll leave this for v2 given changes in the first patch.
>
> My assumption is at the moment that both will go through mfd.
> Shout Lee if you have other plans.
I'm fine with that.
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
prev parent reply other threads:[~2018-12-03 7:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-19 6:42 [PATCH 0/2] tscadc: Couple of fixes Vignesh R
2018-11-19 6:42 ` [PATCH 1/2] mfd: ti_am335x_tscadc: Provide unique name for child mfd cells Vignesh R
2018-11-28 9:07 ` Lee Jones
2018-11-28 9:21 ` Vignesh R
2018-11-28 11:03 ` Lee Jones
2018-11-28 11:43 ` Vignesh R
2018-11-19 6:42 ` [PATCH 2/2] iio: adc: ti_am335x_tscadc: Improve accuracy of measurement Vignesh R
2018-11-25 13:46 ` Jonathan Cameron
2018-11-28 9:14 ` Lee Jones
2018-12-01 15:04 ` Jonathan Cameron
2018-12-03 7:01 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181203070117.GI6009@dell \
--to=lee.jones@linaro.org \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).