From: Tony Lindgren <tony@atomide.com>
To: Keerthy <j-keerthy@ti.com>
Cc: linux-rtc@vger.kernel.org, a.zummo@towertech.it,
alexandre.belloni@bootlin.com, d-gerlach@ti.com, t-kristo@ti.com,
ssantosh@kernel.org, linux-omap@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 3/5] arm: mach-omap2: pm33xx: Add support for rtc+ddr in self refresh mode
Date: Mon, 1 Apr 2019 10:52:45 -0700 [thread overview]
Message-ID: <20190401175245.GJ49658@atomide.com> (raw)
In-Reply-To: <20190322171619.4180-4-j-keerthy@ti.com>
Hi,
* Keerthy <j-keerthy@ti.com> [190322 17:16]:
> +static int am43xx_check_off_mode_enable(void)
> +{
> + /*
> + * Check for am437x-sk-evm which due to HW design cannot support
> + * this mode reliably.
> + */
> + if (of_machine_is_compatible("ti,am437x-sk-evm") && enable_off_mode) {
> + pr_warn("WARNING: This platform does not support off-mode, entering DeepSleep suspend.\n");
> + return 0;
> + }
> +
> + return enable_off_mode;
> +}
Considering off-mode suspend depends on how the board is
wired for various things such as memory, PMIC and the related
signal lines, I agree using the machine compatible is the best
check we can do here.
But since the device can hang during suspend unless things are
configured right for the board, I suggest you rather list allowed
boards here that are known to work with off-mode.
Otherwise many out-of-tree boards might hang during suspend
mysteriously.
Regards,
Tony
next prev parent reply other threads:[~2019-04-01 17:52 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-22 17:16 [PATCH 0/5] AM437x: Add rtc-only + DDR mode support Keerthy
2019-03-22 17:16 ` [PATCH 1/5] rtc: OMAP: Add support for rtc-only mode Keerthy
2019-04-01 5:58 ` Keerthy
2019-03-22 17:16 ` [PATCH 2/5] rtc: interface: Add power_off_program to rtc_class_ops Keerthy
2019-03-22 17:16 ` [PATCH 3/5] arm: mach-omap2: pm33xx: Add support for rtc+ddr in self refresh mode Keerthy
2019-04-01 17:52 ` Tony Lindgren [this message]
2019-04-01 18:38 ` Andreas Kemnade
2019-04-01 20:40 ` Tony Lindgren
2019-04-04 10:51 ` Andreas Kemnade
2019-04-04 14:11 ` Tony Lindgren
2019-03-22 17:16 ` [PATCH 4/5] soc: ti: pm33xx: Push the am33xx_push_sram_idle to the top Keerthy
2019-03-22 17:16 ` [PATCH 5/5] soc: ti: pm33xx: AM437X: Add rtc_only with ddr in self-refresh support Keerthy
2019-03-22 18:32 ` [PATCH 0/5] AM437x: Add rtc-only + DDR mode support Russell King - ARM Linux admin
2019-03-25 1:43 ` keerthy
2019-03-25 10:59 ` Russell King - ARM Linux admin
2019-03-26 4:34 ` keerthy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190401175245.GJ49658@atomide.com \
--to=tony@atomide.com \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=d-gerlach@ti.com \
--cc=j-keerthy@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=ssantosh@kernel.org \
--cc=t-kristo@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).