Re: [PATCH 3/6] serdev: ngsm: Add generic serdev-ngsm driver

[Pavel Machek <pavel@denx.de>]

[-- Attachment #1: Type: text/plain, Size: 1501 bytes --]

Hi!

> We can have a generic serdev-ngsm driver bring up the TS 27.010 line
> discipline on the selected serial ports based on device tree data.
> 
> And we can now do standard Linux device driver for the dedicated
> TS 27.010 channels for devices like GNSS and ALSA found on modems.


> +++ b/drivers/tty/serdev/Kconfig
> @@ -22,4 +22,14 @@ config SERIAL_DEV_CTRL_TTYPORT
>  	depends on SERIAL_DEV_BUS != m
>  	default y
>  
> +config SERIAL_DEV_N_GSM
> +	tristate "Serial device TS 27.010 support"
> +	help
> +	  Select this if you want to use the TS 27.010 with a serial port with
> +	  devices such as modems and GNSS devices.
> +
> +	  If unsure, say N.
> +	depends on N_GSM
> +	depends on SERIAL_DEV_CTRL_TTYPORT

Normally, depends go after "tristate" and before "help" text. I did
not realize this is valid code.

Reviewed-by: Pavel Machek <pavel@ucw.cz>

> +/*
> + * Configure SoC 8250 device for 700 ms autosuspend delay, Values around 600 ms
> + * and shorter cause spurious wake-up events at least on droid 4. Also keep the

droid->Droid?

> +static const struct serdev_ngsm_cfg motmdm_cfg = {
> +	.gsm = &adaption1,
> +	.init_retry_quirk = true,
> +	.needs_usb_phy = true,
> +	.aggressive_pm = true,

Umm. These are unsigned int:1, not bools, so = 1 would be expected
here.

Best regards,
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]