Linux-OMAP Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH -next] ARM: OMAP2+: pm33xx-core: Make am43xx_get_rtc_base_addr static
@ 2020-05-12  2:41 Samuel Zou
  2020-05-12 15:40 ` Tony Lindgren
  0 siblings, 1 reply; 2+ messages in thread
From: Samuel Zou @ 2020-05-12  2:41 UTC (permalink / raw)
  To: khilman, tony, linux
  Cc: linux-omap, linux-arm-kernel, linux-kernel, Samuel Zou

Fix the following sparse warning:

arch/arm/mach-omap2/pm33xx-core.c:270:14: warning: symbol 'am43xx_get_rtc_base_addr' was not declared.

The am43xx_get_rtc_base_addr has only call site within pm33xx-core.c
It should be static

Fixes: 8c5a916f4c88 ("ARM: OMAP2+: sleep33/43xx: Add RTC-Mode support")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Samuel Zou <zou_wei@huawei.com>
---
 arch/arm/mach-omap2/pm33xx-core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/mach-omap2/pm33xx-core.c b/arch/arm/mach-omap2/pm33xx-core.c
index 5455fc9..58236c7 100644
--- a/arch/arm/mach-omap2/pm33xx-core.c
+++ b/arch/arm/mach-omap2/pm33xx-core.c
@@ -267,7 +267,7 @@ static struct am33xx_pm_sram_addr *amx3_get_sram_addrs(void)
 		return NULL;
 }
 
-void __iomem *am43xx_get_rtc_base_addr(void)
+static void __iomem *am43xx_get_rtc_base_addr(void)
 {
 	rtc_oh = omap_hwmod_lookup("rtc");
 
-- 
2.6.2


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH -next] ARM: OMAP2+: pm33xx-core: Make am43xx_get_rtc_base_addr static
  2020-05-12  2:41 [PATCH -next] ARM: OMAP2+: pm33xx-core: Make am43xx_get_rtc_base_addr static Samuel Zou
@ 2020-05-12 15:40 ` Tony Lindgren
  0 siblings, 0 replies; 2+ messages in thread
From: Tony Lindgren @ 2020-05-12 15:40 UTC (permalink / raw)
  To: Samuel Zou; +Cc: khilman, linux, linux-omap, linux-arm-kernel, linux-kernel

* Samuel Zou <zou_wei@huawei.com> [200511 19:36]:
> Fix the following sparse warning:
> 
> arch/arm/mach-omap2/pm33xx-core.c:270:14: warning: symbol 'am43xx_get_rtc_base_addr' was not declared.
> 
> The am43xx_get_rtc_base_addr has only call site within pm33xx-core.c
> It should be static
> 
> Fixes: 8c5a916f4c88 ("ARM: OMAP2+: sleep33/43xx: Add RTC-Mode support")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Samuel Zou <zou_wei@huawei.com>

Applying into omap-for-v5.8/soc thanks.

Tony

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-12  2:41 [PATCH -next] ARM: OMAP2+: pm33xx-core: Make am43xx_get_rtc_base_addr static Samuel Zou
2020-05-12 15:40 ` Tony Lindgren

Linux-OMAP Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-omap/0 linux-omap/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-omap linux-omap/ https://lore.kernel.org/linux-omap \
		linux-omap@vger.kernel.org
	public-inbox-index linux-omap

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-omap


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git