From: Tony Lindgren <tony@atomide.com>
To: Grygorii Strashko <grygorii.strashko@ti.com>
Cc: "Drew Fustini" <drew@beagleboard.org>,
linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org,
"Benoît Cousson" <bcousson@baylibre.com>,
"Rob Herring" <robh+dt@kernel.org>,
devicetree@vger.kernel.org,
"Santosh Shilimkar" <ssantosh@kernel.org>,
"Suman Anna" <s-anna@ti.com>,
"Haojian Zhuang" <haojian.zhuang@linaro.org>,
"Linus Walleij" <linus.walleij@linaro.org>,
linux-gpio@vger.kernel.org
Subject: Re: [PATCH] ARM: dts: AM33xx-l4: add gpio-ranges
Date: Tue, 2 Jun 2020 06:51:55 -0700 [thread overview]
Message-ID: <20200602135155.GE37466@atomide.com> (raw)
In-Reply-To: <803e2d78-28ba-0816-dbb5-d441d7659a91@ti.com>
* Grygorii Strashko <grygorii.strashko@ti.com> [200602 13:44]:
>
>
> On 02/06/2020 16:14, Drew Fustini wrote:
> > Add gpio-ranges properties to the gpio controller nodes.
> >
> > These gpio-ranges were created based on "Table 9-10. CONTROL_MODULE
> > REGISTERS" in the "AM335x Technical Reference Manual" [0] and "Table
> > 4-2. Pin Attributes" in the "AM335x Sitara Processor datasheet" [1].
> > A csv file with this data is available for reference [2].
>
> It will be good if you can explain not only "what" is changed, but
> also "why" it's needed in commit message.
Also, please check (again) that this is the same for all the am3
variants. For omap3, we had different pad assignments even between
SoC revisions. Different pad routings should be easy to deal with
in the dts if needed though.
Regards,
Tony
next prev parent reply other threads:[~2020-06-02 13:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-02 13:14 [PATCH] ARM: dts: AM33xx-l4: add gpio-ranges Drew Fustini
2020-06-02 13:44 ` Grygorii Strashko
2020-06-02 13:51 ` Tony Lindgren [this message]
2020-06-02 16:34 ` Drew Fustini
2020-06-17 16:27 ` Drew Fustini
2020-06-17 16:55 ` Tony Lindgren
2020-06-02 18:24 ` Drew Fustini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200602135155.GE37466@atomide.com \
--to=tony@atomide.com \
--cc=bcousson@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=drew@beagleboard.org \
--cc=grygorii.strashko@ti.com \
--cc=haojian.zhuang@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=s-anna@ti.com \
--cc=ssantosh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).