linux-omap.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 0/2] Enable IPU and DSP rprocs on AM5729 BeagleBone AI
@ 2020-06-11 15:29 Suman Anna
  2020-06-11 15:29 ` [PATCH 1/2] ARM: dts: am5729-beaglebone-ai: Enable IPU & DSP rprocs Suman Anna
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Suman Anna @ 2020-06-11 15:29 UTC (permalink / raw)
  To: Tony Lindgren
  Cc: Jason Kridner, Caleb Robey, Drew Fustini, Robert Nelson,
	linux-omap, devicetree, linux-kernel, Suman Anna

Hi Tony, Jason, Caleb,

The IPU and DSP remote processors are finally booting as of latest master
on almost all the TI DRA7xx/AM57xx boards except for AM5729 BeagleBone AI
board. We have most of the common dts pieces available due to the usage
of common dra74-ipu-dsp.common.dtsi and dra7-ipu-dsp-common.dtsi files.
The series leverages these to enable both the IPUs (IPU1 and IPU2) and
DSPs (DSP1 and DSP2) on AM5729 BeagleBone AI board.

Patch 1 is enough to enable the support, and patch 2 is a cleanup.
Patches are based on latest master.

I don't have access to an BeagleBone AI board, so appreciate some testing
from any of you. If you are using the TI SDK firmware images, you would
need the following additional patch [1] to have the rpmsg devices published
successfully (otherwise you will see a malformed rpmsg ns message trace).
This patch is getting replaced with an alternate logic, and I am waiting
for that to be finalized before I update our BIOS-side logic/firmwares.

regards
Suman

[1] https://patchwork.kernel.org/patch/11096599/

Suman Anna (2):
  ARM: dts: am5729-beaglebone-ai: Enable IPU & DSP rprocs
  ARM: dts: am5729-beaglebone-ai: Disable ununsed mailboxes

 arch/arm/boot/dts/am5729-beagleboneai.dts | 73 +++++++----------------
 1 file changed, 21 insertions(+), 52 deletions(-)

-- 
2.26.0


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH 1/2] ARM: dts: am5729-beaglebone-ai: Enable IPU & DSP rprocs
  2020-06-11 15:29 [PATCH 0/2] Enable IPU and DSP rprocs on AM5729 BeagleBone AI Suman Anna
@ 2020-06-11 15:29 ` Suman Anna
  2020-06-11 15:29 ` [PATCH 2/2] ARM: dts: am5729-beaglebone-ai: Disable ununsed mailboxes Suman Anna
  2020-06-29 17:18 ` [PATCH 0/2] Enable IPU and DSP rprocs on AM5729 BeagleBone AI Tony Lindgren
  2 siblings, 0 replies; 4+ messages in thread
From: Suman Anna @ 2020-06-11 15:29 UTC (permalink / raw)
  To: Tony Lindgren
  Cc: Jason Kridner, Caleb Robey, Drew Fustini, Robert Nelson,
	linux-omap, devicetree, linux-kernel, Suman Anna

Assign the previously added CMA reserved memory nodes to the respective
IPU and DSP rproc device nodes, and enable these rproc nodes so that
these remote processors can be booted on the AM5729 BeagleBone AI board.

The addresses and sizes of the CMA pools are identical to those used on
various other TI AM572x/AM574x based boards. The mailboxes, timers and
watchdog-timers for all these remoteprocs are inherited by including the
common dra72-ipu-dsp-common.dtsi file.

An associated pair of the rproc node and its CMA node can be disabled
later on if there is no use-case defined to use that remote processor.

Signed-off-by: Suman Anna <s-anna@ti.com>
---
 arch/arm/boot/dts/am5729-beagleboneai.dts | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)

diff --git a/arch/arm/boot/dts/am5729-beagleboneai.dts b/arch/arm/boot/dts/am5729-beagleboneai.dts
index 9877d7709d41..619e75927224 100644
--- a/arch/arm/boot/dts/am5729-beagleboneai.dts
+++ b/arch/arm/boot/dts/am5729-beagleboneai.dts
@@ -8,6 +8,7 @@
 #include "dra74x.dtsi"
 #include "am57xx-commercial-grade.dtsi"
 #include "dra74x-mmc-iodelay.dtsi"
+#include "dra74-ipu-dsp-common.dtsi"
 #include <dt-bindings/gpio/gpio.h>
 #include <dt-bindings/interrupt-controller/irq.h>
 #include <dt-bindings/pinctrl/dra.h>
@@ -729,3 +730,23 @@ opp_slow-500000000 {
 		opp-shared;
 	};
 };
+
+&ipu2 {
+	status = "okay";
+	memory-region = <&ipu2_memory_region>;
+};
+
+&ipu1 {
+	status = "okay";
+	memory-region = <&ipu1_memory_region>;
+};
+
+&dsp1 {
+	status = "okay";
+	memory-region = <&dsp1_memory_region>;
+};
+
+&dsp2 {
+	status = "okay";
+	memory-region = <&dsp2_memory_region>;
+};
-- 
2.26.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH 2/2] ARM: dts: am5729-beaglebone-ai: Disable ununsed mailboxes
  2020-06-11 15:29 [PATCH 0/2] Enable IPU and DSP rprocs on AM5729 BeagleBone AI Suman Anna
  2020-06-11 15:29 ` [PATCH 1/2] ARM: dts: am5729-beaglebone-ai: Enable IPU & DSP rprocs Suman Anna
@ 2020-06-11 15:29 ` Suman Anna
  2020-06-29 17:18 ` [PATCH 0/2] Enable IPU and DSP rprocs on AM5729 BeagleBone AI Tony Lindgren
  2 siblings, 0 replies; 4+ messages in thread
From: Suman Anna @ 2020-06-11 15:29 UTC (permalink / raw)
  To: Tony Lindgren
  Cc: Jason Kridner, Caleb Robey, Drew Fustini, Robert Nelson,
	linux-omap, devicetree, linux-kernel, Suman Anna

The IPU and DSP remote processors use sub-mailbox nodes only from a
limited set of System Mailboxes 5 and 6 to achieve the Remote Processor
Messaging (RPMsg) communication stack between the MPU host processor
and the respective remote processor. These are all defined and enabled
through the inherited common dra74-ipu-dsp-common.dtsi file.

The other System Mailboxes do not define any actual sub-mailboxes, so
they serve no purpose and can all be safely dropped.

Signed-off-by: Suman Anna <s-anna@ti.com>
---
 arch/arm/boot/dts/am5729-beagleboneai.dts | 52 -----------------------
 1 file changed, 52 deletions(-)

diff --git a/arch/arm/boot/dts/am5729-beagleboneai.dts b/arch/arm/boot/dts/am5729-beagleboneai.dts
index 619e75927224..d3e345d6634a 100644
--- a/arch/arm/boot/dts/am5729-beagleboneai.dts
+++ b/arch/arm/boot/dts/am5729-beagleboneai.dts
@@ -630,58 +630,6 @@ &bandgap {
 	status = "okay";
 };
 
-&mailbox1 {
-	status = "okay";
-};
-
-&mailbox2 {
-	status = "okay";
-};
-
-&mailbox3 {
-	status = "okay";
-};
-
-&mailbox4 {
-	status = "okay";
-};
-
-&mailbox5 {
-	status = "okay";
-};
-
-&mailbox6 {
-	status = "okay";
-};
-
-&mailbox7 {
-	status = "okay";
-};
-
-&mailbox8 {
-	status = "okay";
-};
-
-&mailbox9 {
-	status = "okay";
-};
-
-&mailbox10 {
-	status = "okay";
-};
-
-&mailbox11 {
-	status = "okay";
-};
-
-&mailbox12 {
-	status = "okay";
-};
-
-&mailbox13 {
-	status = "okay";
-};
-
 &cpu_alert0 {
 	temperature = <55000>; /* milliCelsius */
 };
-- 
2.26.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH 0/2] Enable IPU and DSP rprocs on AM5729 BeagleBone AI
  2020-06-11 15:29 [PATCH 0/2] Enable IPU and DSP rprocs on AM5729 BeagleBone AI Suman Anna
  2020-06-11 15:29 ` [PATCH 1/2] ARM: dts: am5729-beaglebone-ai: Enable IPU & DSP rprocs Suman Anna
  2020-06-11 15:29 ` [PATCH 2/2] ARM: dts: am5729-beaglebone-ai: Disable ununsed mailboxes Suman Anna
@ 2020-06-29 17:18 ` Tony Lindgren
  2 siblings, 0 replies; 4+ messages in thread
From: Tony Lindgren @ 2020-06-29 17:18 UTC (permalink / raw)
  To: Suman Anna
  Cc: Jason Kridner, Caleb Robey, Drew Fustini, Robert Nelson,
	linux-omap, devicetree, linux-kernel

* Suman Anna <s-anna@ti.com> [200611 08:30]:
> Hi Tony, Jason, Caleb,
> 
> The IPU and DSP remote processors are finally booting as of latest master
> on almost all the TI DRA7xx/AM57xx boards except for AM5729 BeagleBone AI
> board. We have most of the common dts pieces available due to the usage
> of common dra74-ipu-dsp.common.dtsi and dra7-ipu-dsp-common.dtsi files.
> The series leverages these to enable both the IPUs (IPU1 and IPU2) and
> DSPs (DSP1 and DSP2) on AM5729 BeagleBone AI board.

Thanks applying both into omap-for-v5.9/dt.

Tony

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-06-29 22:06 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-11 15:29 [PATCH 0/2] Enable IPU and DSP rprocs on AM5729 BeagleBone AI Suman Anna
2020-06-11 15:29 ` [PATCH 1/2] ARM: dts: am5729-beaglebone-ai: Enable IPU & DSP rprocs Suman Anna
2020-06-11 15:29 ` [PATCH 2/2] ARM: dts: am5729-beaglebone-ai: Disable ununsed mailboxes Suman Anna
2020-06-29 17:18 ` [PATCH 0/2] Enable IPU and DSP rprocs on AM5729 BeagleBone AI Tony Lindgren

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).