linux-omap.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ARM: dts: logicpd-som-lv-baseboard: Fix missing video
@ 2020-08-14 12:24 Adam Ford
  2020-08-17 11:27 ` Tony Lindgren
  0 siblings, 1 reply; 2+ messages in thread
From: Adam Ford @ 2020-08-14 12:24 UTC (permalink / raw)
  To: linux-omap
  Cc: Adam Ford, Benoît Cousson, Tony Lindgren, Rob Herring,
	Tomi Valkeinen, Laurent Pinchart, Sebastian Reichel, devicetree,
	linux-kernel

A previous commit removed the panel-dpi driver, which made the
SOM-LV video stop working because it relied on the DPI driver
for setting video timings.  Now that the simple-panel driver is
available in omap2plus, this patch migrates the SOM-LV dev kits
to use a similar panel and remove the manual timing requirements.
A similar patch was already done and applied to the Torpedo family.

Fixes: 8bf4b1621178 ("drm/omap: Remove panel-dpi driver")

Signed-off-by: Adam Ford <aford173@gmail.com>

diff --git a/arch/arm/boot/dts/logicpd-som-lv-baseboard.dtsi b/arch/arm/boot/dts/logicpd-som-lv-baseboard.dtsi
index 100396f6c2fe..79e9e24328b9 100644
--- a/arch/arm/boot/dts/logicpd-som-lv-baseboard.dtsi
+++ b/arch/arm/boot/dts/logicpd-som-lv-baseboard.dtsi
@@ -102,35 +102,18 @@ video_reg: video_reg {
 		regulator-max-microvolt = <3300000>;
 	};
 
-	lcd0: display@0 {
-		compatible = "panel-dpi";
-		label = "28";
-		status = "okay";
-		/* default-on; */
+	lcd0: display {
+		/* This isn't the exact LCD, but the timings meet spec */
+		compatible = "logicpd,type28";
 		pinctrl-names = "default";
 		pinctrl-0 = <&lcd_enable_pin>;
-		enable-gpios = <&gpio5 27 GPIO_ACTIVE_HIGH>;	/* gpio155, lcd INI */
+		backlight = <&bl>;
+		enable-gpios = <&gpio5 27 GPIO_ACTIVE_HIGH>;
 		port {
 			lcd_in: endpoint {
 				remote-endpoint = <&dpi_out>;
 			};
 		};
-
-		panel-timing {
-			clock-frequency = <9000000>;
-			hactive = <480>;
-			vactive = <272>;
-			hfront-porch = <3>;
-			hback-porch = <2>;
-			hsync-len = <42>;
-			vback-porch = <3>;
-			vfront-porch = <2>;
-			vsync-len = <11>;
-			hsync-active = <1>;
-			vsync-active = <1>;
-			de-active = <1>;
-			pixelclk-active = <0>;
-		};
 	};
 
 	bl: backlight {
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] ARM: dts: logicpd-som-lv-baseboard: Fix missing video
  2020-08-14 12:24 [PATCH] ARM: dts: logicpd-som-lv-baseboard: Fix missing video Adam Ford
@ 2020-08-17 11:27 ` Tony Lindgren
  0 siblings, 0 replies; 2+ messages in thread
From: Tony Lindgren @ 2020-08-17 11:27 UTC (permalink / raw)
  To: Adam Ford
  Cc: linux-omap, Benoît Cousson, Rob Herring, Tomi Valkeinen,
	Laurent Pinchart, Sebastian Reichel, devicetree, linux-kernel

* Adam Ford <aford173@gmail.com> [200814 15:24]:
> A previous commit removed the panel-dpi driver, which made the
> SOM-LV video stop working because it relied on the DPI driver
> for setting video timings.  Now that the simple-panel driver is
> available in omap2plus, this patch migrates the SOM-LV dev kits
> to use a similar panel and remove the manual timing requirements.
> A similar patch was already done and applied to the Torpedo family.

Thanks applying into fixes.

Tony

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-08-17 11:27 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-14 12:24 [PATCH] ARM: dts: logicpd-som-lv-baseboard: Fix missing video Adam Ford
2020-08-17 11:27 ` Tony Lindgren

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).