From: Alexander Dahl <post@lespocky.de> To: Pavel Machek <pavel@ucw.cz>, Dan Murphy <dmurphy@ti.com>, Rob Herring <robh+dt@kernel.org> Cc: Alexander Dahl <ada@thorsis.com>, Jacek Anaszewski <jacek.anaszewski@gmail.com>, Alexander Dahl <post@lespocky.de>, linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-omap@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-amlogic@lists.infradead.org, linux-mips@vger.kernel.org, Kukjin Kim <kgene@kernel.org>, Krzysztof Kozlowski <krzk@kernel.org> Subject: [PATCH v7 07/12] ARM: dts: exynos: Fix schema warnings for pwm-leds Date: Mon, 5 Oct 2020 22:34:46 +0200 [thread overview] Message-ID: <20201005203451.9985-8-post@lespocky.de> (raw) In-Reply-To: <20201005203451.9985-1-post@lespocky.de> The node names for devices using the pwm-leds driver follow a certain naming scheme (now). Parent node name is not enforced, but recommended by DT project. DTC arch/arm/boot/dts/exynos5410-odroidxu.dt.yaml CHECK arch/arm/boot/dts/exynos5410-odroidxu.dt.yaml /home/alex/build/linux/arch/arm/boot/dts/exynos5410-odroidxu.dt.yaml: pwmleds: 'blueled', 'greenled' do not match any of the regexes: '^led(-[0-9a-f]+)?$', 'pinctrl-[0-9]+' From schema: /home/alex/src/linux/leds/Documentation/devicetree/bindings/leds/leds-pwm.yaml DTC arch/arm/boot/dts/exynos5422-odroidhc1.dt.yaml CHECK arch/arm/boot/dts/exynos5422-odroidhc1.dt.yaml /home/alex/build/linux/arch/arm/boot/dts/exynos5422-odroidhc1.dt.yaml: pwmleds: 'blueled' does not match any of the regexes: '^led(-[0-9a-f]+)?$', 'pinctrl-[0-9]+' From schema: /home/alex/src/linux/leds/Documentation/devicetree/bindings/leds/leds-pwm.yaml DTC arch/arm/boot/dts/exynos5422-odroidxu3.dt.yaml CHECK arch/arm/boot/dts/exynos5422-odroidxu3.dt.yaml /home/alex/build/linux/arch/arm/boot/dts/exynos5422-odroidxu3.dt.yaml: pwmleds: 'blueled', 'greenled' do not match any of the regexes: '^led(-[0-9a-f]+)?$', 'pinctrl-[0-9]+' From schema: /home/alex/src/linux/leds/Documentation/devicetree/bindings/leds/leds-pwm.yaml DTC arch/arm/boot/dts/exynos5422-odroidxu3-lite.dt.yaml CHECK arch/arm/boot/dts/exynos5422-odroidxu3-lite.dt.yaml /home/alex/build/linux/arch/arm/boot/dts/exynos5422-odroidxu3-lite.dt.yaml: pwmleds: 'blueled', 'greenled' do not match any of the regexes: '^led(-[0-9a-f]+)?$', 'pinctrl-[0-9]+' From schema: /home/alex/src/linux/leds/Documentation/devicetree/bindings/leds/leds-pwm.yaml DTC arch/arm/boot/dts/exynos5422-odroidxu4.dt.yaml CHECK arch/arm/boot/dts/exynos5422-odroidxu4.dt.yaml /home/alex/build/linux/arch/arm/boot/dts/exynos5422-odroidxu4.dt.yaml: pwmleds: 'blueled' does not match any of the regexes: '^led(-[0-9a-f]+)?$', 'pinctrl-[0-9]+' From schema: /home/alex/src/linux/leds/Documentation/devicetree/bindings/leds/leds-pwm.yaml Signed-off-by: Alexander Dahl <post@lespocky.de> --- Notes: v6 -> v7: * split up patch (one per sub arch) * added actual warnings to commit message arch/arm/boot/dts/exynos5422-odroidhc1.dts | 4 ++-- arch/arm/boot/dts/exynos5422-odroidxu4.dts | 4 ++-- arch/arm/boot/dts/exynos54xx-odroidxu-leds.dtsi | 11 ++++++----- 3 files changed, 10 insertions(+), 9 deletions(-) diff --git a/arch/arm/boot/dts/exynos5422-odroidhc1.dts b/arch/arm/boot/dts/exynos5422-odroidhc1.dts index 812659260278..20c222b33f98 100644 --- a/arch/arm/boot/dts/exynos5422-odroidhc1.dts +++ b/arch/arm/boot/dts/exynos5422-odroidhc1.dts @@ -15,10 +15,10 @@ compatible = "hardkernel,odroid-hc1", "samsung,exynos5800", \ "samsung,exynos5"; - pwmleds { + led-controller { compatible = "pwm-leds"; - blueled { + led-1 { label = "blue:heartbeat"; pwms = <&pwm 2 2000000 0>; pwm-names = "pwm2"; diff --git a/arch/arm/boot/dts/exynos5422-odroidxu4.dts b/arch/arm/boot/dts/exynos5422-odroidxu4.dts index 892d389d6d09..955065ee57a0 100644 --- a/arch/arm/boot/dts/exynos5422-odroidxu4.dts +++ b/arch/arm/boot/dts/exynos5422-odroidxu4.dts @@ -17,10 +17,10 @@ compatible = "hardkernel,odroid-xu4", "samsung,exynos5800", \ "samsung,exynos5"; - pwmleds { + led-controller { compatible = "pwm-leds"; - blueled { + led-1 { label = "blue:heartbeat"; pwms = <&pwm 2 2000000 0>; pwm-names = "pwm2"; diff --git a/arch/arm/boot/dts/exynos54xx-odroidxu-leds.dtsi b/arch/arm/boot/dts/exynos54xx-odroidxu-leds.dtsi index 56acd832f0b3..2fc3e86dc5f7 100644 --- a/arch/arm/boot/dts/exynos54xx-odroidxu-leds.dtsi +++ b/arch/arm/boot/dts/exynos54xx-odroidxu-leds.dtsi @@ -11,10 +11,10 @@ #include <dt-bindings/gpio/gpio.h> / { - pwmleds { + led-controller-1 { compatible = "pwm-leds"; - greenled { + led-1 { label = "green:mmc0"; pwms = <&pwm 1 2000000 0>; pwm-names = "pwm1"; @@ -26,7 +26,7 @@ linux,default-trigger = "mmc0"; }; - blueled { + led-2 { label = "blue:heartbeat"; pwms = <&pwm 2 2000000 0>; pwm-names = "pwm2"; @@ -35,9 +35,10 @@ }; }; - gpioleds { + led-controller-2 { compatible = "gpio-leds"; - redled { + + led-3 { label = "red:microSD"; gpios = <&gpx2 3 GPIO_ACTIVE_HIGH>; default-state = "off"; -- 2.20.1
next prev parent reply other threads:[~2020-10-05 20:36 UTC|newest] Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-10-05 20:34 [PATCH v7 00/12] leds: pwm: Make automatic labels work Alexander Dahl 2020-10-05 20:34 ` [PATCH v7 01/12] leds: pwm: Remove platform_data support Alexander Dahl 2020-10-07 10:03 ` Pavel Machek 2020-10-05 20:34 ` [PATCH v7 02/12] dt-bindings: leds: Convert pwm to yaml Alexander Dahl 2020-10-07 10:02 ` Pavel Machek 2020-10-07 10:03 ` Krzysztof Kozlowski 2020-10-28 20:39 ` Alexander Dahl 2020-10-29 13:46 ` Russell King - ARM Linux admin 2020-11-25 11:08 ` Pavel Machek 2020-10-05 20:34 ` [PATCH v7 03/12] dt-bindings: mfd: Fix schema warnings for pwm-leds Alexander Dahl 2020-10-06 2:17 ` Jeff LaBundy 2020-10-06 6:34 ` Alexander Dahl 2020-10-06 22:27 ` Rob Herring 2020-10-06 22:28 ` Rob Herring 2020-10-07 10:03 ` Pavel Machek 2020-10-07 10:08 ` Alexander Dahl 2020-10-08 7:33 ` Lee Jones 2020-10-08 7:50 ` Pavel Machek 2020-10-05 20:34 ` [PATCH v7 04/12] ARM: dts: at91: smartkiz: Reference led node directly Alexander Dahl 2020-10-05 20:34 ` [PATCH v7 05/12] ARM: dts: at91: Fix schema warnings for pwm-leds Alexander Dahl 2020-10-05 20:34 ` [PATCH v7 06/12] ARM: dts: berlin: " Alexander Dahl 2020-10-05 20:34 ` Alexander Dahl [this message] 2020-10-07 6:25 ` [PATCH v7 07/12] ARM: dts: exynos: " Krzysztof Kozlowski 2020-10-26 18:45 ` Krzysztof Kozlowski 2020-10-05 20:34 ` [PATCH v7 08/12] ARM: dts: imx: " Alexander Dahl 2020-10-30 7:46 ` Shawn Guo 2020-10-05 20:34 ` [PATCH v7 09/12] ARM: dts: omap: " Alexander Dahl 2020-11-10 13:25 ` Tony Lindgren 2020-10-05 20:34 ` [PATCH v7 10/12] ARM: dts: stm32: " Alexander Dahl 2020-10-27 7:03 ` [Linux-stm32] " Ahmad Fatoum 2020-10-27 10:05 ` Alexander Dahl 2020-10-27 10:58 ` Ahmad Fatoum 2020-10-28 7:34 ` Alexander Dahl 2020-11-02 10:47 ` Ahmad Fatoum 2020-10-05 20:34 ` [PATCH v7 11/12] arm64: dts: meson: " Alexander Dahl 2020-10-05 20:34 ` [PATCH v7 12/12] MIPS: DTS: img: " Alexander Dahl 2020-10-28 18:56 ` [PATCH v7 00/12] leds: pwm: Make automatic labels work Alexandre Belloni 2020-10-28 19:21 ` Alexandre Belloni
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20201005203451.9985-8-post@lespocky.de \ --to=post@lespocky.de \ --cc=ada@thorsis.com \ --cc=devicetree@vger.kernel.org \ --cc=dmurphy@ti.com \ --cc=jacek.anaszewski@gmail.com \ --cc=kgene@kernel.org \ --cc=krzk@kernel.org \ --cc=linux-amlogic@lists.infradead.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-leds@vger.kernel.org \ --cc=linux-mips@vger.kernel.org \ --cc=linux-omap@vger.kernel.org \ --cc=linux-samsung-soc@vger.kernel.org \ --cc=linux-stm32@st-md-mailman.stormreply.com \ --cc=pavel@ucw.cz \ --cc=robh+dt@kernel.org \ --subject='Re: [PATCH v7 07/12] ARM: dts: exynos: Fix schema warnings for pwm-leds' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).