From: Lin Ruizhe <linruizhe@huawei.com>
To: <rui.zhang@intel.com>, <edubezval@gmail.com>, <j-keerthy@ti.com>,
<daniel.lezcano@linaro.org>, <amitk@kernel.org>,
<gregkh@linuxfoundation.org>, <radhesh.fadnis@ti.com>,
<eballetbo@gmail.com>
Cc: <linux-pm@vger.kernel.org>, <linux-omap@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <linruizhe@huawei.com>
Subject: [PATCH v3] thermal: ti-soc-thermal: Remove unused variable 'val'
Date: Wed, 21 Apr 2021 16:42:56 +0800 [thread overview]
Message-ID: <20210421084256.57591-1-linruizhe@huawei.com> (raw)
The variable 'val'in function ti_bandgap_restore_ctxt is
the register value of read bandgap registers. This function is to
restore the context. But there is no operation on the return value
of this register, so this block is redundant. Hulk robot scans this
warning.This commit remove the dead code.
Reported-by: Hulk Robot <hulkci@huawei.com>
Fixes: b87ea759a4cc ("staging: omap-thermal: fix context restore function")
Signed-off-by: Lin Ruizhe <linruizhe@huawei.com>
---
v3:
-Add Fixes tag and more accurate commit message in this patch.
v2:
-As suggest remove the whole unuesed block in fuction
ti_bandgap_restore_ctxt
drivers/thermal/ti-soc-thermal/ti-bandgap.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/thermal/ti-soc-thermal/ti-bandgap.c b/drivers/thermal/ti-soc-thermal/ti-bandgap.c
index d81af89166d2..684ffb645aa9 100644
--- a/drivers/thermal/ti-soc-thermal/ti-bandgap.c
+++ b/drivers/thermal/ti-soc-thermal/ti-bandgap.c
@@ -1142,14 +1142,10 @@ static int ti_bandgap_restore_ctxt(struct ti_bandgap *bgp)
for (i = 0; i < bgp->conf->sensor_count; i++) {
struct temp_sensor_registers *tsr;
struct temp_sensor_regval *rval;
- u32 val = 0;
rval = &bgp->regval[i];
tsr = bgp->conf->sensors[i].registers;
- if (TI_BANDGAP_HAS(bgp, COUNTER))
- val = ti_bandgap_readl(bgp, tsr->bgap_counter);
-
if (TI_BANDGAP_HAS(bgp, TSHUT_CONFIG))
ti_bandgap_writel(bgp, rval->tshut_threshold,
tsr->tshut_threshold);
--
2.22.0
next reply other threads:[~2021-04-21 8:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-21 8:42 Lin Ruizhe [this message]
2021-04-21 8:49 ` [PATCH v3] thermal: ti-soc-thermal: Remove unused variable 'val' Greg KH
2021-04-21 9:06 ` Daniel Lezcano
2021-04-21 9:37 ` Tony Lindgren
2021-04-21 11:36 ` Daniel Lezcano
2021-04-22 12:39 ` 答复: " linruizhe
2021-04-22 13:50 ` Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210421084256.57591-1-linruizhe@huawei.com \
--to=linruizhe@huawei.com \
--cc=amitk@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=eballetbo@gmail.com \
--cc=edubezval@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=j-keerthy@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=radhesh.fadnis@ti.com \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).