linux-omap.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH RFC 05/13] mmc: omap: fix deferred probing
       [not found] <20211223171202.8224-1-s.shtylyov@omp.ru>
@ 2021-12-23 17:11 ` Sergey Shtylyov
  2021-12-23 17:11 ` [PATCH RFC 06/13] mmc: omap_hsmmc: " Sergey Shtylyov
  1 sibling, 0 replies; 2+ messages in thread
From: Sergey Shtylyov @ 2021-12-23 17:11 UTC (permalink / raw)
  To: Ulf Hansson, linux-mmc; +Cc: Aaro Koskinen, linux-omap

The driver overrides the error codes returned by platform_get_irq() to
-ENXIO, so if it returns -EPROBE_DEFER, the driver will fail the probe
permanently instead of the deferred probing. Switch to propagating the
error codes upstream.

Fixes: 9ec36cafe43b ("of/irq: do irq resolution in platform_get_irq")
Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
---
 drivers/mmc/host/omap.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mmc/host/omap.c b/drivers/mmc/host/omap.c
index 5e5af34090f1..ecf2a68d0e84 100644
--- a/drivers/mmc/host/omap.c
+++ b/drivers/mmc/host/omap.c
@@ -1343,7 +1343,7 @@ static int mmc_omap_probe(struct platform_device *pdev)
 
 	irq = platform_get_irq(pdev, 0);
 	if (irq < 0)
-		return -ENXIO;
+		return irq;
 
 	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
 	host->virt_base = devm_ioremap_resource(&pdev->dev, res);
-- 
2.26.3


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [PATCH RFC 06/13] mmc: omap_hsmmc: fix deferred probing
       [not found] <20211223171202.8224-1-s.shtylyov@omp.ru>
  2021-12-23 17:11 ` [PATCH RFC 05/13] mmc: omap: fix deferred probing Sergey Shtylyov
@ 2021-12-23 17:11 ` Sergey Shtylyov
  1 sibling, 0 replies; 2+ messages in thread
From: Sergey Shtylyov @ 2021-12-23 17:11 UTC (permalink / raw)
  To: Ulf Hansson, linux-mmc; +Cc: linux-omap

The driver overrides the error codes returned by platform_get_irq() to
-ENXIO, so if it returns -EPROBE_DEFER, the driver will fail the probe
permanently instead of the deferred probing. Switch to propagating the
error codes upstream.

Fixes: 9ec36cafe43b ("of/irq: do irq resolution in platform_get_irq")
Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
---
 drivers/mmc/host/omap_hsmmc.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c
index 9dafcbf969d9..6d7dd75b7664 100644
--- a/drivers/mmc/host/omap_hsmmc.c
+++ b/drivers/mmc/host/omap_hsmmc.c
@@ -1827,9 +1827,11 @@ static int omap_hsmmc_probe(struct platform_device *pdev)
 	}
 
 	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	irq = platform_get_irq(pdev, 0);
-	if (res == NULL || irq < 0)
+	if (!res)
 		return -ENXIO;
+	irq = platform_get_irq(pdev, 0);
+	if (irq < 0)
+		return irq;
 
 	base = devm_ioremap_resource(&pdev->dev, res);
 	if (IS_ERR(base))
-- 
2.26.3


^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-12-23 17:12 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20211223171202.8224-1-s.shtylyov@omp.ru>
2021-12-23 17:11 ` [PATCH RFC 05/13] mmc: omap: fix deferred probing Sergey Shtylyov
2021-12-23 17:11 ` [PATCH RFC 06/13] mmc: omap_hsmmc: " Sergey Shtylyov

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).