From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: "Benoît Cousson" <bcousson@baylibre.com>,
"Tony Lindgren" <tony@atomide.com>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Rob Herring" <robh+dt@kernel.org>
Cc: devicetree@vger.kernel.org, linux-omap@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH 2/4] ARM: dts: omap4-sdp: fix LCD reset line polarity
Date: Tue, 4 Oct 2022 14:35:01 -0700 [thread overview]
Message-ID: <20221004213503.848262-2-dmitry.torokhov@gmail.com> (raw)
In-Reply-To: <20221004213503.848262-1-dmitry.torokhov@gmail.com>
The LCD driver (panel-dsi-cm), when performing reset, starts with line
set high, then drives it low, holds it there for a moment, and releases
it back to high. This means that the reset line should be described
as "active low" in DTS. This will be important when the driver is
converted to gpiod API which respects the polarity declared in DTS.
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---
arch/arm/boot/dts/omap4-sdp.dts | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/omap4-sdp.dts b/arch/arm/boot/dts/omap4-sdp.dts
index 9e976140f34a..77e99b77a0c5 100644
--- a/arch/arm/boot/dts/omap4-sdp.dts
+++ b/arch/arm/boot/dts/omap4-sdp.dts
@@ -669,7 +669,7 @@ lcd0: panel@0 {
reg = <0>;
label = "lcd0";
- reset-gpios = <&gpio4 6 GPIO_ACTIVE_HIGH>; /* 102 */
+ reset-gpios = <&gpio4 6 GPIO_ACTIVE_LOW>; /* 102 */
port {
lcd0_in: endpoint {
@@ -695,7 +695,7 @@ lcd1: panel@0 {
reg = <0>;
label = "lcd1";
- reset-gpios = <&gpio4 8 GPIO_ACTIVE_HIGH>; /* 104 */
+ reset-gpios = <&gpio4 8 GPIO_ACTIVE_LOW>; /* 104 */
port {
lcd1_in: endpoint {
--
2.38.0.rc1.362.ged0d419d3c-goog
next prev parent reply other threads:[~2022-10-04 21:35 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-04 21:35 [PATCH 1/4] ARM: dts: omap3-n900: fix LCD reset line polarity Dmitry Torokhov
2022-10-04 21:35 ` Dmitry Torokhov [this message]
2022-10-04 21:35 ` [PATCH 3/4] ARM: dts: omap3-n950: " Dmitry Torokhov
2022-10-04 21:35 ` [PATCH 4/4] ARM: dts: motorola-mapphone: " Dmitry Torokhov
2022-10-11 5:45 ` [PATCH 1/4] ARM: dts: omap3-n900: " Tony Lindgren
2022-10-11 12:37 ` Sebastian Reichel
2022-10-11 14:06 ` Dmitry Torokhov
2022-10-11 14:30 ` Tony Lindgren
2022-10-11 14:38 ` Dmitry Torokhov
2022-10-11 14:47 ` Tony Lindgren
2022-10-12 10:58 ` Tomi Valkeinen
2022-10-12 19:30 ` Dmitry Torokhov
2022-10-13 6:22 ` Tomi Valkeinen
2022-10-13 11:08 ` Tony Lindgren
2022-10-13 13:17 ` Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221004213503.848262-2-dmitry.torokhov@gmail.com \
--to=dmitry.torokhov@gmail.com \
--cc=bcousson@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).