From: Sebastian Reichel <sre@kernel.org>
To: Tony Lindgren <tony@atomide.com>
Cc: "Tomi Valkeinen" <tomi.valkeinen@ideasonboard.com>,
"Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
"Benoît Cousson" <bcousson@baylibre.com>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Rob Herring" <robh+dt@kernel.org>,
devicetree@vger.kernel.org, linux-omap@vger.kernel.org,
linux-kernel@vger.kernel.org,
"Ivaylo Dimitrov" <ivo.g.dimitrov.75@gmail.com>
Subject: Re: [PATCH 1/4] ARM: dts: omap3-n900: fix LCD reset line polarity
Date: Thu, 13 Oct 2022 15:17:56 +0200 [thread overview]
Message-ID: <20221013131756.wzn6pea4thwmwipb@mercury.elektranox.org> (raw)
In-Reply-To: <Y0fxxsk+e2o0wYZV@atomide.com>
[-- Attachment #1: Type: text/plain, Size: 2507 bytes --]
Hi,
On Thu, Oct 13, 2022 at 02:08:54PM +0300, Tony Lindgren wrote:
> Hi,
>
> * Tomi Valkeinen <tomi.valkeinen@ideasonboard.com> [221013 06:13]:
> > I would just go with the above for the time being. It should be an easy
> > change, and as these omapfb and drm panel drivers are kind of copies of each
> > other, I think it makes sense to use the same code in both.
>
> Maybe if a fix is needed, sure let's fix things first, then drop
> the unused panel drivers.
>
> We already have drivers/gpu/drm/panel driver for both of these two
> omapfb panels:
>
> drivers/video/fbdev/omap2/omapfb/displays/panel-sony-acx565akm.c
> drivers/video/fbdev/omap2/omapfb/displays/panel-dsi-cm.c
>
> The compatible strings used translate to these dts files:
>
> arch/arm/boot/dts/motorola-mapphone-common.dtsi
> arch/arm/boot/dts/omap3-n900.dts
> arch/arm/boot/dts/omap3-n950.dts
> arch/arm/boot/dts/omap4-sdp.dts
>
> These devices work with omapdrm and there should not be any need to
> stick with the omapfb driver. We can just drop the omapfb panel
> drivers for panel-sony-acx565akm.c and panel-dsi-cm.c. Let's put
> the limited effort where there is activity instead :)
FWIW
Acked-by: Sebastian Reichel <sre@kernel.org>
for removal of those two omapfb panel drivers.
> The vrfb rotation work has been discussed on the lists, so seems
> like we will eventually have that for omapdrm. Meanwhile, software
> rotation is being used for postmarketos and leste with omapdrm
> AFAIK.
>
> > That said, I personally don't mind fixing the dts files and the drivers, and
> > even dropping the omapfb panel drivers. However, as I don't know if someone
> > needs the omapfb drivers or has to use an old dtb, I don't want to step on
> > that possible mine field. If someone else wants to go there (without my
> > involvement), fine for me =).
>
> I belive the only valid use case for omap2 omapfb is the n8x0 rfbi
> driver that has no omapdrm driver.
Is that upstream? omapfb (and omapdrm) both have this:
/*
* HACK
* We don't have a working driver for rfbi, so skip it here always.
* Otherwise dss will never get probed successfully, as it will wait
* for rfbi to get probed.
*/
if (strstr(dev_name(dev), "rfbi"))
return 0;
I've seen a few old drivers being removed by marking them as BROKEN
(and updating Kconfig help text to explain the situation). Then the
code is dropped 1-2 cycles later assuming nobody complained.
-- Sebastian
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2022-10-13 13:18 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-04 21:35 [PATCH 1/4] ARM: dts: omap3-n900: fix LCD reset line polarity Dmitry Torokhov
2022-10-04 21:35 ` [PATCH 2/4] ARM: dts: omap4-sdp: " Dmitry Torokhov
2022-10-04 21:35 ` [PATCH 3/4] ARM: dts: omap3-n950: " Dmitry Torokhov
2022-10-04 21:35 ` [PATCH 4/4] ARM: dts: motorola-mapphone: " Dmitry Torokhov
2022-10-11 5:45 ` [PATCH 1/4] ARM: dts: omap3-n900: " Tony Lindgren
2022-10-11 12:37 ` Sebastian Reichel
2022-10-11 14:06 ` Dmitry Torokhov
2022-10-11 14:30 ` Tony Lindgren
2022-10-11 14:38 ` Dmitry Torokhov
2022-10-11 14:47 ` Tony Lindgren
2022-10-12 10:58 ` Tomi Valkeinen
2022-10-12 19:30 ` Dmitry Torokhov
2022-10-13 6:22 ` Tomi Valkeinen
2022-10-13 11:08 ` Tony Lindgren
2022-10-13 13:17 ` Sebastian Reichel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221013131756.wzn6pea4thwmwipb@mercury.elektranox.org \
--to=sre@kernel.org \
--cc=bcousson@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=ivo.g.dimitrov.75@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=tomi.valkeinen@ideasonboard.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).