* [PATCH] fbdev: omapfb: panel-tpo-td043mtea1: fix error code in probe()
@ 2023-05-15 10:32 Dan Carpenter
2023-05-19 14:12 ` Helge Deller
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2023-05-15 10:32 UTC (permalink / raw)
To: Cai Huoqing
Cc: Helge Deller, Dmitry Torokhov, linux-omap, linux-fbdev, kernel-janitors
This was using the wrong variable, "r", instead of "ddata->vcc_reg", so
it returned success instead of a negative error code.
Fixes: 0d3dbeb8142a ("video: fbdev: omapfb: panel-tpo-td043mtea1: Make use of the helper function dev_err_probe()")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
.../video/fbdev/omap2/omapfb/displays/panel-tpo-td043mtea1.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/video/fbdev/omap2/omapfb/displays/panel-tpo-td043mtea1.c b/drivers/video/fbdev/omap2/omapfb/displays/panel-tpo-td043mtea1.c
index 1eaa35c27835..477789cff8e0 100644
--- a/drivers/video/fbdev/omap2/omapfb/displays/panel-tpo-td043mtea1.c
+++ b/drivers/video/fbdev/omap2/omapfb/displays/panel-tpo-td043mtea1.c
@@ -491,7 +491,8 @@ static int tpo_td043_probe(struct spi_device *spi)
ddata->vcc_reg = devm_regulator_get(&spi->dev, "vcc");
if (IS_ERR(ddata->vcc_reg)) {
- r = dev_err_probe(&spi->dev, r, "failed to get LCD VCC regulator\n");
+ r = dev_err_probe(&spi->dev, PTR_ERR(ddata->vcc_reg),
+ "failed to get LCD VCC regulator\n");
goto err_regulator;
}
--
2.39.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] fbdev: omapfb: panel-tpo-td043mtea1: fix error code in probe()
2023-05-15 10:32 [PATCH] fbdev: omapfb: panel-tpo-td043mtea1: fix error code in probe() Dan Carpenter
@ 2023-05-19 14:12 ` Helge Deller
0 siblings, 0 replies; 2+ messages in thread
From: Helge Deller @ 2023-05-19 14:12 UTC (permalink / raw)
To: Dan Carpenter, Cai Huoqing
Cc: Dmitry Torokhov, linux-omap, linux-fbdev, kernel-janitors
On 5/15/23 12:32, Dan Carpenter wrote:
> This was using the wrong variable, "r", instead of "ddata->vcc_reg", so
> it returned success instead of a negative error code.
>
> Fixes: 0d3dbeb8142a ("video: fbdev: omapfb: panel-tpo-td043mtea1: Make use of the helper function dev_err_probe()")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> ---
> .../video/fbdev/omap2/omapfb/displays/panel-tpo-td043mtea1.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
applied.
Thanks!
Helge
>
> diff --git a/drivers/video/fbdev/omap2/omapfb/displays/panel-tpo-td043mtea1.c b/drivers/video/fbdev/omap2/omapfb/displays/panel-tpo-td043mtea1.c
> index 1eaa35c27835..477789cff8e0 100644
> --- a/drivers/video/fbdev/omap2/omapfb/displays/panel-tpo-td043mtea1.c
> +++ b/drivers/video/fbdev/omap2/omapfb/displays/panel-tpo-td043mtea1.c
> @@ -491,7 +491,8 @@ static int tpo_td043_probe(struct spi_device *spi)
>
> ddata->vcc_reg = devm_regulator_get(&spi->dev, "vcc");
> if (IS_ERR(ddata->vcc_reg)) {
> - r = dev_err_probe(&spi->dev, r, "failed to get LCD VCC regulator\n");
> + r = dev_err_probe(&spi->dev, PTR_ERR(ddata->vcc_reg),
> + "failed to get LCD VCC regulator\n");
> goto err_regulator;
> }
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-05-19 14:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-05-15 10:32 [PATCH] fbdev: omapfb: panel-tpo-td043mtea1: fix error code in probe() Dan Carpenter
2023-05-19 14:12 ` Helge Deller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).