From: "Péter Ujfalusi" <peter.ujfalusi@gmail.com>
To: Kevin Hilman <khilman@baylibre.com>, dmaengine@vger.kernel.org
Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Nicolas Frayer <nfrayer@baylibre.com>
Subject: Re: [PATCH 3/3] dma/ti: convert PSIL to be buildable as module
Date: Mon, 26 Sep 2022 21:47:55 +0300 [thread overview]
Message-ID: <4c9f0284-f8d0-75e5-8bc9-944b040f9edb@gmail.com> (raw)
In-Reply-To: <20220926181848.2917639-4-khilman@baylibre.com>
Hi Kevin,
On 9/26/22 21:18, Kevin Hilman wrote:
> map symbols need EXPORT_SYMBOL and files need MODULE_LICENSE.
>
> Signed-off-by: Kevin Hilman <khilman@baylibre.com>
> ---
> drivers/dma/ti/Kconfig | 3 ++-
> drivers/dma/ti/k3-psil-am62.c | 4 ++++
> drivers/dma/ti/k3-psil-am64.c | 4 ++++
> drivers/dma/ti/k3-psil-am654.c | 4 ++++
> drivers/dma/ti/k3-psil-j7200.c | 4 ++++
> drivers/dma/ti/k3-psil-j721e.c | 4 ++++
> drivers/dma/ti/k3-psil-j721s2.c | 4 ++++
> drivers/dma/ti/k3-psil.c | 2 ++
> 8 files changed, 28 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/dma/ti/Kconfig b/drivers/dma/ti/Kconfig
> index f196be3b222f..2adc2cca10e9 100644
> --- a/drivers/dma/ti/Kconfig
> +++ b/drivers/dma/ti/Kconfig
> @@ -56,7 +56,8 @@ config TI_K3_UDMA_GLUE_LAYER
> If unsure, say N.
>
> config TI_K3_PSIL
> - bool
> + tristate
> + default TI_K3_UDMA
>
> config TI_DMA_CROSSBAR
> bool
> diff --git a/drivers/dma/ti/k3-psil-am62.c b/drivers/dma/ti/k3-psil-am62.c
> index 2b6fd6e37c61..7c4ca85f68b1 100644
> --- a/drivers/dma/ti/k3-psil-am62.c
> +++ b/drivers/dma/ti/k3-psil-am62.c
> @@ -4,6 +4,7 @@
> */
>
> #include <linux/kernel.h>
> +#include <linux/module.h>
>
> #include "k3-psil-priv.h"
>
> @@ -184,3 +185,6 @@ struct psil_ep_map am62_ep_map = {
> .dst = am62_dst_ep_map,
> .dst_count = ARRAY_SIZE(am62_dst_ep_map),
> };
> +EXPORT_SYMBOL_GPL(am62_ep_map);
Wouldn't it be better to build one module (k3-psil.ko) and link all the
platform libs into that?
They are unconditionally built in all cases anyways and makes the lsmod
under control.
And no need to export these maps at all is a plus.
> +
> +MODULE_LICENSE("GPL v2");
> diff --git a/drivers/dma/ti/k3-psil-am64.c b/drivers/dma/ti/k3-psil-am64.c
> index 9fdeaa11a4fc..c579374feef9 100644
> --- a/drivers/dma/ti/k3-psil-am64.c
> +++ b/drivers/dma/ti/k3-psil-am64.c
> @@ -5,6 +5,7 @@
> */
>
> #include <linux/kernel.h>
> +#include <linux/module.h>
>
> #include "k3-psil-priv.h"
>
> @@ -156,3 +157,6 @@ struct psil_ep_map am64_ep_map = {
> .dst = am64_dst_ep_map,
> .dst_count = ARRAY_SIZE(am64_dst_ep_map),
> };
> +EXPORT_SYMBOL_GPL(am64_ep_map);
> +
> +MODULE_LICENSE("GPL v2");
> diff --git a/drivers/dma/ti/k3-psil-am654.c b/drivers/dma/ti/k3-psil-am654.c
> index a896a15908cf..10db638b1178 100644
> --- a/drivers/dma/ti/k3-psil-am654.c
> +++ b/drivers/dma/ti/k3-psil-am654.c
> @@ -5,6 +5,7 @@
> */
>
> #include <linux/kernel.h>
> +#include <linux/module.h>
>
> #include "k3-psil-priv.h"
>
> @@ -173,3 +174,6 @@ struct psil_ep_map am654_ep_map = {
> .dst = am654_dst_ep_map,
> .dst_count = ARRAY_SIZE(am654_dst_ep_map),
> };
> +EXPORT_SYMBOL_GPL(am654_ep_map);
> +
> +MODULE_LICENSE("GPL v2");
> diff --git a/drivers/dma/ti/k3-psil-j7200.c b/drivers/dma/ti/k3-psil-j7200.c
> index 5ea63ea74822..b7c638a5d140 100644
> --- a/drivers/dma/ti/k3-psil-j7200.c
> +++ b/drivers/dma/ti/k3-psil-j7200.c
> @@ -5,6 +5,7 @@
> */
>
> #include <linux/kernel.h>
> +#include <linux/module.h>
>
> #include "k3-psil-priv.h"
>
> @@ -173,3 +174,6 @@ struct psil_ep_map j7200_ep_map = {
> .dst = j7200_dst_ep_map,
> .dst_count = ARRAY_SIZE(j7200_dst_ep_map),
> };
> +EXPORT_SYMBOL_GPL(j7200_ep_map);
> +
> +MODULE_LICENSE("GPL v2");
> diff --git a/drivers/dma/ti/k3-psil-j721e.c b/drivers/dma/ti/k3-psil-j721e.c
> index 34e3fc565a37..759e4a156acd 100644
> --- a/drivers/dma/ti/k3-psil-j721e.c
> +++ b/drivers/dma/ti/k3-psil-j721e.c
> @@ -5,6 +5,7 @@
> */
>
> #include <linux/kernel.h>
> +#include <linux/module.h>
>
> #include "k3-psil-priv.h"
>
> @@ -296,3 +297,6 @@ struct psil_ep_map j721e_ep_map = {
> .dst = j721e_dst_ep_map,
> .dst_count = ARRAY_SIZE(j721e_dst_ep_map),
> };
> +EXPORT_SYMBOL_GPL(j721e_ep_map);
> +
> +MODULE_LICENSE("GPL v2");
> diff --git a/drivers/dma/ti/k3-psil-j721s2.c b/drivers/dma/ti/k3-psil-j721s2.c
> index a488c2250623..fd9e56851e59 100644
> --- a/drivers/dma/ti/k3-psil-j721s2.c
> +++ b/drivers/dma/ti/k3-psil-j721s2.c
> @@ -4,6 +4,7 @@
> */
>
> #include <linux/kernel.h>
> +#include <linux/module.h>
>
> #include "k3-psil-priv.h"
>
> @@ -173,3 +174,6 @@ struct psil_ep_map j721s2_ep_map = {
> .dst = j721s2_dst_ep_map,
> .dst_count = ARRAY_SIZE(j721s2_dst_ep_map),
> };
> +EXPORT_SYMBOL_GPL(j721s2_ep_map);
> +
> +MODULE_LICENSE("GPL v2");
> diff --git a/drivers/dma/ti/k3-psil.c b/drivers/dma/ti/k3-psil.c
> index 761a384093d2..8b6533a1eeeb 100644
> --- a/drivers/dma/ti/k3-psil.c
> +++ b/drivers/dma/ti/k3-psil.c
> @@ -5,6 +5,7 @@
> */
>
> #include <linux/kernel.h>
> +#include <linux/module.h>
> #include <linux/device.h>
> #include <linux/init.h>
> #include <linux/mutex.h>
> @@ -101,3 +102,4 @@ int psil_set_new_ep_config(struct device *dev, const char *name,
> return 0;
> }
> EXPORT_SYMBOL_GPL(psil_set_new_ep_config);
> +MODULE_LICENSE("GPL v2");
--
Péter
next prev parent reply other threads:[~2022-09-26 18:41 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-26 18:18 [PATCH 0/3] dma/ti: enable udma and psil to be built as modules Kevin Hilman
2022-09-26 18:18 ` [PATCH 1/3] of/irq: export of_msi_get_domain Kevin Hilman
2022-09-26 18:18 ` [PATCH 2/3] dma/ti: convert k3-udma to module Kevin Hilman
2022-09-26 18:52 ` Péter Ujfalusi
2022-09-26 21:17 ` Kevin Hilman
2022-09-27 17:07 ` Péter Ujfalusi
2022-09-26 18:18 ` [PATCH 3/3] dma/ti: convert PSIL to be buildable as module Kevin Hilman
2022-09-26 18:47 ` Péter Ujfalusi [this message]
2022-09-26 18:50 ` Kevin Hilman
2022-09-27 17:19 ` Péter Ujfalusi
2022-09-27 22:56 ` Kevin Hilman
2022-09-26 19:02 ` [PATCH 0/3] dma/ti: enable udma and psil to be built as modules Péter Ujfalusi
2022-09-26 21:21 ` Kevin Hilman
2022-09-27 17:21 ` Péter Ujfalusi
2022-09-27 23:10 ` Kevin Hilman
2022-09-28 13:54 ` Péter Ujfalusi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4c9f0284-f8d0-75e5-8bc9-944b040f9edb@gmail.com \
--to=peter.ujfalusi@gmail.com \
--cc=dmaengine@vger.kernel.org \
--cc=khilman@baylibre.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=nfrayer@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).