* [PATCH] gpio: omap: Fix warnings if PM is disabled
@ 2020-08-19 9:24 Tony Lindgren
2020-08-19 11:23 ` Grygorii Strashko
2020-08-19 16:16 ` Bartosz Golaszewski
0 siblings, 2 replies; 3+ messages in thread
From: Tony Lindgren @ 2020-08-19 9:24 UTC (permalink / raw)
To: Linus Walleij, Bartosz Golaszewski, Grygorii Strashko
Cc: linux-gpio, linux-omap, linux-arm-kernel, Arnd Bergmann
Fix warnings for omap_gpio_resume and omap_gpio_suspend
defined but not used when PM is disabled as noticed when
doing make randconfig builds.
Fixes: f02a03985d06 ("gpio: omap: Add missing PM ops for suspend")
Cc: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Tony Lindgren <tony@atomide.com>
---
drivers/gpio/gpio-omap.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpio/gpio-omap.c b/drivers/gpio/gpio-omap.c
--- a/drivers/gpio/gpio-omap.c
+++ b/drivers/gpio/gpio-omap.c
@@ -1516,7 +1516,7 @@ static int __maybe_unused omap_gpio_runtime_resume(struct device *dev)
return 0;
}
-static int omap_gpio_suspend(struct device *dev)
+static int __maybe_unused omap_gpio_suspend(struct device *dev)
{
struct gpio_bank *bank = dev_get_drvdata(dev);
@@ -1528,7 +1528,7 @@ static int omap_gpio_suspend(struct device *dev)
return omap_gpio_runtime_suspend(dev);
}
-static int omap_gpio_resume(struct device *dev)
+static int __maybe_unused omap_gpio_resume(struct device *dev)
{
struct gpio_bank *bank = dev_get_drvdata(dev);
--
2.28.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] gpio: omap: Fix warnings if PM is disabled
2020-08-19 9:24 [PATCH] gpio: omap: Fix warnings if PM is disabled Tony Lindgren
@ 2020-08-19 11:23 ` Grygorii Strashko
2020-08-19 16:16 ` Bartosz Golaszewski
1 sibling, 0 replies; 3+ messages in thread
From: Grygorii Strashko @ 2020-08-19 11:23 UTC (permalink / raw)
To: Tony Lindgren, Linus Walleij, Bartosz Golaszewski
Cc: linux-gpio, linux-omap, linux-arm-kernel, Arnd Bergmann
On 19/08/2020 12:24, Tony Lindgren wrote:
> Fix warnings for omap_gpio_resume and omap_gpio_suspend
> defined but not used when PM is disabled as noticed when
> doing make randconfig builds.
>
> Fixes: f02a03985d06 ("gpio: omap: Add missing PM ops for suspend")
> Cc: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Tony Lindgren <tony@atomide.com>
> ---
> drivers/gpio/gpio-omap.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpio/gpio-omap.c b/drivers/gpio/gpio-omap.c
> --- a/drivers/gpio/gpio-omap.c
> +++ b/drivers/gpio/gpio-omap.c
> @@ -1516,7 +1516,7 @@ static int __maybe_unused omap_gpio_runtime_resume(struct device *dev)
> return 0;
> }
>
> -static int omap_gpio_suspend(struct device *dev)
> +static int __maybe_unused omap_gpio_suspend(struct device *dev)
> {
> struct gpio_bank *bank = dev_get_drvdata(dev);
>
> @@ -1528,7 +1528,7 @@ static int omap_gpio_suspend(struct device *dev)
> return omap_gpio_runtime_suspend(dev);
> }
>
> -static int omap_gpio_resume(struct device *dev)
> +static int __maybe_unused omap_gpio_resume(struct device *dev)
> {
> struct gpio_bank *bank = dev_get_drvdata(dev);
>
>
Thank you.
Acked-by: Grygorii Strashko <grygorii.strashko@ti.com>
--
Best regards,
grygorii
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] gpio: omap: Fix warnings if PM is disabled
2020-08-19 9:24 [PATCH] gpio: omap: Fix warnings if PM is disabled Tony Lindgren
2020-08-19 11:23 ` Grygorii Strashko
@ 2020-08-19 16:16 ` Bartosz Golaszewski
1 sibling, 0 replies; 3+ messages in thread
From: Bartosz Golaszewski @ 2020-08-19 16:16 UTC (permalink / raw)
To: Tony Lindgren
Cc: Linus Walleij, Grygorii Strashko, linux-gpio, Linux-OMAP,
arm-soc, Arnd Bergmann
On Wed, Aug 19, 2020 at 11:24 AM Tony Lindgren <tony@atomide.com> wrote:
>
> Fix warnings for omap_gpio_resume and omap_gpio_suspend
> defined but not used when PM is disabled as noticed when
> doing make randconfig builds.
>
> Fixes: f02a03985d06 ("gpio: omap: Add missing PM ops for suspend")
> Cc: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Tony Lindgren <tony@atomide.com>
> ---
> drivers/gpio/gpio-omap.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpio/gpio-omap.c b/drivers/gpio/gpio-omap.c
> --- a/drivers/gpio/gpio-omap.c
> +++ b/drivers/gpio/gpio-omap.c
> @@ -1516,7 +1516,7 @@ static int __maybe_unused omap_gpio_runtime_resume(struct device *dev)
> return 0;
> }
>
> -static int omap_gpio_suspend(struct device *dev)
> +static int __maybe_unused omap_gpio_suspend(struct device *dev)
> {
> struct gpio_bank *bank = dev_get_drvdata(dev);
>
> @@ -1528,7 +1528,7 @@ static int omap_gpio_suspend(struct device *dev)
> return omap_gpio_runtime_suspend(dev);
> }
>
> -static int omap_gpio_resume(struct device *dev)
> +static int __maybe_unused omap_gpio_resume(struct device *dev)
> {
> struct gpio_bank *bank = dev_get_drvdata(dev);
>
> --
> 2.28.0
Applied for fixes, thanks!
Bartosz
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-08-19 16:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-19 9:24 [PATCH] gpio: omap: Fix warnings if PM is disabled Tony Lindgren
2020-08-19 11:23 ` Grygorii Strashko
2020-08-19 16:16 ` Bartosz Golaszewski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).