[PATCH 00/05] OMAP3: SR: Fixes in Smartreflex driver

[PATCH 00/05] OMAP3: SR: Fixes in Smartreflex driver

[Nayak, Rajendra]

Hi,

This series fixes a set of defects/issues in Smartreflex driver. SR autocompensation is now
functional and is validated with these patches on a ES3.1 based SDP with the
N values in Efuse.
Patches apply and are validated on the latest pm branch (2.6.28).

regards,
Rajendra

PS: I am having issues getting mails posted on the list, hence in case you comment
on these patches, please copy my id as well.

Re: [PATCH 00/05] OMAP3: SR: Fixes in Smartreflex driver

[Kevin Hilman]

"Nayak, Rajendra" <rnayak@ti.com> writes:

> Hi,
>
> This series fixes a set of defects/issues in Smartreflex driver. SR autocompensation is now
> functional and is validated with these patches on a ES3.1 based SDP with the
> N values in Efuse.
> Patches apply and are validated on the latest pm branch (2.6.28).
>

Hi Rajendra,

Thanks for this series of SR fixes.  I send a couple very minor
comments to a couple of the patches.  Also, this series does not apply
cleanly to pm-2.6.28, I'm not sure why.  Applying manually with
'patch' allows them to apply with "fuzz" suggesting that they were not
generated against the current tree.

Also, while you are in there cleaing up, could you add one more patch
which converts the printk(KERN_* ...) into pr_debug, pr_err, pr_info,
etc.

Thanks,

Kevin

RE: [PATCH 00/05] OMAP3: SR: Fixes in Smartreflex driver

[Nayak, Rajendra]

> -----Original Message-----
> From: Kevin Hilman [mailto:khilman@deeprootsystems.com] 
> Sent: Wednesday, March 18, 2009 9:59 PM
> To: Nayak, Rajendra
> Cc: linux-omap@vger.kernel.org
> Subject: Re: [PATCH 00/05] OMAP3: SR: Fixes in Smartreflex driver
> 
> "Nayak, Rajendra" <rnayak@ti.com> writes:
> 
> > Hi,
> >
> > This series fixes a set of defects/issues in Smartreflex 
> driver. SR autocompensation is now
> > functional and is validated with these patches on a ES3.1 
> based SDP with the
> > N values in Efuse.
> > Patches apply and are validated on the latest pm branch (2.6.28).
> >
> 
> Hi Rajendra,
> 
> Thanks for this series of SR fixes.  I send a couple very minor
> comments to a couple of the patches.  Also, this series does not apply
> cleanly to pm-2.6.28, I'm not sure why.  Applying manually with
> 'patch' allows them to apply with "fuzz" suggesting that they were not
> generated against the current tree.

I usually pull from kernel.org. The latest commit on pm branch that's pulled
from it shows me this.. 

commit 4f422d583e2e233c19eb20754b8cfad6ed9e460a
Author: Nayak, Rajendra <rnayak@ti.com>
Date:   Fri Feb 13 11:30:57 2009 +0530

    OMAP3: PM: Update voltage levels for OPP1/2 on VDD1/2

..which does look quite old. But so does gitweb.
Is there some delta between kernel.org and your internal tree?

> 
> Also, while you are in there cleaing up, could you add one more patch
> which converts the printk(KERN_* ...) into pr_debug, pr_err, pr_info,
> etc.

Yes, I can add a patch to clean that up.

> 
> Thanks,
> 
> Kevin
> 
> 
>