* [PATCH v2] pinctrl: single: fix debug output when #pinctrl-cells = 2
@ 2020-09-13 23:03 Drew Fustini
2020-09-23 6:55 ` Tony Lindgren
2020-10-01 8:05 ` Linus Walleij
0 siblings, 2 replies; 3+ messages in thread
From: Drew Fustini @ 2020-09-13 23:03 UTC (permalink / raw)
To: linux-arm-kernel, Tony Lindgren, Rob Herring, linux-omap,
linux-kernel, linux-gpio, Linus Walleij, Haojian Zhuang,
devicetree, bcousson, Jason Kridner, Robert Nelson, Trent Piepho
Cc: Drew Fustini
The debug output in pcs_parse_one_pinctrl_entry() needs to be updated
to print the correct pinctrl register value when #pinctrl-cells is 2.
Fixes: a13395418888 ("pinctrl: single: parse #pinctrl-cells = 2")
Reported-by: Trent Piepho <tpiepho@gmail.com>
Link: https://lore.kernel.org/linux-omap/3139716.CMS8C0sQ7x@zen.local/
Signed-off-by: Drew Fustini <drew@beagleboard.org>
---
v2 change:
this is a fix to my prior email where I referred to #pinctrl-cells = 3
which is incorrect. pinctrl_spec.args_count is 3 but #pinctrl-cells = 2
https://lore.kernel.org/linux-omap/20200913224746.2048603-1-drew@beagleboard.org/
drivers/pinctrl/pinctrl-single.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/pinctrl-single.c b/drivers/pinctrl/pinctrl-single.c
index 5cbf0e55087c..f3cd7e296712 100644
--- a/drivers/pinctrl/pinctrl-single.c
+++ b/drivers/pinctrl/pinctrl-single.c
@@ -1033,7 +1033,7 @@ static int pcs_parse_one_pinctrl_entry(struct pcs_device *pcs,
}
dev_dbg(pcs->dev, "%pOFn index: 0x%x value: 0x%x\n",
- pinctrl_spec.np, offset, pinctrl_spec.args[1]);
+ pinctrl_spec.np, offset, vals[found].val);
pin = pcs_get_pin_by_offset(pcs, offset);
if (pin < 0) {
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH v2] pinctrl: single: fix debug output when #pinctrl-cells = 2
2020-09-13 23:03 [PATCH v2] pinctrl: single: fix debug output when #pinctrl-cells = 2 Drew Fustini
@ 2020-09-23 6:55 ` Tony Lindgren
2020-10-01 8:05 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Tony Lindgren @ 2020-09-23 6:55 UTC (permalink / raw)
To: Drew Fustini
Cc: linux-arm-kernel, Rob Herring, linux-omap, linux-kernel,
linux-gpio, Linus Walleij, Haojian Zhuang, devicetree, bcousson,
Jason Kridner, Robert Nelson, Trent Piepho
* Drew Fustini <drew@beagleboard.org> [200913 23:04]:
> The debug output in pcs_parse_one_pinctrl_entry() needs to be updated
> to print the correct pinctrl register value when #pinctrl-cells is 2.
>
> Fixes: a13395418888 ("pinctrl: single: parse #pinctrl-cells = 2")
> Reported-by: Trent Piepho <tpiepho@gmail.com>
> Link: https://lore.kernel.org/linux-omap/3139716.CMS8C0sQ7x@zen.local/
> Signed-off-by: Drew Fustini <drew@beagleboard.org>
> ---
> v2 change:
> this is a fix to my prior email where I referred to #pinctrl-cells = 3
> which is incorrect. pinctrl_spec.args_count is 3 but #pinctrl-cells = 2
> https://lore.kernel.org/linux-omap/20200913224746.2048603-1-drew@beagleboard.org/
Acked-by: Tony Lindgren <tony@atomide.com>
> drivers/pinctrl/pinctrl-single.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/pinctrl-single.c b/drivers/pinctrl/pinctrl-single.c
> index 5cbf0e55087c..f3cd7e296712 100644
> --- a/drivers/pinctrl/pinctrl-single.c
> +++ b/drivers/pinctrl/pinctrl-single.c
> @@ -1033,7 +1033,7 @@ static int pcs_parse_one_pinctrl_entry(struct pcs_device *pcs,
> }
>
> dev_dbg(pcs->dev, "%pOFn index: 0x%x value: 0x%x\n",
> - pinctrl_spec.np, offset, pinctrl_spec.args[1]);
> + pinctrl_spec.np, offset, vals[found].val);
>
> pin = pcs_get_pin_by_offset(pcs, offset);
> if (pin < 0) {
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v2] pinctrl: single: fix debug output when #pinctrl-cells = 2
2020-09-13 23:03 [PATCH v2] pinctrl: single: fix debug output when #pinctrl-cells = 2 Drew Fustini
2020-09-23 6:55 ` Tony Lindgren
@ 2020-10-01 8:05 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2020-10-01 8:05 UTC (permalink / raw)
To: Drew Fustini
Cc: Linux ARM, Tony Lindgren, Rob Herring, Linux-OMAP, linux-kernel,
open list:GPIO SUBSYSTEM, Haojian Zhuang,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Benoît Cousson, Jason Kridner, Robert Nelson, Trent Piepho
On Mon, Sep 14, 2020 at 1:04 AM Drew Fustini <drew@beagleboard.org> wrote:
> The debug output in pcs_parse_one_pinctrl_entry() needs to be updated
> to print the correct pinctrl register value when #pinctrl-cells is 2.
>
> Fixes: a13395418888 ("pinctrl: single: parse #pinctrl-cells = 2")
> Reported-by: Trent Piepho <tpiepho@gmail.com>
> Link: https://lore.kernel.org/linux-omap/3139716.CMS8C0sQ7x@zen.local/
> Signed-off-by: Drew Fustini <drew@beagleboard.org>
> ---
> v2 change:
> this is a fix to my prior email where I referred to #pinctrl-cells = 3
> which is incorrect. pinctrl_spec.args_count is 3 but #pinctrl-cells = 2
> https://lore.kernel.org/linux-omap/20200913224746.2048603-1-drew@beagleboard.org/
Patch applied!
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-10-01 8:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-13 23:03 [PATCH v2] pinctrl: single: fix debug output when #pinctrl-cells = 2 Drew Fustini
2020-09-23 6:55 ` Tony Lindgren
2020-10-01 8:05 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).