* [PATCH v2 0/2] ARM: dts: Add palmas dtsi
@ 2013-06-10 9:04 J Keerthy
2013-06-10 9:04 ` [PATCH v2 1/2] ARM: dts: add dtsi for palmas J Keerthy
2013-06-10 9:04 ` [PATCH v2 2/2] ARM: dts: OMAP5: add palmas node and omap specific palmas regulator properties J Keerthy
0 siblings, 2 replies; 9+ messages in thread
From: J Keerthy @ 2013-06-10 9:04 UTC (permalink / raw)
To: b-cousson, devicetree-discuss
Cc: linux-omap, linux-kernel, ldewangan, grant.likely, swarren,
swarren, sameo, gg, lee.jones, J Keerthy
This patch series adds palmas.dtsi and adds the omap5 specific palmas
entries in the omap5-uevm board file.
This patch series is based on:
git://git.kernel.org/pub/scm/linux/kernel/git/bcousson/linux-omap-dt.git
for_3.11/dts
Boot tested on omap5-uevm board.
J Keerthy (2):
ARM: dts: add dtsi for palmas
ARM: dts: OMAP5: add palmas node and omap specific palmas regulator
properties
arch/arm/boot/dts/omap5-uevm.dts | 147 ++++++++++++++++++++++++++++++++++++++
arch/arm/boot/dts/palmas.dtsi | 98 +++++++++++++++++++++++++
2 files changed, 245 insertions(+), 0 deletions(-)
create mode 100644 arch/arm/boot/dts/palmas.dtsi
--
1.7.5.4
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v2 1/2] ARM: dts: add dtsi for palmas
2013-06-10 9:04 [PATCH v2 0/2] ARM: dts: Add palmas dtsi J Keerthy
@ 2013-06-10 9:04 ` J Keerthy
[not found] ` <1370855059-5342-2-git-send-email-j-keerthy-l0cyMroinI0@public.gmane.org>
2013-06-10 9:04 ` [PATCH v2 2/2] ARM: dts: OMAP5: add palmas node and omap specific palmas regulator properties J Keerthy
1 sibling, 1 reply; 9+ messages in thread
From: J Keerthy @ 2013-06-10 9:04 UTC (permalink / raw)
To: b-cousson, devicetree-discuss
Cc: linux-omap, linux-kernel, ldewangan, grant.likely, swarren,
swarren, sameo, gg, lee.jones, J Keerthy
Adds palmas mfd and palmas regulator nodes.
Signed-off-by: Graeme Gregory <gg@slimlogic.co.uk>
Signed-off-by: J Keerthy <j-keerthy@ti.com>
---
arch/arm/boot/dts/palmas.dtsi | 98 +++++++++++++++++++++++++++++++++++++++++
1 files changed, 98 insertions(+), 0 deletions(-)
create mode 100644 arch/arm/boot/dts/palmas.dtsi
diff --git a/arch/arm/boot/dts/palmas.dtsi b/arch/arm/boot/dts/palmas.dtsi
new file mode 100644
index 0000000..4c5162f
--- /dev/null
+++ b/arch/arm/boot/dts/palmas.dtsi
@@ -0,0 +1,98 @@
+/*
+ * Copyright (C) 2013 Texas Instruments Incorporated - http://www.ti.com/
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ */
+
+#include <dt-bindings/interrupt-controller/irq.h>
+
+&palmas {
+ compatible = "ti,palmas";
+ interrupt-controller;
+ #interrupt-cells = <2>;
+
+ palmas_pmic {
+ compatible = "ti,palmas-pmic";
+ interrupt-parent = <&palmas>;
+ interrupts = <14 IRQ_TYPE_NONE>;
+ interrupt-name = "short-irq";
+
+ ti,ldo6-vibrator;
+
+ regulators {
+ smps123_reg: smps123 {
+ regulator-name = "smps123";
+ };
+
+ smps45_reg: smps45 {
+ regulator-name = "smps45";
+ };
+
+ smps6_reg: smps6 {
+ regulator-name = "smps6";
+ };
+
+ smps7_reg: smps7 {
+ regulator-name = "smps7";
+ };
+
+ smps8_reg: smps8 {
+ regulator-name = "smps8";
+ };
+
+ smps9_reg: smps9 {
+ regulator-name = "smps9";
+ };
+
+ smps10_reg: smps10 {
+ regulator-name = "smps10";
+ };
+
+ ldo1_reg: ldo1 {
+ regulator-name = "ldo1";
+ };
+
+ ldo2_reg: ldo2 {
+ regulator-name = "ldo2";
+ };
+
+ ldo3_reg: ldo3 {
+ regulator-name = "ldo3";
+ };
+
+ ldo4_reg: ldo4 {
+ regulator-name = "ldo4";
+ };
+
+ ldo5_reg: ldo5 {
+ regulator-name = "ldo5";
+ };
+
+ ldo6_reg: ldo6 {
+ regulator-name = "ldo6";
+ };
+
+ ldo7_reg: ldo7 {
+ regulator-name = "ldo7";
+ };
+
+ ldo8_reg: ldo8 {
+ regulator-name = "ldo8";
+ };
+
+ ldo9_reg: ldo9 {
+ regulator-name = "ldo9";
+ };
+
+ ldoln_reg: ldoln {
+ regulator-name = "ldoln";
+ };
+
+ ldousb_reg: ldousb {
+ regulator-name = "ldousb";
+ };
+ };
+ };
+};
--
1.7.5.4
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH v2 2/2] ARM: dts: OMAP5: add palmas node and omap specific palmas regulator properties
2013-06-10 9:04 [PATCH v2 0/2] ARM: dts: Add palmas dtsi J Keerthy
2013-06-10 9:04 ` [PATCH v2 1/2] ARM: dts: add dtsi for palmas J Keerthy
@ 2013-06-10 9:04 ` J Keerthy
2013-06-10 10:05 ` Lee Jones
1 sibling, 1 reply; 9+ messages in thread
From: J Keerthy @ 2013-06-10 9:04 UTC (permalink / raw)
To: b-cousson, devicetree-discuss
Cc: linux-omap, linux-kernel, ldewangan, grant.likely, swarren,
swarren, sameo, gg, lee.jones, J Keerthy
Add palmas node and omap specific palmas regulator properties.
Signed-off-by: J Keerthy <j-keerthy@ti.com>
---
arch/arm/boot/dts/omap5-uevm.dts | 147 ++++++++++++++++++++++++++++++++++++++
1 files changed, 147 insertions(+), 0 deletions(-)
diff --git a/arch/arm/boot/dts/omap5-uevm.dts b/arch/arm/boot/dts/omap5-uevm.dts
index 927db1e..ffbcc3f 100644
--- a/arch/arm/boot/dts/omap5-uevm.dts
+++ b/arch/arm/boot/dts/omap5-uevm.dts
@@ -8,6 +8,8 @@
/dts-v1/;
#include "omap5.dtsi"
+#include <dt-bindings/interrupt-controller/irq.h>
+#include <dt-bindings/interrupt-controller/arm-gic.h>
/ {
model = "TI OMAP5 uEVM board";
@@ -254,6 +256,151 @@
pinctrl-0 = <&i2c1_pins>;
clock-frequency = <400000>;
+
+ palmas: palmas@48 {
+ reg = <0x48>;
+ /* SPI = 0, IRQ# = 7, active high level-sensitive */
+ interrupts = <GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH>; /* IRQ_SYS_1N */
+ interrupt-parent = <&gic>;
+ };
+
+};
+
+#include "palmas.dtsi"
+
+&palmas {
+ palmas_pmic {
+ ti,ldo6-vibrator;
+
+ regulators {
+ smps123_reg: smps123 {
+ regulator-min-microvolt = < 600000>;
+ regulator-max-microvolt = <1500000>;
+ regulator-always-on;
+ regulator-boot-on;
+ };
+
+ smps45_reg: smps45 {
+ regulator-min-microvolt = < 600000>;
+ regulator-max-microvolt = <1310000>;
+ regulator-always-on;
+ regulator-boot-on;
+ };
+
+ smps6_reg: smps6 {
+ regulator-min-microvolt = <1200000>;
+ regulator-max-microvolt = <1200000>;
+ regulator-always-on;
+ regulator-boot-on;
+ };
+
+ smps7_reg: smps7 {
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ regulator-always-on;
+ regulator-boot-on;
+ };
+
+ smps8_reg: smps8 {
+ regulator-min-microvolt = < 600000>;
+ regulator-max-microvolt = <1310000>;
+ regulator-always-on;
+ regulator-boot-on;
+ };
+
+ smps9_reg: smps9 {
+ regulator-min-microvolt = <2100000>;
+ regulator-max-microvolt = <2100000>;
+ regulator-always-on;
+ regulator-boot-on;
+ ti,smps-range = <0x80>;
+ };
+
+ smps10_reg: smps10 {
+ regulator-min-microvolt = <5000000>;
+ regulator-max-microvolt = <5000000>;
+ regulator-always-on;
+ regulator-boot-on;
+ };
+
+ ldo1_reg: ldo1 {
+ regulator-min-microvolt = <2800000>;
+ regulator-max-microvolt = <2800000>;
+ regulator-always-on;
+ regulator-boot-on;
+ };
+
+ ldo2_reg: ldo2 {
+ regulator-min-microvolt = <2900000>;
+ regulator-max-microvolt = <2900000>;
+ regulator-always-on;
+ regulator-boot-on;
+ };
+
+ ldo3_reg: ldo3 {
+ regulator-min-microvolt = <3000000>;
+ regulator-max-microvolt = <3000000>;
+ regulator-always-on;
+ regulator-boot-on;
+ };
+
+ ldo4_reg: ldo4 {
+ regulator-min-microvolt = <2200000>;
+ regulator-max-microvolt = <2200000>;
+ regulator-always-on;
+ regulator-boot-on;
+ };
+
+ ldo5_reg: ldo5 {
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ regulator-always-on;
+ regulator-boot-on;
+ };
+
+ ldo6_reg: ldo6 {
+ regulator-min-microvolt = <1500000>;
+ regulator-max-microvolt = <1500000>;
+ regulator-always-on;
+ regulator-boot-on;
+ };
+
+ ldo7_reg: ldo7 {
+ regulator-min-microvolt = <1500000>;
+ regulator-max-microvolt = <1500000>;
+ regulator-always-on;
+ regulator-boot-on;
+ };
+
+ ldo8_reg: ldo8 {
+ regulator-min-microvolt = <1500000>;
+ regulator-max-microvolt = <1500000>;
+ regulator-always-on;
+ regulator-boot-on;
+ };
+
+ ldo9_reg: ldo9 {
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <3300000>;
+ regulator-always-on;
+ regulator-boot-on;
+ };
+
+ ldoln_reg: ldoln {
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ regulator-always-on;
+ regulator-boot-on;
+ };
+
+ ldousb_reg: ldousb {
+ regulator-min-microvolt = <3250000>;
+ regulator-max-microvolt = <3250000>;
+ regulator-always-on;
+ regulator-boot-on;
+ };
+ };
+ };
};
&i2c5 {
--
1.7.5.4
^ permalink raw reply related [flat|nested] 9+ messages in thread
* RE: [PATCH v2 1/2] ARM: dts: add dtsi for palmas
2013-06-10 9:25 ` Laxman Dewangan
@ 2013-06-10 9:24 ` J, KEERTHY
0 siblings, 0 replies; 9+ messages in thread
From: J, KEERTHY @ 2013-06-10 9:24 UTC (permalink / raw)
To: Laxman Dewangan
Cc: Cousson, Benoit, devicetree-discuss, linux-omap, linux-kernel,
grant.likely, swarren, Stephen Warren, sameo, gg, lee.jones
Hi Laxman,
> -----Original Message-----
> From: Laxman Dewangan [mailto:ldewangan@nvidia.com]
> Sent: Monday, June 10, 2013 2:55 PM
> To: J, KEERTHY
> Cc: Cousson, Benoit; devicetree-discuss@lists.ozlabs.org; linux-
> omap@vger.kernel.org; linux-kernel@vger.kernel.org;
> grant.likely@secretlab.ca; swarren@wwwdotorg.org; Stephen Warren;
> sameo@linux.intel.com; gg@slimlogic.co.uk; lee.jones@linaro.org
> Subject: Re: [PATCH v2 1/2] ARM: dts: add dtsi for palmas
>
> On Monday 10 June 2013 02:34 PM, J Keerthy wrote:
> > Adds palmas mfd and palmas regulator nodes.
> >
> > Signed-off-by: Graeme Gregory <gg@slimlogic.co.uk>
> > Signed-off-by: J Keerthy <j-keerthy@ti.com>
> > ---
> > arch/arm/boot/dts/palmas.dtsi | 98
> +++++++++++++++++++++++++++++++++++++++++
>
> Hi Keerthy,
> Can you please add documentation for dt binding:
> Documentation/devicetree/bindings/mfd
>
https://lkml.org/lkml/2013/6/6/25
It is based on this.
> Most of time we refer from this document for dt population.
>
> Thanks,
> Laxman
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2 1/2] ARM: dts: add dtsi for palmas
[not found] ` <1370855059-5342-2-git-send-email-j-keerthy-l0cyMroinI0@public.gmane.org>
@ 2013-06-10 9:25 ` Laxman Dewangan
2013-06-10 9:24 ` J, KEERTHY
2013-06-10 16:29 ` Stephen Warren
1 sibling, 1 reply; 9+ messages in thread
From: Laxman Dewangan @ 2013-06-10 9:25 UTC (permalink / raw)
To: J Keerthy
Cc: Stephen Warren, devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ,
linux-kernel-u79uwXL29TY76Z2rM5mHXA, gg-kDsPt+C1G03kYMGBc/C6ZA,
linux-omap-u79uwXL29TY76Z2rM5mHXA,
lee.jones-QSEj5FYQhm4dnm+yROfE0A, sameo-VuQAYsv1563Yd54FQh9/CA
On Monday 10 June 2013 02:34 PM, J Keerthy wrote:
> Adds palmas mfd and palmas regulator nodes.
>
> Signed-off-by: Graeme Gregory <gg-kDsPt+C1G03kYMGBc/C6ZA@public.gmane.org>
> Signed-off-by: J Keerthy <j-keerthy-l0cyMroinI0@public.gmane.org>
> ---
> arch/arm/boot/dts/palmas.dtsi | 98 +++++++++++++++++++++++++++++++++++++++++
Hi Keerthy,
Can you please add documentation for dt binding:
Documentation/devicetree/bindings/mfd
Most of time we refer from this document for dt population.
Thanks,
Laxman
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2 2/2] ARM: dts: OMAP5: add palmas node and omap specific palmas regulator properties
2013-06-10 9:04 ` [PATCH v2 2/2] ARM: dts: OMAP5: add palmas node and omap specific palmas regulator properties J Keerthy
@ 2013-06-10 10:05 ` Lee Jones
2013-06-10 10:16 ` J, KEERTHY
0 siblings, 1 reply; 9+ messages in thread
From: Lee Jones @ 2013-06-10 10:05 UTC (permalink / raw)
To: J Keerthy
Cc: b-cousson, devicetree-discuss, linux-omap, linux-kernel,
ldewangan, grant.likely, swarren, swarren, sameo, gg
On Mon, 10 Jun 2013, J Keerthy wrote:
> Add palmas node and omap specific palmas regulator properties.
>
> Signed-off-by: J Keerthy <j-keerthy@ti.com>
> ---
> arch/arm/boot/dts/omap5-uevm.dts | 147 ++++++++++++++++++++++++++++++++++++++
> 1 files changed, 147 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/boot/dts/omap5-uevm.dts b/arch/arm/boot/dts/omap5-uevm.dts
> index 927db1e..ffbcc3f 100644
> --- a/arch/arm/boot/dts/omap5-uevm.dts
> +++ b/arch/arm/boot/dts/omap5-uevm.dts
> @@ -8,6 +8,8 @@
> /dts-v1/;
>
> #include "omap5.dtsi"
> +#include <dt-bindings/interrupt-controller/irq.h>
> +#include <dt-bindings/interrupt-controller/arm-gic.h>
>
> / {
> model = "TI OMAP5 uEVM board";
> @@ -254,6 +256,151 @@
> pinctrl-0 = <&i2c1_pins>;
>
> clock-frequency = <400000>;
> +
> + palmas: palmas@48 {
> + reg = <0x48>;
> + /* SPI = 0, IRQ# = 7, active high level-sensitive */
I still think this is superfluous, especially now you're using the
defines which basically say the same thing.
> + interrupts = <GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH>; /* IRQ_SYS_1N */
> + interrupt-parent = <&gic>;
> + };
> +
> +};
> +
> +#include "palmas.dtsi"
> +
> +&palmas {
> + palmas_pmic {
> + ti,ldo6-vibrator;
> +
> + regulators {
> + smps123_reg: smps123 {
> + regulator-min-microvolt = < 600000>;
> + regulator-max-microvolt = <1500000>;
> + regulator-always-on;
> + regulator-boot-on;
> + };
> +
> + smps45_reg: smps45 {
> + regulator-min-microvolt = < 600000>;
> + regulator-max-microvolt = <1310000>;
> + regulator-always-on;
> + regulator-boot-on;
> + };
> +
> + smps6_reg: smps6 {
> + regulator-min-microvolt = <1200000>;
> + regulator-max-microvolt = <1200000>;
> + regulator-always-on;
> + regulator-boot-on;
> + };
> +
> + smps7_reg: smps7 {
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <1800000>;
> + regulator-always-on;
> + regulator-boot-on;
> + };
> +
> + smps8_reg: smps8 {
> + regulator-min-microvolt = < 600000>;
> + regulator-max-microvolt = <1310000>;
> + regulator-always-on;
> + regulator-boot-on;
> + };
> +
> + smps9_reg: smps9 {
> + regulator-min-microvolt = <2100000>;
> + regulator-max-microvolt = <2100000>;
> + regulator-always-on;
> + regulator-boot-on;
> + ti,smps-range = <0x80>;
> + };
> +
> + smps10_reg: smps10 {
> + regulator-min-microvolt = <5000000>;
> + regulator-max-microvolt = <5000000>;
> + regulator-always-on;
> + regulator-boot-on;
> + };
> +
> + ldo1_reg: ldo1 {
> + regulator-min-microvolt = <2800000>;
> + regulator-max-microvolt = <2800000>;
> + regulator-always-on;
> + regulator-boot-on;
> + };
> +
> + ldo2_reg: ldo2 {
> + regulator-min-microvolt = <2900000>;
> + regulator-max-microvolt = <2900000>;
> + regulator-always-on;
> + regulator-boot-on;
> + };
> +
> + ldo3_reg: ldo3 {
> + regulator-min-microvolt = <3000000>;
> + regulator-max-microvolt = <3000000>;
> + regulator-always-on;
> + regulator-boot-on;
> + };
> +
> + ldo4_reg: ldo4 {
> + regulator-min-microvolt = <2200000>;
> + regulator-max-microvolt = <2200000>;
> + regulator-always-on;
> + regulator-boot-on;
> + };
> +
> + ldo5_reg: ldo5 {
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <1800000>;
> + regulator-always-on;
> + regulator-boot-on;
> + };
> +
> + ldo6_reg: ldo6 {
> + regulator-min-microvolt = <1500000>;
> + regulator-max-microvolt = <1500000>;
> + regulator-always-on;
> + regulator-boot-on;
> + };
> +
> + ldo7_reg: ldo7 {
> + regulator-min-microvolt = <1500000>;
> + regulator-max-microvolt = <1500000>;
> + regulator-always-on;
> + regulator-boot-on;
> + };
> +
> + ldo8_reg: ldo8 {
> + regulator-min-microvolt = <1500000>;
> + regulator-max-microvolt = <1500000>;
> + regulator-always-on;
> + regulator-boot-on;
> + };
> +
> + ldo9_reg: ldo9 {
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <3300000>;
> + regulator-always-on;
> + regulator-boot-on;
> + };
> +
> + ldoln_reg: ldoln {
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <1800000>;
> + regulator-always-on;
> + regulator-boot-on;
> + };
> +
> + ldousb_reg: ldousb {
> + regulator-min-microvolt = <3250000>;
> + regulator-max-microvolt = <3250000>;
> + regulator-always-on;
> + regulator-boot-on;
> + };
> + };
> + };
> };
>
> &i2c5 {
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 9+ messages in thread
* RE: [PATCH v2 2/2] ARM: dts: OMAP5: add palmas node and omap specific palmas regulator properties
2013-06-10 10:05 ` Lee Jones
@ 2013-06-10 10:16 ` J, KEERTHY
0 siblings, 0 replies; 9+ messages in thread
From: J, KEERTHY @ 2013-06-10 10:16 UTC (permalink / raw)
To: Lee Jones
Cc: Cousson, Benoit, devicetree-discuss, linux-omap, linux-kernel,
ldewangan, grant.likely, swarren, swarren, sameo, gg
Hello Lee jones,
> -----Original Message-----
> From: Lee Jones [mailto:lee.jones@linaro.org]
> Sent: Monday, June 10, 2013 3:36 PM
> To: J, KEERTHY
> Cc: Cousson, Benoit; devicetree-discuss@lists.ozlabs.org; linux-
> omap@vger.kernel.org; linux-kernel@vger.kernel.org;
> ldewangan@nvidia.com; grant.likely@secretlab.ca; swarren@wwwdotorg.org;
> swarren@nvidia.com; sameo@linux.intel.com; gg@slimlogic.co.uk
> Subject: Re: [PATCH v2 2/2] ARM: dts: OMAP5: add palmas node and omap
> specific palmas regulator properties
>
> On Mon, 10 Jun 2013, J Keerthy wrote:
>
> > Add palmas node and omap specific palmas regulator properties.
> >
> > Signed-off-by: J Keerthy <j-keerthy@ti.com>
> > ---
> > arch/arm/boot/dts/omap5-uevm.dts | 147
> > ++++++++++++++++++++++++++++++++++++++
> > 1 files changed, 147 insertions(+), 0 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/omap5-uevm.dts
> > b/arch/arm/boot/dts/omap5-uevm.dts
> > index 927db1e..ffbcc3f 100644
> > --- a/arch/arm/boot/dts/omap5-uevm.dts
> > +++ b/arch/arm/boot/dts/omap5-uevm.dts
> > @@ -8,6 +8,8 @@
> > /dts-v1/;
> >
> > #include "omap5.dtsi"
> > +#include <dt-bindings/interrupt-controller/irq.h>
> > +#include <dt-bindings/interrupt-controller/arm-gic.h>
> >
> > / {
> > model = "TI OMAP5 uEVM board";
> > @@ -254,6 +256,151 @@
> > pinctrl-0 = <&i2c1_pins>;
> >
> > clock-frequency = <400000>;
> > +
> > + palmas: palmas@48 {
> > + reg = <0x48>;
> > + /* SPI = 0, IRQ# = 7, active high level-sensitive */
>
> I still think this is superfluous, especially now you're using the
> defines which basically say the same thing.
I retained the whole comment as it was needed to specify IRQ# as 7
And thought it completely described the below interrupt property.
I can knock it off if it is totally unnecessary.
If there are no further comments. Can I add a Reviewed-by?
>
> > + interrupts = <GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH>; /* IRQ_SYS_1N
> */
> > + interrupt-parent = <&gic>;
> > + };
> > +
> > +};
> > +
> > +#include "palmas.dtsi"
> > +
> > +&palmas {
> > + palmas_pmic {
> > + ti,ldo6-vibrator;
> > +
> > + regulators {
> > + smps123_reg: smps123 {
> > + regulator-min-microvolt = < 600000>;
> > + regulator-max-microvolt = <1500000>;
> > + regulator-always-on;
> > + regulator-boot-on;
> > + };
> > +
> > + smps45_reg: smps45 {
> > + regulator-min-microvolt = < 600000>;
> > + regulator-max-microvolt = <1310000>;
> > + regulator-always-on;
> > + regulator-boot-on;
> > + };
> > +
> > + smps6_reg: smps6 {
> > + regulator-min-microvolt = <1200000>;
> > + regulator-max-microvolt = <1200000>;
> > + regulator-always-on;
> > + regulator-boot-on;
> > + };
> > +
> > + smps7_reg: smps7 {
> > + regulator-min-microvolt = <1800000>;
> > + regulator-max-microvolt = <1800000>;
> > + regulator-always-on;
> > + regulator-boot-on;
> > + };
> > +
> > + smps8_reg: smps8 {
> > + regulator-min-microvolt = < 600000>;
> > + regulator-max-microvolt = <1310000>;
> > + regulator-always-on;
> > + regulator-boot-on;
> > + };
> > +
> > + smps9_reg: smps9 {
> > + regulator-min-microvolt = <2100000>;
> > + regulator-max-microvolt = <2100000>;
> > + regulator-always-on;
> > + regulator-boot-on;
> > + ti,smps-range = <0x80>;
> > + };
> > +
> > + smps10_reg: smps10 {
> > + regulator-min-microvolt = <5000000>;
> > + regulator-max-microvolt = <5000000>;
> > + regulator-always-on;
> > + regulator-boot-on;
> > + };
> > +
> > + ldo1_reg: ldo1 {
> > + regulator-min-microvolt = <2800000>;
> > + regulator-max-microvolt = <2800000>;
> > + regulator-always-on;
> > + regulator-boot-on;
> > + };
> > +
> > + ldo2_reg: ldo2 {
> > + regulator-min-microvolt = <2900000>;
> > + regulator-max-microvolt = <2900000>;
> > + regulator-always-on;
> > + regulator-boot-on;
> > + };
> > +
> > + ldo3_reg: ldo3 {
> > + regulator-min-microvolt = <3000000>;
> > + regulator-max-microvolt = <3000000>;
> > + regulator-always-on;
> > + regulator-boot-on;
> > + };
> > +
> > + ldo4_reg: ldo4 {
> > + regulator-min-microvolt = <2200000>;
> > + regulator-max-microvolt = <2200000>;
> > + regulator-always-on;
> > + regulator-boot-on;
> > + };
> > +
> > + ldo5_reg: ldo5 {
> > + regulator-min-microvolt = <1800000>;
> > + regulator-max-microvolt = <1800000>;
> > + regulator-always-on;
> > + regulator-boot-on;
> > + };
> > +
> > + ldo6_reg: ldo6 {
> > + regulator-min-microvolt = <1500000>;
> > + regulator-max-microvolt = <1500000>;
> > + regulator-always-on;
> > + regulator-boot-on;
> > + };
> > +
> > + ldo7_reg: ldo7 {
> > + regulator-min-microvolt = <1500000>;
> > + regulator-max-microvolt = <1500000>;
> > + regulator-always-on;
> > + regulator-boot-on;
> > + };
> > +
> > + ldo8_reg: ldo8 {
> > + regulator-min-microvolt = <1500000>;
> > + regulator-max-microvolt = <1500000>;
> > + regulator-always-on;
> > + regulator-boot-on;
> > + };
> > +
> > + ldo9_reg: ldo9 {
> > + regulator-min-microvolt = <1800000>;
> > + regulator-max-microvolt = <3300000>;
> > + regulator-always-on;
> > + regulator-boot-on;
> > + };
> > +
> > + ldoln_reg: ldoln {
> > + regulator-min-microvolt = <1800000>;
> > + regulator-max-microvolt = <1800000>;
> > + regulator-always-on;
> > + regulator-boot-on;
> > + };
> > +
> > + ldousb_reg: ldousb {
> > + regulator-min-microvolt = <3250000>;
> > + regulator-max-microvolt = <3250000>;
> > + regulator-always-on;
> > + regulator-boot-on;
> > + };
> > + };
> > + };
> > };
> >
> > &i2c5 {
>
> --
> Lee Jones
> Linaro ST-Ericsson Landing Team Lead
> Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook
> | Twitter | Blog
Regards,
Keerthy
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2 1/2] ARM: dts: add dtsi for palmas
[not found] ` <1370855059-5342-2-git-send-email-j-keerthy-l0cyMroinI0@public.gmane.org>
2013-06-10 9:25 ` Laxman Dewangan
@ 2013-06-10 16:29 ` Stephen Warren
2013-06-11 4:10 ` J, KEERTHY
1 sibling, 1 reply; 9+ messages in thread
From: Stephen Warren @ 2013-06-10 16:29 UTC (permalink / raw)
To: J Keerthy
Cc: swarren-DDmLM1+adcrQT0dZR+AlfA,
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
ldewangan-DDmLM1+adcrQT0dZR+AlfA, gg-kDsPt+C1G03kYMGBc/C6ZA,
linux-omap-u79uwXL29TY76Z2rM5mHXA,
lee.jones-QSEj5FYQhm4dnm+yROfE0A, sameo-VuQAYsv1563Yd54FQh9/CA
On 06/10/2013 03:04 AM, J Keerthy wrote:
> Adds palmas mfd and palmas regulator nodes.
Nits:
Well, you're really adding files that provide the nodes, not the nodes
themselves.
Palmas and MFD should be correctly capitalized.
> diff --git a/arch/arm/boot/dts/palmas.dtsi b/arch/arm/boot/dts/palmas.dtsi
> +&palmas {
...
> + palmas_pmic {
...
> + ti,ldo6-vibrator;
Isn't that board-specific? I don't know the HW well enough to say, but I
assume that since there's a property, the whole point must be that some
boards want it set and some don't.
> + regulators {
> + smps123_reg: smps123 {
> + regulator-name = "smps123";
> + };
So the node labels here duplicate those in omap5-uevm.dts in patch 2/2.
While dtc allows this, I don't think there's much point duplicating the
labels. I'd tend to only put the labels in omap5-uevm.dts and not put
them here. That will completely avoid the possibility of the labels in
this file from conflicting with any other labels in any top-level
board.dts file.
I also wonder if this file is actually terribly useful. The only thing
that this file provides is the regulator-name property. It seems simpler
just to put that into each board.dts file. The added advantage of doing
that, is that if a board doesn't use a particular regulator, the node
won't appear, and the regulator won't get registered.
^ permalink raw reply [flat|nested] 9+ messages in thread
* RE: [PATCH v2 1/2] ARM: dts: add dtsi for palmas
2013-06-10 16:29 ` Stephen Warren
@ 2013-06-11 4:10 ` J, KEERTHY
0 siblings, 0 replies; 9+ messages in thread
From: J, KEERTHY @ 2013-06-11 4:10 UTC (permalink / raw)
To: Stephen Warren
Cc: Cousson, Benoit, devicetree-discuss, linux-omap, linux-kernel,
ldewangan, grant.likely, swarren, sameo, gg, lee.jones
Hi Stephen,
> -----Original Message-----
> From: Stephen Warren [mailto:swarren@wwwdotorg.org]
> Sent: Monday, June 10, 2013 9:59 PM
> To: J, KEERTHY
> Cc: Cousson, Benoit; devicetree-discuss@lists.ozlabs.org; linux-
> omap@vger.kernel.org; linux-kernel@vger.kernel.org;
> ldewangan@nvidia.com; grant.likely@secretlab.ca; swarren@nvidia.com;
> sameo@linux.intel.com; gg@slimlogic.co.uk; lee.jones@linaro.org
> Subject: Re: [PATCH v2 1/2] ARM: dts: add dtsi for palmas
>
> On 06/10/2013 03:04 AM, J Keerthy wrote:
> > Adds palmas mfd and palmas regulator nodes.
>
> Nits:
>
> Well, you're really adding files that provide the nodes, not the nodes
> themselves.
>
> Palmas and MFD should be correctly capitalized.
Ok.
>
> > diff --git a/arch/arm/boot/dts/palmas.dtsi
> > b/arch/arm/boot/dts/palmas.dtsi
>
> > +&palmas {
> ...
> > + palmas_pmic {
> ...
> > + ti,ldo6-vibrator;
>
> Isn't that board-specific? I don't know the HW well enough to say, but
> I assume that since there's a property, the whole point must be that
> some boards want it set and some don't.
>
Yes. I will make this part of board file.
> > + regulators {
> > + smps123_reg: smps123 {
> > + regulator-name = "smps123";
> > + };
>
> So the node labels here duplicate those in omap5-uevm.dts in patch 2/2.
> While dtc allows this, I don't think there's much point duplicating the
> labels. I'd tend to only put the labels in omap5-uevm.dts and not put
> them here. That will completely avoid the possibility of the labels in
> this file from conflicting with any other labels in any top-level
> board.dts file.
>
> I also wonder if this file is actually terribly useful. The only thing
> that this file provides is the regulator-name property. It seems
> simpler just to put that into each board.dts file. The added advantage
> of doing that, is that if a board doesn't use a particular regulator,
> the node won't appear, and the regulator won't get registered.
Ok. I will transfer the entire code to omap5-uevm.dts.
Thanks for the review comments.
Regards,
Keerthy
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2013-06-11 4:11 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-06-10 9:04 [PATCH v2 0/2] ARM: dts: Add palmas dtsi J Keerthy
2013-06-10 9:04 ` [PATCH v2 1/2] ARM: dts: add dtsi for palmas J Keerthy
[not found] ` <1370855059-5342-2-git-send-email-j-keerthy-l0cyMroinI0@public.gmane.org>
2013-06-10 9:25 ` Laxman Dewangan
2013-06-10 9:24 ` J, KEERTHY
2013-06-10 16:29 ` Stephen Warren
2013-06-11 4:10 ` J, KEERTHY
2013-06-10 9:04 ` [PATCH v2 2/2] ARM: dts: OMAP5: add palmas node and omap specific palmas regulator properties J Keerthy
2013-06-10 10:05 ` Lee Jones
2013-06-10 10:16 ` J, KEERTHY
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).