* [PATCH 22/23] video: omapfb: dss: Make use of the helper component_compare_dev
[not found] <20220214060819.7334-1-yong.wu@mediatek.com>
@ 2022-02-14 6:08 ` Yong Wu
2022-02-15 20:46 ` Helge Deller
0 siblings, 1 reply; 3+ messages in thread
From: Yong Wu @ 2022-02-14 6:08 UTC (permalink / raw)
To: Greg Kroah-Hartman, David Airlie, Daniel Vetter, dri-devel
Cc: James Wang, Liviu Dudau, iommu, Matthias Brugger,
Krzysztof Kozlowski, linux-kernel, Joerg Roedel, Will Deacon,
Arnd Bergmann, Laurent Pinchart, linux-mediatek, Chun-Kuang Hu,
linux-arm-kernel, Stephen Boyd, AngeloGioacchino Del Regno,
Hsin-Yi Wang, Robin Murphy, Tomasz Figa, srv_heupstream,
Rob Clark, Srinivas Kandagatla, Sebastian Reichel, Yong Wu,
Helge Deller, linux-omap, linux-fbdev
Use the common compare helper from component.
Cc: Helge Deller <deller@gmx.de>
Cc: linux-omap@vger.kernel.org
Cc: linux-fbdev@vger.kernel.org
Signed-off-by: Yong Wu <yong.wu@mediatek.com>
---
drivers/video/fbdev/omap2/omapfb/dss/dss.c | 8 +-------
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/drivers/video/fbdev/omap2/omapfb/dss/dss.c b/drivers/video/fbdev/omap2/omapfb/dss/dss.c
index a6b1c1598040..45b9d3cf3860 100644
--- a/drivers/video/fbdev/omap2/omapfb/dss/dss.c
+++ b/drivers/video/fbdev/omap2/omapfb/dss/dss.c
@@ -1193,12 +1193,6 @@ static const struct component_master_ops dss_component_ops = {
.unbind = dss_unbind,
};
-static int dss_component_compare(struct device *dev, void *data)
-{
- struct device *child = data;
- return dev == child;
-}
-
static int dss_add_child_component(struct device *dev, void *data)
{
struct component_match **match = data;
@@ -1212,7 +1206,7 @@ static int dss_add_child_component(struct device *dev, void *data)
if (strstr(dev_name(dev), "rfbi"))
return 0;
- component_match_add(dev->parent, match, dss_component_compare, dev);
+ component_match_add(dev->parent, match, component_compare_dev, dev);
return 0;
}
--
2.18.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 22/23] video: omapfb: dss: Make use of the helper component_compare_dev
2022-02-14 6:08 ` [PATCH 22/23] video: omapfb: dss: Make use of the helper component_compare_dev Yong Wu
@ 2022-02-15 20:46 ` Helge Deller
2022-02-25 11:07 ` Greg Kroah-Hartman
0 siblings, 1 reply; 3+ messages in thread
From: Helge Deller @ 2022-02-15 20:46 UTC (permalink / raw)
To: Yong Wu, Greg Kroah-Hartman, David Airlie, Daniel Vetter, dri-devel
Cc: James Wang, Liviu Dudau, iommu, Matthias Brugger,
Krzysztof Kozlowski, linux-kernel, Joerg Roedel, Will Deacon,
Arnd Bergmann, Laurent Pinchart, linux-mediatek, Chun-Kuang Hu,
linux-arm-kernel, Stephen Boyd, AngeloGioacchino Del Regno,
Hsin-Yi Wang, Robin Murphy, Tomasz Figa, srv_heupstream,
Rob Clark, Srinivas Kandagatla, Sebastian Reichel, linux-omap,
linux-fbdev
On 2/14/22 07:08, Yong Wu wrote:
> Use the common compare helper from component.
>
> Cc: Helge Deller <deller@gmx.de>
> Cc: linux-omap@vger.kernel.org
> Cc: linux-fbdev@vger.kernel.org
> Signed-off-by: Yong Wu <yong.wu@mediatek.com>
Applied to the fbdev for-next branch.
Thanks!
Helge
> drivers/video/fbdev/omap2/omapfb/dss/dss.c | 8 +-------
> 1 file changed, 1 insertion(+), 7 deletions(-)
>
> diff --git a/drivers/video/fbdev/omap2/omapfb/dss/dss.c b/drivers/video/fbdev/omap2/omapfb/dss/dss.c
> index a6b1c1598040..45b9d3cf3860 100644
> --- a/drivers/video/fbdev/omap2/omapfb/dss/dss.c
> +++ b/drivers/video/fbdev/omap2/omapfb/dss/dss.c
> @@ -1193,12 +1193,6 @@ static const struct component_master_ops dss_component_ops = {
> .unbind = dss_unbind,
> };
>
> -static int dss_component_compare(struct device *dev, void *data)
> -{
> - struct device *child = data;
> - return dev == child;
> -}
> -
> static int dss_add_child_component(struct device *dev, void *data)
> {
> struct component_match **match = data;
> @@ -1212,7 +1206,7 @@ static int dss_add_child_component(struct device *dev, void *data)
> if (strstr(dev_name(dev), "rfbi"))
> return 0;
>
> - component_match_add(dev->parent, match, dss_component_compare, dev);
> + component_match_add(dev->parent, match, component_compare_dev, dev);
>
> return 0;
> }
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 22/23] video: omapfb: dss: Make use of the helper component_compare_dev
2022-02-15 20:46 ` Helge Deller
@ 2022-02-25 11:07 ` Greg Kroah-Hartman
0 siblings, 0 replies; 3+ messages in thread
From: Greg Kroah-Hartman @ 2022-02-25 11:07 UTC (permalink / raw)
To: Helge Deller
Cc: Yong Wu, David Airlie, Daniel Vetter, dri-devel, James Wang,
Liviu Dudau, iommu, Matthias Brugger, Krzysztof Kozlowski,
linux-kernel, Joerg Roedel, Will Deacon, Arnd Bergmann,
Laurent Pinchart, linux-mediatek, Chun-Kuang Hu,
linux-arm-kernel, Stephen Boyd, AngeloGioacchino Del Regno,
Hsin-Yi Wang, Robin Murphy, Tomasz Figa, srv_heupstream,
Rob Clark, Srinivas Kandagatla, Sebastian Reichel, linux-omap,
linux-fbdev
On Tue, Feb 15, 2022 at 09:46:24PM +0100, Helge Deller wrote:
> On 2/14/22 07:08, Yong Wu wrote:
> > Use the common compare helper from component.
> >
> > Cc: Helge Deller <deller@gmx.de>
> > Cc: linux-omap@vger.kernel.org
> > Cc: linux-fbdev@vger.kernel.org
> > Signed-off-by: Yong Wu <yong.wu@mediatek.com>
>
> Applied to the fbdev for-next branch.
That will break the build, it needs patch 1/23 to build properly :(
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-02-25 11:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20220214060819.7334-1-yong.wu@mediatek.com>
2022-02-14 6:08 ` [PATCH 22/23] video: omapfb: dss: Make use of the helper component_compare_dev Yong Wu
2022-02-15 20:46 ` Helge Deller
2022-02-25 11:07 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).