From: Tero Kristo <kristo@kernel.org>
To: Rob Herring <robh+dt@kernel.org>,
Dario Binacchi <dariobin@libero.it>,
Tony Lindgren <tony@atomide.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Bin Meng <bmeng.cn@gmail.com>,
Frank Rowand <frowand.list@gmail.com>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
devicetree@vger.kernel.org, linux-clk <linux-clk@vger.kernel.org>,
linux-omap <linux-omap@vger.kernel.org>
Subject: Re: [PATCH 0/2] fdt: translate address if #size-cells = <0>
Date: Wed, 7 Apr 2021 16:21:20 +0300 [thread overview]
Message-ID: <a197b5d8-621b-6655-e571-2877d007cd4c@kernel.org> (raw)
In-Reply-To: <CAL_JsqLcus=Y5nOuV1wiAiVb1mTq9N8xqJpGJD6ip+Ec_6YDyw@mail.gmail.com>
On 07/04/2021 15:52, Rob Herring wrote:
> On Wed, Apr 7, 2021 at 2:07 AM Dario Binacchi <dariobin@libero.it> wrote:
>>
>>
>>> Il 07/04/2021 03:16 Rob Herring <robh+dt@kernel.org> ha scritto:
>>>
>>>
>>> On Tue, Apr 6, 2021 at 5:02 PM Dario Binacchi <dariobin@libero.it> wrote:
>>>>
>>>>
>>>>> Il 06/04/2021 16:06 Rob Herring <robh+dt@kernel.org> ha scritto:
>>>>>
>>>>>
>>>>> On Fri, Apr 2, 2021 at 2:21 PM Dario Binacchi <dariobin@libero.it> wrote:
>>>>>>
>>>>>>
>>>>>> The series comes from my commit in U-boot
>>>>>> d64b9cdcd4 ("fdt: translate address if #size-cells = <0>")
>>>>>> and from the subsequent exchange of emails at the end of which I was
>>>>>> suggested to send the patch to the linux kernel
>>>>>> (https://patchwork.ozlabs.org/project/uboot/patch/1614324949-61314-1-git-send-email-bmeng.cn@gmail.com/).
>>>>>
>>>>> It's 'ranges' that determines translatable which is missing from the
>>>>> DT. This should have not had a 0 size either though maybe we could
>>>>> support that.
>>>>
>>>> I have replied to the email you sent to the u-boot mailing list
>>>>
>>>>>
>>>>> Does the DT have to be updated anyways for your spread spectrum support?
>>>>
>>>> The spread spectrum support patch does not need this patch to work. They belong
>>>> to two different series.
>>>
>>> That's not what I asked. Is the spread spectrum support forcing a DT
>>> update for users?
>>
>> Yes, the deltam and modfreq registers must be added to the DPLL clocks.
>
> That's a shame given this dts has been mostly untouched since 2013.
>
I think technically it would be possible to map these registers within
the driver also, seeing there are like a handful of the DPLLs for both
am3/am4 which are impacted. Just add a new compatible or something, or
alternatively parse the register addresses and populate the
deltam/modfreq registers based on that.
>>> If the DT has to be changed anyways (not really
>>> great policy), then you could fix this in the DT at the same time.
>>
>> I could put the fix to the device tree in that series, although I wouldn't
>> create a single patch to fix and add the SSC registers. First the size-cells = <0>
>> fix patch and then the SSC patch.
>> Do you agree?
>
> By at the same time, I really just meant within 1 release.
>
> But I'd like to hear TI maintainers' thoughts on this.
I did post a comment on patch #1 questioning the approach from TI clock
driver perspective, imho I can't see why these two patches would be
needed right now.
-Tero
next prev parent reply other threads:[~2021-04-07 13:21 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-02 19:20 [PATCH 0/2] fdt: translate address if #size-cells = <0> Dario Binacchi
2021-04-02 19:20 ` [PATCH 2/2] clk: ti: get register address from device tree Dario Binacchi
2021-04-06 6:02 ` Tero Kristo
2021-04-06 14:06 ` [PATCH 0/2] fdt: translate address if #size-cells = <0> Rob Herring
2021-04-06 22:02 ` Dario Binacchi
2021-04-07 1:16 ` Rob Herring
2021-04-07 7:07 ` Dario Binacchi
2021-04-07 12:52 ` Rob Herring
2021-04-07 13:21 ` Tero Kristo [this message]
2021-04-08 20:24 ` Dario Binacchi
2021-04-09 10:32 ` Tero Kristo
2021-04-11 19:30 ` Dario Binacchi
2021-04-12 7:41 ` Tero Kristo
2021-04-14 20:39 ` Dario Binacchi
2021-04-17 8:37 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a197b5d8-621b-6655-e571-2877d007cd4c@kernel.org \
--to=kristo@kernel.org \
--cc=bmeng.cn@gmail.com \
--cc=dariobin@libero.it \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).