* [PATCH v2] parisc: select FTRACE_MCOUNT_USE_PATCHABLE_FUNCTION_ENTRY
@ 2021-02-24 22:57 Sami Tolvanen
2021-02-24 23:11 ` Guenter Roeck
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Sami Tolvanen @ 2021-02-24 22:57 UTC (permalink / raw)
To: James E.J. Bottomley, Helge Deller, Guenter Roeck
Cc: Steven Rostedt (VMware),
Kees Cook, linux-parisc, linux-kernel, Sami Tolvanen
parisc uses -fpatchable-function-entry with dynamic ftrace, which means we
don't need recordmcount. Select FTRACE_MCOUNT_USE_PATCHABLE_FUNCTION_ENTRY
to tell that to the build system.
Reported-by: Guenter Roeck <linux@roeck-us.net>
Fixes: 3b15cdc15956 ("tracing: move function tracer options to Kconfig")
Signed-off-by: Sami Tolvanen <samitolvanen@google.com>
---
arch/parisc/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/parisc/Kconfig b/arch/parisc/Kconfig
index ecef9aff9d72..f56c67bbe495 100644
--- a/arch/parisc/Kconfig
+++ b/arch/parisc/Kconfig
@@ -61,6 +61,7 @@ config PARISC
select HAVE_KRETPROBES
select HAVE_DYNAMIC_FTRACE if $(cc-option,-fpatchable-function-entry=1,1)
select HAVE_FTRACE_MCOUNT_RECORD if HAVE_DYNAMIC_FTRACE
+ select FTRACE_MCOUNT_USE_PATCHABLE_FUNCTION_ENTRY if DYNAMIC_FTRACE
select HAVE_KPROBES_ON_FTRACE
select HAVE_DYNAMIC_FTRACE_WITH_REGS
select SET_FS
base-commit: 062c84fccc4444805738d76a2699c4d3c95184ec
--
2.30.0.617.g56c4b15f3c-goog
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2] parisc: select FTRACE_MCOUNT_USE_PATCHABLE_FUNCTION_ENTRY
2021-02-24 22:57 [PATCH v2] parisc: select FTRACE_MCOUNT_USE_PATCHABLE_FUNCTION_ENTRY Sami Tolvanen
@ 2021-02-24 23:11 ` Guenter Roeck
2021-02-24 23:32 ` Kees Cook
2021-02-25 21:23 ` Kees Cook
2 siblings, 0 replies; 4+ messages in thread
From: Guenter Roeck @ 2021-02-24 23:11 UTC (permalink / raw)
To: Sami Tolvanen
Cc: James E.J. Bottomley, Helge Deller, Steven Rostedt (VMware),
Kees Cook, linux-parisc, linux-kernel
On Wed, Feb 24, 2021 at 02:57:06PM -0800, Sami Tolvanen wrote:
> parisc uses -fpatchable-function-entry with dynamic ftrace, which means we
> don't need recordmcount. Select FTRACE_MCOUNT_USE_PATCHABLE_FUNCTION_ENTRY
> to tell that to the build system.
>
> Reported-by: Guenter Roeck <linux@roeck-us.net>
> Fixes: 3b15cdc15956 ("tracing: move function tracer options to Kconfig")
> Signed-off-by: Sami Tolvanen <samitolvanen@google.com>
Tested-by: Guenter Roeck <linux@roeck-us.net>
Guenter
> ---
> arch/parisc/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/parisc/Kconfig b/arch/parisc/Kconfig
> index ecef9aff9d72..f56c67bbe495 100644
> --- a/arch/parisc/Kconfig
> +++ b/arch/parisc/Kconfig
> @@ -61,6 +61,7 @@ config PARISC
> select HAVE_KRETPROBES
> select HAVE_DYNAMIC_FTRACE if $(cc-option,-fpatchable-function-entry=1,1)
> select HAVE_FTRACE_MCOUNT_RECORD if HAVE_DYNAMIC_FTRACE
> + select FTRACE_MCOUNT_USE_PATCHABLE_FUNCTION_ENTRY if DYNAMIC_FTRACE
> select HAVE_KPROBES_ON_FTRACE
> select HAVE_DYNAMIC_FTRACE_WITH_REGS
> select SET_FS
>
> base-commit: 062c84fccc4444805738d76a2699c4d3c95184ec
> --
> 2.30.0.617.g56c4b15f3c-goog
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] parisc: select FTRACE_MCOUNT_USE_PATCHABLE_FUNCTION_ENTRY
2021-02-24 22:57 [PATCH v2] parisc: select FTRACE_MCOUNT_USE_PATCHABLE_FUNCTION_ENTRY Sami Tolvanen
2021-02-24 23:11 ` Guenter Roeck
@ 2021-02-24 23:32 ` Kees Cook
2021-02-25 21:23 ` Kees Cook
2 siblings, 0 replies; 4+ messages in thread
From: Kees Cook @ 2021-02-24 23:32 UTC (permalink / raw)
To: Sami Tolvanen
Cc: James E.J. Bottomley, Helge Deller, Guenter Roeck,
Steven Rostedt (VMware),
linux-parisc, linux-kernel
On Wed, Feb 24, 2021 at 02:57:06PM -0800, Sami Tolvanen wrote:
> parisc uses -fpatchable-function-entry with dynamic ftrace, which means we
> don't need recordmcount. Select FTRACE_MCOUNT_USE_PATCHABLE_FUNCTION_ENTRY
> to tell that to the build system.
>
> Reported-by: Guenter Roeck <linux@roeck-us.net>
> Fixes: 3b15cdc15956 ("tracing: move function tracer options to Kconfig")
> Signed-off-by: Sami Tolvanen <samitolvanen@google.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
Cross-build tested for defconfig, allmodconfig, allyesconfig:
Tested-by: Kees Cook <keescook@chromium.org>
-Kees
> ---
> arch/parisc/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/parisc/Kconfig b/arch/parisc/Kconfig
> index ecef9aff9d72..f56c67bbe495 100644
> --- a/arch/parisc/Kconfig
> +++ b/arch/parisc/Kconfig
> @@ -61,6 +61,7 @@ config PARISC
> select HAVE_KRETPROBES
> select HAVE_DYNAMIC_FTRACE if $(cc-option,-fpatchable-function-entry=1,1)
> select HAVE_FTRACE_MCOUNT_RECORD if HAVE_DYNAMIC_FTRACE
> + select FTRACE_MCOUNT_USE_PATCHABLE_FUNCTION_ENTRY if DYNAMIC_FTRACE
> select HAVE_KPROBES_ON_FTRACE
> select HAVE_DYNAMIC_FTRACE_WITH_REGS
> select SET_FS
>
> base-commit: 062c84fccc4444805738d76a2699c4d3c95184ec
> --
> 2.30.0.617.g56c4b15f3c-goog
>
--
Kees Cook
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] parisc: select FTRACE_MCOUNT_USE_PATCHABLE_FUNCTION_ENTRY
2021-02-24 22:57 [PATCH v2] parisc: select FTRACE_MCOUNT_USE_PATCHABLE_FUNCTION_ENTRY Sami Tolvanen
2021-02-24 23:11 ` Guenter Roeck
2021-02-24 23:32 ` Kees Cook
@ 2021-02-25 21:23 ` Kees Cook
2 siblings, 0 replies; 4+ messages in thread
From: Kees Cook @ 2021-02-25 21:23 UTC (permalink / raw)
To: Helge Deller, James E.J. Bottomley, Guenter Roeck, Sami Tolvanen
Cc: Kees Cook, linux-parisc, linux-kernel, Steven Rostedt (VMware)
On Wed, 24 Feb 2021 14:57:06 -0800, Sami Tolvanen wrote:
> parisc uses -fpatchable-function-entry with dynamic ftrace, which means we
> don't need recordmcount. Select FTRACE_MCOUNT_USE_PATCHABLE_FUNCTION_ENTRY
> to tell that to the build system.
Applied to kspp/clang-lto, thanks!
[1/1] parisc: select FTRACE_MCOUNT_USE_PATCHABLE_FUNCTION_ENTRY
https://git.kernel.org/kees/c/3d1dc719bca9
--
Kees Cook
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-02-25 21:24 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-24 22:57 [PATCH v2] parisc: select FTRACE_MCOUNT_USE_PATCHABLE_FUNCTION_ENTRY Sami Tolvanen
2021-02-24 23:11 ` Guenter Roeck
2021-02-24 23:32 ` Kees Cook
2021-02-25 21:23 ` Kees Cook
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).