From: Helge Deller <deller@gmx.de>
To: Sven Schnelle <svens@stackframe.org>,
John David Anglin <dave.anglin@bell.net>
Cc: linux-parisc <linux-parisc@vger.kernel.org>,
James Bottomley <James.Bottomley@HansenPartnership.com>
Subject: Re: [PATCH] parisc: Remove lock code to serialize TLB operations in pacache.S
Date: Wed, 17 Apr 2019 22:58:57 +0200 [thread overview]
Message-ID: <19e13735-bfe6-531a-1920-d8955546040e@gmx.de> (raw)
In-Reply-To: <20190417205515.GA2001@t470p.stackframe.org>
On 17.04.19 22:55, Sven Schnelle wrote:
> On Fri, Apr 12, 2019 at 07:12:04PM -0400, John David Anglin wrote:
>> TLB operations only need to be serialized on machines with the Merced (Stretch) bus.
>> The only machines in this category are L and N class, and they require a 64-bit PA 2.0
>> kernel. On these machines, we use local TLB purges in the tmpalias routines. We don't
>> need to serialize TLB purges on all other machines. Thus, the lock/unlock code can be
>> removed when CONFIG_PA20 is not defined. Further, when CONFIG_PA20 is not defined,
>> alternative patching converts the TLB purges to local purges when PA 2.0 hardware has
>> been detected.
>>
>> Signed-off-by: John David Anglin <dave.anglin@bell.net>
>
> I had this patch running on my C8000 and J5000 for a few days, and haven't
> encountered any issues.
Nah...
I do have one of the critical machines (rp5470), and I tried
to add the necessary code to detect and handle the TLB serialization.
Until now the patch sadly doesn't work yet (hangs at boot), it still needs more work.
You can find it in my git tree:
https://git.kernel.org/pub/scm/linux/kernel/git/deller/parisc-linux.git/commit/?h=tlb-flush-merced-bus&id=fc6044f83cb9828ec6ebecb23a46549d9ebc518f
Helge
next prev parent reply other threads:[~2019-04-17 20:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-12 23:12 [PATCH] parisc: Remove lock code to serialize TLB operations in pacache.S John David Anglin
2019-04-17 20:55 ` Sven Schnelle
2019-04-17 20:58 ` Helge Deller [this message]
2019-04-17 21:01 ` Helge Deller
2019-04-17 21:09 ` John David Anglin
2019-04-17 23:21 ` John David Anglin
2019-04-17 21:04 ` John David Anglin
2019-04-21 23:37 ` John David Anglin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19e13735-bfe6-531a-1920-d8955546040e@gmx.de \
--to=deller@gmx.de \
--cc=James.Bottomley@HansenPartnership.com \
--cc=dave.anglin@bell.net \
--cc=linux-parisc@vger.kernel.org \
--cc=svens@stackframe.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).