* [PATCH RESEND 0/8] Fix mmap base in bottom-up mmap
@ 2019-06-19 5:38 Alexandre Ghiti
0 siblings, 0 replies; 7+ messages in thread
From: Alexandre Ghiti @ 2019-06-19 5:38 UTC (permalink / raw)
To: Andrew Morton
Cc: James E . J . Bottomley, Helge Deller, Heiko Carstens,
Vasily Gorbik, Christian Borntraeger, Yoshinori Sato,
Rich Felker, David S . Miller, Thomas Gleixner, Ingo Molnar,
Borislav Petkov, H . Peter Anvin, x86, Dave Hansen,
Andy Lutomirski, Peter Zijlstra, linux-parisc, linux-kernel,
linux-s390, linux-sh, sparclinux, linux-mm, Alexandre Ghiti
(Sorry for the previous interrupted series)
This series fixes the fallback of the top-down mmap: in case of
failure, a bottom-up scheme can be tried as a last resort between
the top-down mmap base and the stack, hoping for a large unused stack
limit.
Lots of architectures and even mm code start this fallback
at TASK_UNMAPPED_BASE, which is useless since the top-down scheme
already failed on the whole address space: instead, simply use
mmap_base.
Along the way, it allows to get rid of of mmap_legacy_base and
mmap_compat_legacy_base from mm_struct.
Note that arm and mips already implement this behaviour.
Alexandre Ghiti (8):
s390: Start fallback of top-down mmap at mm->mmap_base
sh: Start fallback of top-down mmap at mm->mmap_base
sparc: Start fallback of top-down mmap at mm->mmap_base
x86, hugetlbpage: Start fallback of top-down mmap at mm->mmap_base
mm: Start fallback top-down mmap at mm->mmap_base
parisc: Use mmap_base, not mmap_legacy_base, as low_limit for
bottom-up mmap
x86: Use mmap_*base, not mmap_*legacy_base, as low_limit for bottom-up
mmap
mm: Remove mmap_legacy_base and mmap_compat_legacy_code fields from
mm_struct
arch/parisc/kernel/sys_parisc.c | 8 +++-----
arch/s390/mm/mmap.c | 2 +-
arch/sh/mm/mmap.c | 2 +-
arch/sparc/kernel/sys_sparc_64.c | 2 +-
arch/sparc/mm/hugetlbpage.c | 2 +-
arch/x86/include/asm/elf.h | 2 +-
arch/x86/kernel/sys_x86_64.c | 4 ++--
arch/x86/mm/hugetlbpage.c | 7 ++++---
arch/x86/mm/mmap.c | 20 +++++++++-----------
include/linux/mm_types.h | 2 --
mm/debug.c | 4 ++--
mm/mmap.c | 2 +-
12 files changed, 26 insertions(+), 31 deletions(-)
--
2.20.1
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH RESEND 0/8] Fix mmap base in bottom-up mmap
2019-08-26 22:37 ` Helge Deller
@ 2019-08-28 4:53 ` Alex Ghiti
0 siblings, 0 replies; 7+ messages in thread
From: Alex Ghiti @ 2019-08-28 4:53 UTC (permalink / raw)
To: Helge Deller, Andrew Morton
Cc: James E . J . Bottomley, Heiko Carstens, Vasily Gorbik,
Christian Borntraeger, Yoshinori Sato, Rich Felker,
David S . Miller, Thomas Gleixner, Ingo Molnar, Borislav Petkov,
H . Peter Anvin, x86, Dave Hansen, Andy Lutomirski,
Peter Zijlstra, linux-parisc, linux-kernel, linux-s390, linux-sh,
sparclinux, linux-mm
On 8/26/19 6:37 PM, Helge Deller wrote:
> On 26.08.19 09:34, Alexandre Ghiti wrote:
>> On 6/20/19 7:03 AM, Alexandre Ghiti wrote:
>>> This series fixes the fallback of the top-down mmap: in case of
>>> failure, a bottom-up scheme can be tried as a last resort between
>>> the top-down mmap base and the stack, hoping for a large unused stack
>>> limit.
>>>
>>> Lots of architectures and even mm code start this fallback
>>> at TASK_UNMAPPED_BASE, which is useless since the top-down scheme
>>> already failed on the whole address space: instead, simply use
>>> mmap_base.
>>>
>>> Along the way, it allows to get rid of of mmap_legacy_base and
>>> mmap_compat_legacy_base from mm_struct.
>>>
>>> Note that arm and mips already implement this behaviour.
>>>
>>> Alexandre Ghiti (8):
>>> s390: Start fallback of top-down mmap at mm->mmap_base
>>> sh: Start fallback of top-down mmap at mm->mmap_base
>>> sparc: Start fallback of top-down mmap at mm->mmap_base
>>> x86, hugetlbpage: Start fallback of top-down mmap at mm->mmap_base
>>> mm: Start fallback top-down mmap at mm->mmap_base
>>> parisc: Use mmap_base, not mmap_legacy_base, as low_limit for
>>> bottom-up mmap
>>> x86: Use mmap_*base, not mmap_*legacy_base, as low_limit for
>>> bottom-up
>>> mmap
>>> mm: Remove mmap_legacy_base and mmap_compat_legacy_code fields from
>>> mm_struct
>>>
>>> arch/parisc/kernel/sys_parisc.c | 8 +++-----
>>> arch/s390/mm/mmap.c | 2 +-
>>> arch/sh/mm/mmap.c | 2 +-
>>> arch/sparc/kernel/sys_sparc_64.c | 2 +-
>>> arch/sparc/mm/hugetlbpage.c | 2 +-
>>> arch/x86/include/asm/elf.h | 2 +-
>>> arch/x86/kernel/sys_x86_64.c | 4 ++--
>>> arch/x86/mm/hugetlbpage.c | 7 ++++---
>>> arch/x86/mm/mmap.c | 20 +++++++++-----------
>>> include/linux/mm_types.h | 2 --
>>> mm/debug.c | 4 ++--
>>> mm/mmap.c | 2 +-
>>> 12 files changed, 26 insertions(+), 31 deletions(-)
>>>
>>
>> Any thoughts about that series ? As said before, this is just a
>> preparatory patchset in order to
>> merge x86 mmap top down code with the generic version.
>
> I just tested your patch series successfully on the parisc
> architeture. You may add:
>
> Tested-by: Helge Deller <deller@gmx.de> # parisc
Thanks again Helge !
Alex
>
> Thanks!
> Helge
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH RESEND 0/8] Fix mmap base in bottom-up mmap
2019-08-26 7:34 ` Alexandre Ghiti
@ 2019-08-26 22:37 ` Helge Deller
2019-08-28 4:53 ` Alex Ghiti
0 siblings, 1 reply; 7+ messages in thread
From: Helge Deller @ 2019-08-26 22:37 UTC (permalink / raw)
To: Alexandre Ghiti, Andrew Morton
Cc: James E . J . Bottomley, Heiko Carstens, Vasily Gorbik,
Christian Borntraeger, Yoshinori Sato, Rich Felker,
David S . Miller, Thomas Gleixner, Ingo Molnar, Borislav Petkov,
H . Peter Anvin, x86, Dave Hansen, Andy Lutomirski,
Peter Zijlstra, linux-parisc, linux-kernel, linux-s390, linux-sh,
sparclinux, linux-mm
On 26.08.19 09:34, Alexandre Ghiti wrote:
> On 6/20/19 7:03 AM, Alexandre Ghiti wrote:
>> This series fixes the fallback of the top-down mmap: in case of
>> failure, a bottom-up scheme can be tried as a last resort between
>> the top-down mmap base and the stack, hoping for a large unused stack
>> limit.
>>
>> Lots of architectures and even mm code start this fallback
>> at TASK_UNMAPPED_BASE, which is useless since the top-down scheme
>> already failed on the whole address space: instead, simply use
>> mmap_base.
>>
>> Along the way, it allows to get rid of of mmap_legacy_base and
>> mmap_compat_legacy_base from mm_struct.
>>
>> Note that arm and mips already implement this behaviour.
>>
>> Alexandre Ghiti (8):
>> s390: Start fallback of top-down mmap at mm->mmap_base
>> sh: Start fallback of top-down mmap at mm->mmap_base
>> sparc: Start fallback of top-down mmap at mm->mmap_base
>> x86, hugetlbpage: Start fallback of top-down mmap at mm->mmap_base
>> mm: Start fallback top-down mmap at mm->mmap_base
>> parisc: Use mmap_base, not mmap_legacy_base, as low_limit for
>> bottom-up mmap
>> x86: Use mmap_*base, not mmap_*legacy_base, as low_limit for bottom-up
>> mmap
>> mm: Remove mmap_legacy_base and mmap_compat_legacy_code fields from
>> mm_struct
>>
>> arch/parisc/kernel/sys_parisc.c | 8 +++-----
>> arch/s390/mm/mmap.c | 2 +-
>> arch/sh/mm/mmap.c | 2 +-
>> arch/sparc/kernel/sys_sparc_64.c | 2 +-
>> arch/sparc/mm/hugetlbpage.c | 2 +-
>> arch/x86/include/asm/elf.h | 2 +-
>> arch/x86/kernel/sys_x86_64.c | 4 ++--
>> arch/x86/mm/hugetlbpage.c | 7 ++++---
>> arch/x86/mm/mmap.c | 20 +++++++++-----------
>> include/linux/mm_types.h | 2 --
>> mm/debug.c | 4 ++--
>> mm/mmap.c | 2 +-
>> 12 files changed, 26 insertions(+), 31 deletions(-)
>>
>
> Any thoughts about that series ? As said before, this is just a preparatory patchset in order to
> merge x86 mmap top down code with the generic version.
I just tested your patch series successfully on the parisc
architeture. You may add:
Tested-by: Helge Deller <deller@gmx.de> # parisc
Thanks!
Helge
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH RESEND 0/8] Fix mmap base in bottom-up mmap
2019-06-20 5:03 Alexandre Ghiti
2019-07-30 6:12 ` Alexandre Ghiti
@ 2019-08-26 7:34 ` Alexandre Ghiti
2019-08-26 22:37 ` Helge Deller
1 sibling, 1 reply; 7+ messages in thread
From: Alexandre Ghiti @ 2019-08-26 7:34 UTC (permalink / raw)
To: Andrew Morton
Cc: James E . J . Bottomley, Helge Deller, Heiko Carstens,
Vasily Gorbik, Christian Borntraeger, Yoshinori Sato,
Rich Felker, David S . Miller, Thomas Gleixner, Ingo Molnar,
Borislav Petkov, H . Peter Anvin, x86, Dave Hansen,
Andy Lutomirski, Peter Zijlstra, linux-parisc, linux-kernel,
linux-s390, linux-sh, sparclinux, linux-mm
On 6/20/19 7:03 AM, Alexandre Ghiti wrote:
> This series fixes the fallback of the top-down mmap: in case of
> failure, a bottom-up scheme can be tried as a last resort between
> the top-down mmap base and the stack, hoping for a large unused stack
> limit.
>
> Lots of architectures and even mm code start this fallback
> at TASK_UNMAPPED_BASE, which is useless since the top-down scheme
> already failed on the whole address space: instead, simply use
> mmap_base.
>
> Along the way, it allows to get rid of of mmap_legacy_base and
> mmap_compat_legacy_base from mm_struct.
>
> Note that arm and mips already implement this behaviour.
>
> Alexandre Ghiti (8):
> s390: Start fallback of top-down mmap at mm->mmap_base
> sh: Start fallback of top-down mmap at mm->mmap_base
> sparc: Start fallback of top-down mmap at mm->mmap_base
> x86, hugetlbpage: Start fallback of top-down mmap at mm->mmap_base
> mm: Start fallback top-down mmap at mm->mmap_base
> parisc: Use mmap_base, not mmap_legacy_base, as low_limit for
> bottom-up mmap
> x86: Use mmap_*base, not mmap_*legacy_base, as low_limit for bottom-up
> mmap
> mm: Remove mmap_legacy_base and mmap_compat_legacy_code fields from
> mm_struct
>
> arch/parisc/kernel/sys_parisc.c | 8 +++-----
> arch/s390/mm/mmap.c | 2 +-
> arch/sh/mm/mmap.c | 2 +-
> arch/sparc/kernel/sys_sparc_64.c | 2 +-
> arch/sparc/mm/hugetlbpage.c | 2 +-
> arch/x86/include/asm/elf.h | 2 +-
> arch/x86/kernel/sys_x86_64.c | 4 ++--
> arch/x86/mm/hugetlbpage.c | 7 ++++---
> arch/x86/mm/mmap.c | 20 +++++++++-----------
> include/linux/mm_types.h | 2 --
> mm/debug.c | 4 ++--
> mm/mmap.c | 2 +-
> 12 files changed, 26 insertions(+), 31 deletions(-)
>
Hi everyone,
Any thoughts about that series ? As said before, this is just a
preparatory patchset in order to
merge x86 mmap top down code with the generic version.
Thanks for taking a look,
Alex
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH RESEND 0/8] Fix mmap base in bottom-up mmap
2019-06-20 5:03 Alexandre Ghiti
@ 2019-07-30 6:12 ` Alexandre Ghiti
2019-08-26 7:34 ` Alexandre Ghiti
1 sibling, 0 replies; 7+ messages in thread
From: Alexandre Ghiti @ 2019-07-30 6:12 UTC (permalink / raw)
To: Andrew Morton
Cc: James E . J . Bottomley, Helge Deller, Heiko Carstens,
Vasily Gorbik, Christian Borntraeger, Yoshinori Sato,
Rich Felker, David S . Miller, Thomas Gleixner, Ingo Molnar,
Borislav Petkov, H . Peter Anvin, x86, Dave Hansen,
Andy Lutomirski, Peter Zijlstra, linux-parisc, linux-kernel,
linux-s390, linux-sh, sparclinux, linux-mm
On 6/20/19 7:03 AM, Alexandre Ghiti wrote:
> This series fixes the fallback of the top-down mmap: in case of
> failure, a bottom-up scheme can be tried as a last resort between
> the top-down mmap base and the stack, hoping for a large unused stack
> limit.
>
> Lots of architectures and even mm code start this fallback
> at TASK_UNMAPPED_BASE, which is useless since the top-down scheme
> already failed on the whole address space: instead, simply use
> mmap_base.
>
> Along the way, it allows to get rid of of mmap_legacy_base and
> mmap_compat_legacy_base from mm_struct.
>
> Note that arm and mips already implement this behaviour.
>
> Alexandre Ghiti (8):
> s390: Start fallback of top-down mmap at mm->mmap_base
> sh: Start fallback of top-down mmap at mm->mmap_base
> sparc: Start fallback of top-down mmap at mm->mmap_base
> x86, hugetlbpage: Start fallback of top-down mmap at mm->mmap_base
> mm: Start fallback top-down mmap at mm->mmap_base
> parisc: Use mmap_base, not mmap_legacy_base, as low_limit for
> bottom-up mmap
> x86: Use mmap_*base, not mmap_*legacy_base, as low_limit for bottom-up
> mmap
> mm: Remove mmap_legacy_base and mmap_compat_legacy_code fields from
> mm_struct
>
> arch/parisc/kernel/sys_parisc.c | 8 +++-----
> arch/s390/mm/mmap.c | 2 +-
> arch/sh/mm/mmap.c | 2 +-
> arch/sparc/kernel/sys_sparc_64.c | 2 +-
> arch/sparc/mm/hugetlbpage.c | 2 +-
> arch/x86/include/asm/elf.h | 2 +-
> arch/x86/kernel/sys_x86_64.c | 4 ++--
> arch/x86/mm/hugetlbpage.c | 7 ++++---
> arch/x86/mm/mmap.c | 20 +++++++++-----------
> include/linux/mm_types.h | 2 --
> mm/debug.c | 4 ++--
> mm/mmap.c | 2 +-
> 12 files changed, 26 insertions(+), 31 deletions(-)
>
Hi everyone,
This is just a preparatory series for the merging of x86 mmap top-down
functions with
the generic ones (those should get into v5.3), if you could take some
time to take a look,
that would be great :)
Thanks,
Alex
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH RESEND 0/8] Fix mmap base in bottom-up mmap
@ 2019-06-20 5:03 Alexandre Ghiti
2019-07-30 6:12 ` Alexandre Ghiti
2019-08-26 7:34 ` Alexandre Ghiti
0 siblings, 2 replies; 7+ messages in thread
From: Alexandre Ghiti @ 2019-06-20 5:03 UTC (permalink / raw)
To: Andrew Morton
Cc: James E . J . Bottomley, Helge Deller, Heiko Carstens,
Vasily Gorbik, Christian Borntraeger, Yoshinori Sato,
Rich Felker, David S . Miller, Thomas Gleixner, Ingo Molnar,
Borislav Petkov, H . Peter Anvin, x86, Dave Hansen,
Andy Lutomirski, Peter Zijlstra, linux-parisc, linux-kernel,
linux-s390, linux-sh, sparclinux, linux-mm, Alexandre Ghiti
This series fixes the fallback of the top-down mmap: in case of
failure, a bottom-up scheme can be tried as a last resort between
the top-down mmap base and the stack, hoping for a large unused stack
limit.
Lots of architectures and even mm code start this fallback
at TASK_UNMAPPED_BASE, which is useless since the top-down scheme
already failed on the whole address space: instead, simply use
mmap_base.
Along the way, it allows to get rid of of mmap_legacy_base and
mmap_compat_legacy_base from mm_struct.
Note that arm and mips already implement this behaviour.
Alexandre Ghiti (8):
s390: Start fallback of top-down mmap at mm->mmap_base
sh: Start fallback of top-down mmap at mm->mmap_base
sparc: Start fallback of top-down mmap at mm->mmap_base
x86, hugetlbpage: Start fallback of top-down mmap at mm->mmap_base
mm: Start fallback top-down mmap at mm->mmap_base
parisc: Use mmap_base, not mmap_legacy_base, as low_limit for
bottom-up mmap
x86: Use mmap_*base, not mmap_*legacy_base, as low_limit for bottom-up
mmap
mm: Remove mmap_legacy_base and mmap_compat_legacy_code fields from
mm_struct
arch/parisc/kernel/sys_parisc.c | 8 +++-----
arch/s390/mm/mmap.c | 2 +-
arch/sh/mm/mmap.c | 2 +-
arch/sparc/kernel/sys_sparc_64.c | 2 +-
arch/sparc/mm/hugetlbpage.c | 2 +-
arch/x86/include/asm/elf.h | 2 +-
arch/x86/kernel/sys_x86_64.c | 4 ++--
arch/x86/mm/hugetlbpage.c | 7 ++++---
arch/x86/mm/mmap.c | 20 +++++++++-----------
include/linux/mm_types.h | 2 --
mm/debug.c | 4 ++--
mm/mmap.c | 2 +-
12 files changed, 26 insertions(+), 31 deletions(-)
--
2.20.1
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH RESEND 0/8] Fix mmap base in bottom-up mmap
@ 2019-06-19 5:42 Alexandre Ghiti
0 siblings, 0 replies; 7+ messages in thread
From: Alexandre Ghiti @ 2019-06-19 5:42 UTC (permalink / raw)
To: Andrew Morton
Cc: James E . J . Bottomley, Helge Deller, Heiko Carstens,
Vasily Gorbik, Christian Borntraeger, Yoshinori Sato,
Rich Felker, David S . Miller, Thomas Gleixner, Ingo Molnar,
Borislav Petkov, H . Peter Anvin, x86, Dave Hansen,
Andy Lutomirski, Peter Zijlstra, linux-parisc, linux-kernel,
linux-s390, linux-sh, sparclinux, linux-mm, Alexandre Ghiti
This series fixes the fallback of the top-down mmap: in case of
failure, a bottom-up scheme can be tried as a last resort between
the top-down mmap base and the stack, hoping for a large unused stack
limit.
Lots of architectures and even mm code start this fallback
at TASK_UNMAPPED_BASE, which is useless since the top-down scheme
already failed on the whole address space: instead, simply use
mmap_base.
Along the way, it allows to get rid of of mmap_legacy_base and
mmap_compat_legacy_base from mm_struct.
Note that arm and mips already implement this behaviour.
Alexandre Ghiti (8):
s390: Start fallback of top-down mmap at mm->mmap_base
sh: Start fallback of top-down mmap at mm->mmap_base
sparc: Start fallback of top-down mmap at mm->mmap_base
x86, hugetlbpage: Start fallback of top-down mmap at mm->mmap_base
mm: Start fallback top-down mmap at mm->mmap_base
parisc: Use mmap_base, not mmap_legacy_base, as low_limit for
bottom-up mmap
x86: Use mmap_*base, not mmap_*legacy_base, as low_limit for bottom-up
mmap
mm: Remove mmap_legacy_base and mmap_compat_legacy_code fields from
mm_struct
arch/parisc/kernel/sys_parisc.c | 8 +++-----
arch/s390/mm/mmap.c | 2 +-
arch/sh/mm/mmap.c | 2 +-
arch/sparc/kernel/sys_sparc_64.c | 2 +-
arch/sparc/mm/hugetlbpage.c | 2 +-
arch/x86/include/asm/elf.h | 2 +-
arch/x86/kernel/sys_x86_64.c | 4 ++--
arch/x86/mm/hugetlbpage.c | 7 ++++---
arch/x86/mm/mmap.c | 20 +++++++++-----------
include/linux/mm_types.h | 2 --
mm/debug.c | 4 ++--
mm/mmap.c | 2 +-
12 files changed, 26 insertions(+), 31 deletions(-)
--
2.20.1
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2019-08-28 4:53 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-19 5:38 [PATCH RESEND 0/8] Fix mmap base in bottom-up mmap Alexandre Ghiti
2019-06-19 5:42 Alexandre Ghiti
2019-06-20 5:03 Alexandre Ghiti
2019-07-30 6:12 ` Alexandre Ghiti
2019-08-26 7:34 ` Alexandre Ghiti
2019-08-26 22:37 ` Helge Deller
2019-08-28 4:53 ` Alex Ghiti
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).