* [PATCH] net: tulip: make early_486_chipsets static
@ 2020-04-15 8:42 Jason Yan
2020-04-15 23:22 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Jason Yan @ 2020-04-15 8:42 UTC (permalink / raw)
To: davem, snelson, kuba, hkallweit1, leon, yanaijie, mst, netdev,
linux-parisc, linux-kernel
Cc: Hulk Robot
Fix the following sparse warning:
drivers/net/ethernet/dec/tulip/tulip_core.c:1280:28: warning: symbol
'early_486_chipsets' was not declared. Should it be static?
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Jason Yan <yanaijie@huawei.com>
---
drivers/net/ethernet/dec/tulip/tulip_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/dec/tulip/tulip_core.c b/drivers/net/ethernet/dec/tulip/tulip_core.c
index 48ea658aa1a6..15efc294f513 100644
--- a/drivers/net/ethernet/dec/tulip/tulip_core.c
+++ b/drivers/net/ethernet/dec/tulip/tulip_core.c
@@ -1277,7 +1277,7 @@ static const struct net_device_ops tulip_netdev_ops = {
#endif
};
-const struct pci_device_id early_486_chipsets[] = {
+static const struct pci_device_id early_486_chipsets[] = {
{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_82424) },
{ PCI_DEVICE(PCI_VENDOR_ID_SI, PCI_DEVICE_ID_SI_496) },
{ },
--
2.21.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] net: tulip: make early_486_chipsets static
2020-04-15 8:42 [PATCH] net: tulip: make early_486_chipsets static Jason Yan
@ 2020-04-15 23:22 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2020-04-15 23:22 UTC (permalink / raw)
To: yanaijie
Cc: snelson, kuba, hkallweit1, leon, mst, netdev, linux-parisc,
linux-kernel, hulkci
From: Jason Yan <yanaijie@huawei.com>
Date: Wed, 15 Apr 2020 16:42:48 +0800
> Fix the following sparse warning:
>
> drivers/net/ethernet/dec/tulip/tulip_core.c:1280:28: warning: symbol
> 'early_486_chipsets' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Jason Yan <yanaijie@huawei.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-04-15 23:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-15 8:42 [PATCH] net: tulip: make early_486_chipsets static Jason Yan
2020-04-15 23:22 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).