Linux-parisc archive on lore.kernel.org
 help / Atom feed
* [PATCH] parisc: Improve initial IRQ to CPU assignment
@ 2019-01-04 23:05 Helge Deller
  2019-01-04 23:21 ` Dennis Clarke
  0 siblings, 1 reply; 5+ messages in thread
From: Helge Deller @ 2019-01-04 23:05 UTC (permalink / raw)
  To: linux-parisc, James Bottomley, John David Anglin

On parisc, each IRQ can only be handled by one CPU, and currently CPU0
is choosen as default for handling all IRQs by default.
With this patch we now assign each requested IRQ to one of the online
CPUs (and thus distribute the IRQs across all CPUs), even without an
instance of irqbalance running.

Signed-off-by: Helge Deller <deller@gmx.de>

diff --git a/arch/parisc/kernel/irq.c b/arch/parisc/kernel/irq.c
index fd6d873..04e8755 100644
--- a/arch/parisc/kernel/irq.c
+++ b/arch/parisc/kernel/irq.c
@@ -117,7 +117,10 @@ int cpu_check_affinity(struct irq_data *d, const struct cpumask *dest)
 		return -EINVAL;
 
 	/* whatever mask they set, we just allow one CPU */
-	cpu_dest = cpumask_first_and(dest, cpu_online_mask);
+	cpu_dest = cpumask_next_and(d->irq & (num_online_cpus()-1),
+					dest, cpu_online_mask);
+	if (cpu_dest >= nr_cpu_ids)
+		cpu_dest = cpumask_first_and(dest, cpu_online_mask);
 
 	return cpu_dest;
 }

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] parisc: Improve initial IRQ to CPU assignment
  2019-01-04 23:05 [PATCH] parisc: Improve initial IRQ to CPU assignment Helge Deller
@ 2019-01-04 23:21 ` Dennis Clarke
  2019-01-05 21:21   ` Helge Deller
  0 siblings, 1 reply; 5+ messages in thread
From: Dennis Clarke @ 2019-01-04 23:21 UTC (permalink / raw)
  To: Helge Deller, linux-parisc, James Bottomley, John David Anglin

On 1/4/19 6:05 PM, Helge Deller wrote:
> On parisc, each IRQ can only be handled by one CPU, and currently CPU0
> is choosen as default for handling all IRQs by default.
> With this patch we now assign each requested IRQ to one of the online
> CPUs (and thus distribute the IRQs across all CPUs), even without an
> instance of irqbalance running.

Will this take into consideration the features in default_smp_affinity
and allow processor cores to be considered 'non interrupt' service
state?

Dennis

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] parisc: Improve initial IRQ to CPU assignment
  2019-01-04 23:21 ` Dennis Clarke
@ 2019-01-05 21:21   ` Helge Deller
  2019-01-05 21:45     ` Dennis Clarke
  0 siblings, 1 reply; 5+ messages in thread
From: Helge Deller @ 2019-01-05 21:21 UTC (permalink / raw)
  To: Dennis Clarke, linux-parisc, James Bottomley, John David Anglin

On 05.01.19 00:21, Dennis Clarke wrote:
> On 1/4/19 6:05 PM, Helge Deller wrote:
>> On parisc, each IRQ can only be handled by one CPU, and currently CPU0
>> is choosen as default for handling all IRQs by default.
>> With this patch we now assign each requested IRQ to one of the online
>> CPUs (and thus distribute the IRQs across all CPUs), even without an
>> instance of irqbalance running.
> 
> Will this take into consideration the features in default_smp_affinity
> and allow processor cores to be considered 'non interrupt' service
> state?

It seems the feature of default_smp_affinity to disable specific cores from
servicing interrupts doesn't work on the parisc platform.
On a 2-CPU machine I booted with the "irqaffinity=0" kernel commandline option
(to enable CPU#0 and disable CPU#1), which then led to a hanging kernel when
CPU#1 ist started.
On parisc, each CPU needs to handle at least it's timer and IPMI interrupt.
Any idea what I should try?

Helge

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] parisc: Improve initial IRQ to CPU assignment
  2019-01-05 21:21   ` Helge Deller
@ 2019-01-05 21:45     ` Dennis Clarke
  2019-01-05 22:36       ` Helge Deller
  0 siblings, 1 reply; 5+ messages in thread
From: Dennis Clarke @ 2019-01-05 21:45 UTC (permalink / raw)
  To: Helge Deller, linux-parisc, James Bottomley, John David Anglin

On 1/5/19 4:21 PM, Helge Deller wrote:
> On 05.01.19 00:21, Dennis Clarke wrote:
>> On 1/4/19 6:05 PM, Helge Deller wrote:
>>> On parisc, each IRQ can only be handled by one CPU, and currently CPU0
>>> is choosen as default for handling all IRQs by default.
>>> With this patch we now assign each requested IRQ to one of the online
>>> CPUs (and thus distribute the IRQs across all CPUs), even without an
>>> instance of irqbalance running.
>>
>> Will this take into consideration the features in default_smp_affinity
>> and allow processor cores to be considered 'non interrupt' service
>> state?
> 
> It seems the feature of default_smp_affinity to disable specific cores from
> servicing interrupts doesn't work on the parisc platform.
> On a 2-CPU machine I booted with the "irqaffinity=0" kernel commandline option
> (to enable CPU#0 and disable CPU#1), which then led to a hanging kernel when
> CPU#1 ist started.
> On parisc, each CPU needs to handle at least it's timer and IPMI interrupt.
> Any idea what I should try?

Sorry, the first question was "does this work there" and we now know it
is most likely "no". I tried similar on ppc64 and also arrived at
nothing but problems.

I am somewhat focused on digging into RISC-V at the moment and your post
raised the question in my mind.

One of the features I once enjoyed about Solaris was that it could
easily bring cpu cores online and offline as well as disable irq service
disruptions on any core with a trivial one line command. I always wanted
to port something similar over to linux but would start with something
interesting like RISC-V.

I'll get back to you on this one.

Dennis Clarke

ps: Also I still have those black superdomes standing around doing
     nothing and still want to get serial attached, powered up, etc.
     Yet another news years resolution post-it note idea.









^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] parisc: Improve initial IRQ to CPU assignment
  2019-01-05 21:45     ` Dennis Clarke
@ 2019-01-05 22:36       ` Helge Deller
  0 siblings, 0 replies; 5+ messages in thread
From: Helge Deller @ 2019-01-05 22:36 UTC (permalink / raw)
  To: Dennis Clarke, linux-parisc, James Bottomley, John David Anglin

On 05.01.19 22:45, Dennis Clarke wrote:
> On 1/5/19 4:21 PM, Helge Deller wrote:
>> On 05.01.19 00:21, Dennis Clarke wrote:
>>> On 1/4/19 6:05 PM, Helge Deller wrote:
>>>> On parisc, each IRQ can only be handled by one CPU, and currently CPU0
>>>> is choosen as default for handling all IRQs by default.
>>>> With this patch we now assign each requested IRQ to one of the online
>>>> CPUs (and thus distribute the IRQs across all CPUs), even without an
>>>> instance of irqbalance running.
>>>
>>> Will this take into consideration the features in default_smp_affinity
>>> and allow processor cores to be considered 'non interrupt' service
>>> state?
>>
>> It seems the feature of default_smp_affinity to disable specific cores from
>> servicing interrupts doesn't work on the parisc platform.
>> On a 2-CPU machine I booted with the "irqaffinity=0" kernel commandline option
>> (to enable CPU#0 and disable CPU#1), which then led to a hanging kernel when
>> CPU#1 ist started.
>> On parisc, each CPU needs to handle at least it's timer and IPMI interrupt.
>> Any idea what I should try?
> 
> Sorry, the first question was "does this work there" and we now know it
> is most likely "no". I tried similar on ppc64 and also arrived at
> nothing but problems.
> 
> I am somewhat focused on digging into RISC-V at the moment and your post
> raised the question in my mind.
> 
> One of the features I once enjoyed about Solaris was that it could
> easily bring cpu cores online and offline as well as disable irq service
> disruptions on any core with a trivial one line command.

That's already possible on Linux (e.g. on x86,power,...).
 > I always wanted to port something similar over to linux but would
> start with something interesting like RISC-V.

There shouldn't be much to port.
Even on parisc, enabling and disabling irqs on specific CPUs is possible
today with simple echo-commands into the files in /proc/irq/#/... (with the
exception of timer and IPI irqs).
Onlining and offlining cpu cores is on my todo list for parisc.
So, I think it shouldn't take much to do that on RISC-V too.

> ps: Also I still have those black superdomes standing around doing
>     nothing and still want to get serial attached, powered up, etc.
>     Yet another news years resolution post-it note idea.

Yes, would be interesting.

Helge

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, back to index

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-04 23:05 [PATCH] parisc: Improve initial IRQ to CPU assignment Helge Deller
2019-01-04 23:21 ` Dennis Clarke
2019-01-05 21:21   ` Helge Deller
2019-01-05 21:45     ` Dennis Clarke
2019-01-05 22:36       ` Helge Deller

Linux-parisc archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-parisc/0 linux-parisc/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-parisc linux-parisc/ https://lore.kernel.org/linux-parisc \
		linux-parisc@vger.kernel.org linux-parisc@archiver.kernel.org
	public-inbox-index linux-parisc


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-parisc


AGPL code for this site: git clone https://public-inbox.org/ public-inbox