From: Rolf Eike Beer <eike-kernel@sf-tec.de>
To: Li zeming <zeming@nfschina.com>,
James.Bottomley@hansenpartnership.com,
Helge Deller <deller@gmx.de>
Cc: linux-parisc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] parisc: Increase the usage check of kmalloc allocated object a
Date: Wed, 14 Sep 2022 16:25:59 +0200 [thread overview]
Message-ID: <7266457.TOmriZnqnj@eto.sf-tec.de> (raw)
In-Reply-To: <3a72852c-2f28-2916-f02c-b52cb06efd7d@gmx.de>
[-- Attachment #1: Type: text/plain, Size: 1113 bytes --]
Am Mittwoch, 14. September 2022, 11:04:33 CEST schrieb Helge Deller:
> On 9/14/22 08:43, Rolf Eike Beer wrote:
> > Am Mittwoch, 14. September 2022, 08:18:19 CEST schrieb Helge Deller:
> >> On 9/14/22 08:04, Li zeming wrote:
> Yes, your proposal is good.
> Anyone want to send a patch (with a small comment that kcalloc() will return
> at least the required 8-byte alignment)?
Done.
> > And these functions end up propagating an allocation error in this file
> > and it will never reach kernel/setup.c, which seems bad.
>
> That part I don't understand.
> The return value of iosapic_alloc_irt() is checked afterwards, but you
> probably meant something else?
>
> > But I guess the only point where this really can go wrong if the PDC
> > returns an absurdly large number of entries.
What I meant was that if iosapic_alloc_irt() fails, then iosapic_load_irt()
will return 0, which can either be "nothing to do" or "error". iosapic_init()
is void, so even if it could detect the failure, it can't report it upwards to
parisc_init(). Which is the same for basically all other *_init() calls in
there.
Eike
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
next prev parent reply other threads:[~2022-09-14 14:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-14 6:04 [PATCH] parisc: Increase the usage check of kmalloc allocated object a Li zeming
2022-09-14 6:18 ` Helge Deller
2022-09-14 6:43 ` Rolf Eike Beer
2022-09-14 9:04 ` Helge Deller
2022-09-14 14:25 ` Rolf Eike Beer [this message]
2022-09-15 5:44 ` Helge Deller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7266457.TOmriZnqnj@eto.sf-tec.de \
--to=eike-kernel@sf-tec.de \
--cc=James.Bottomley@hansenpartnership.com \
--cc=deller@gmx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=zeming@nfschina.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).