Linux-parisc archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] scsi: ncr53c8xx: Mark expected switch fall-through
@ 2019-08-03 19:34 Helge Deller
  2019-08-08  1:53 ` Martin K. Petersen
  0 siblings, 1 reply; 2+ messages in thread
From: Helge Deller @ 2019-08-03 19:34 UTC (permalink / raw)
  To: James E.J. Bottomley, Martin K. Petersen, linux-scsi; +Cc: linux-parisc

Signed-off-by: Helge Deller <deller@gmx.de>

diff --git a/drivers/scsi/ncr53c8xx.c b/drivers/scsi/ncr53c8xx.c
index e6a95498ac0d..e0b427fdf818 100644
--- a/drivers/scsi/ncr53c8xx.c
+++ b/drivers/scsi/ncr53c8xx.c
@@ -3910,11 +3910,14 @@ static void __init ncr_prepare_setting(struct ncb *np)
 					np->scsi_mode = SMODE_HVD;
 				break;
 			}
+			/* fall through */
 		case 3:	/* SYMBIOS controllers report HVD through GPIO3 */
 			if (INB(nc_gpreg) & 0x08)
 				break;
+			/* fall through */
 		case 2:	/* Set HVD unconditionally */
 			np->scsi_mode = SMODE_HVD;
+			/* fall through */
 		case 1:	/* Trust previous settings for HVD */
 			if (np->sv_stest2 & 0x20)
 				np->scsi_mode = SMODE_HVD;
@@ -6714,6 +6717,7 @@ void ncr_int_sir (struct ncb *np)
 			OUTL_DSP (scr_to_cpu(tp->lp[0]->jump_ccb[0]));
 			return;
 		}
+		/* fall through */
 	case SIR_RESEL_BAD_TARGET:	/* Will send a TARGET RESET message */
 	case SIR_RESEL_BAD_LUN:		/* Will send a TARGET RESET message */
 	case SIR_RESEL_BAD_I_T_L_Q:	/* Will send an ABORT TAG message   */

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] scsi: ncr53c8xx: Mark expected switch fall-through
  2019-08-03 19:34 [PATCH] scsi: ncr53c8xx: Mark expected switch fall-through Helge Deller
@ 2019-08-08  1:53 ` Martin K. Petersen
  0 siblings, 0 replies; 2+ messages in thread
From: Martin K. Petersen @ 2019-08-08  1:53 UTC (permalink / raw)
  To: Helge Deller
  Cc: James E.J. Bottomley, Martin K. Petersen, linux-scsi, linux-parisc


Helge,

Applied to 5.4/scsi-queue. Thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-03 19:34 [PATCH] scsi: ncr53c8xx: Mark expected switch fall-through Helge Deller
2019-08-08  1:53 ` Martin K. Petersen

Linux-parisc archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-parisc/0 linux-parisc/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-parisc linux-parisc/ https://lore.kernel.org/linux-parisc \
		linux-parisc@vger.kernel.org linux-parisc@archiver.kernel.org
	public-inbox-index linux-parisc


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-parisc


AGPL code for this site: git clone https://public-inbox.org/ public-inbox