From: Marek Vasut <marek.vasut@gmail.com>
To: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Cc: linux-pci@vger.kernel.org,
Kazufumi Ikeda <kaz-ikeda@xc.jp.nec.com>,
Gaku Inami <gaku.inami.xw@bp.renesas.com>,
Marek Vasut <marek.vasut+renesas@gmail.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Phil Edworthy <phil.edworthy@renesas.com>,
Simon Horman <horms+renesas@verge.net.au>,
Wolfram Sang <wsa@the-dreams.de>,
linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH V3] PCI: rcar: Add the suspend/resume for pcie-rcar driver
Date: Sun, 26 Apr 2020 14:33:32 +0200 [thread overview]
Message-ID: <07fecbce-55f3-af8e-1887-42f7a8074b54@gmail.com> (raw)
In-Reply-To: <20200320101217.GA22055@e121166-lin.cambridge.arm.com>
On 3/20/20 11:12 AM, Lorenzo Pieralisi wrote:
[...]
>> +static int rcar_pcie_resume(struct device *dev)
>> +{
>> + struct rcar_pcie *pcie = dev_get_drvdata(dev);
>> + int (*hw_init_fn)(struct rcar_pcie *);
>> + unsigned int data;
>> + int err;
>> +
>> + err = rcar_pcie_parse_map_dma_ranges(pcie);
>> + if (err)
>> + return 0;
>> +
>> + /* Failure to get a link might just be that no cards are inserted */
>> + hw_init_fn = of_device_get_match_data(dev);
>
> Hi Marek,
Hi,
> happy to apply it as is, I was wondering if it is work taking this
> look-up out of the resume path, it is not supposed to change anyway,
> you can even save the function pointer at probe.
>
> Again, happy to apply it as-is, just let me know please.
I just sent subsequent patch to address this:
PCI: pcie-rcar: Cache PHY init function pointer
next prev parent reply other threads:[~2020-04-26 12:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-14 19:12 [PATCH V3] PCI: rcar: Add the suspend/resume for pcie-rcar driver marek.vasut
2020-03-20 10:12 ` Lorenzo Pieralisi
2020-04-26 12:33 ` Marek Vasut [this message]
2020-04-24 11:54 ` Lorenzo Pieralisi
2020-04-24 19:57 ` Bjorn Helgaas
2020-04-25 8:55 ` Geert Uytterhoeven
2020-04-27 17:41 ` Bjorn Helgaas
2020-04-27 20:08 ` Geert Uytterhoeven
2020-04-28 8:26 ` Lorenzo Pieralisi
2020-04-28 8:33 ` Geert Uytterhoeven
2020-04-26 12:32 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=07fecbce-55f3-af8e-1887-42f7a8074b54@gmail.com \
--to=marek.vasut@gmail.com \
--cc=gaku.inami.xw@bp.renesas.com \
--cc=geert+renesas@glider.be \
--cc=horms+renesas@verge.net.au \
--cc=kaz-ikeda@xc.jp.nec.com \
--cc=linux-pci@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=marek.vasut+renesas@gmail.com \
--cc=phil.edworthy@renesas.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).