* [PATCH] PCI: keystone: Do not treat link up message as error
@ 2018-05-09 16:57 Fabio Estevam
2018-05-11 16:49 ` Murali Karicheri
2018-05-14 13:41 ` Lorenzo Pieralisi
0 siblings, 2 replies; 3+ messages in thread
From: Fabio Estevam @ 2018-05-09 16:57 UTC (permalink / raw)
To: lorenzo.pieralisi; +Cc: bhelgaas, m-karicheri2, linux-pci, Fabio Estevam
From: Fabio Estevam <fabio.estevam@nxp.com>
The "Link already up" message does not indicate any error, so
change it to dev_info() level instead.
Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
---
drivers/pci/dwc/pci-keystone.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pci/dwc/pci-keystone.c b/drivers/pci/dwc/pci-keystone.c
index d55ae07..3722a5f 100644
--- a/drivers/pci/dwc/pci-keystone.c
+++ b/drivers/pci/dwc/pci-keystone.c
@@ -89,7 +89,7 @@ static int ks_pcie_establish_link(struct keystone_pcie *ks_pcie)
dw_pcie_setup_rc(pp);
if (dw_pcie_link_up(pci)) {
- dev_err(dev, "Link already up\n");
+ dev_info(dev, "Link already up\n");
return 0;
}
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] PCI: keystone: Do not treat link up message as error
2018-05-09 16:57 [PATCH] PCI: keystone: Do not treat link up message as error Fabio Estevam
@ 2018-05-11 16:49 ` Murali Karicheri
2018-05-14 13:41 ` Lorenzo Pieralisi
1 sibling, 0 replies; 3+ messages in thread
From: Murali Karicheri @ 2018-05-11 16:49 UTC (permalink / raw)
To: Fabio Estevam, lorenzo.pieralisi; +Cc: bhelgaas, linux-pci, Fabio Estevam
On 05/09/2018 12:57 PM, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@nxp.com>
>
> The "Link already up" message does not indicate any error, so
> change it to dev_info() level instead.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
> ---
> drivers/pci/dwc/pci-keystone.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/dwc/pci-keystone.c b/drivers/pci/dwc/pci-keystone.c
> index d55ae07..3722a5f 100644
> --- a/drivers/pci/dwc/pci-keystone.c
> +++ b/drivers/pci/dwc/pci-keystone.c
> @@ -89,7 +89,7 @@ static int ks_pcie_establish_link(struct keystone_pcie *ks_pcie)
> dw_pcie_setup_rc(pp);
>
> if (dw_pcie_link_up(pci)) {
> - dev_err(dev, "Link already up\n");
> + dev_info(dev, "Link already up\n");
> return 0;
> }
>
>
Acked-by: Murali Karicheri <m-karicheri2@ti.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] PCI: keystone: Do not treat link up message as error
2018-05-09 16:57 [PATCH] PCI: keystone: Do not treat link up message as error Fabio Estevam
2018-05-11 16:49 ` Murali Karicheri
@ 2018-05-14 13:41 ` Lorenzo Pieralisi
1 sibling, 0 replies; 3+ messages in thread
From: Lorenzo Pieralisi @ 2018-05-14 13:41 UTC (permalink / raw)
To: Fabio Estevam; +Cc: bhelgaas, m-karicheri2, linux-pci, Fabio Estevam
On Wed, May 09, 2018 at 01:57:36PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@nxp.com>
>
> The "Link already up" message does not indicate any error, so
> change it to dev_info() level instead.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
> ---
> drivers/pci/dwc/pci-keystone.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied to pci/dwc for v4.18, thanks.
Lorenzo
> diff --git a/drivers/pci/dwc/pci-keystone.c b/drivers/pci/dwc/pci-keystone.c
> index d55ae07..3722a5f 100644
> --- a/drivers/pci/dwc/pci-keystone.c
> +++ b/drivers/pci/dwc/pci-keystone.c
> @@ -89,7 +89,7 @@ static int ks_pcie_establish_link(struct keystone_pcie *ks_pcie)
> dw_pcie_setup_rc(pp);
>
> if (dw_pcie_link_up(pci)) {
> - dev_err(dev, "Link already up\n");
> + dev_info(dev, "Link already up\n");
> return 0;
> }
>
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-05-14 13:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-09 16:57 [PATCH] PCI: keystone: Do not treat link up message as error Fabio Estevam
2018-05-11 16:49 ` Murali Karicheri
2018-05-14 13:41 ` Lorenzo Pieralisi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).