linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Yicong Yang <yangyicong@hisilicon.com>
To: <helgaas@kernel.org>, <linux-pci@vger.kernel.org>
Cc: <f.fangjian@huawei.com>, <huangdaode@huawei.com>
Subject: [PATCH v4 03/10] PCI: Remove PCIe suffix in pci_bus_speed_strings[]
Date: Mon, 17 Feb 2020 19:12:57 +0800	[thread overview]
Message-ID: <1581937984-40353-4-git-send-email-yangyicong@hisilicon.com> (raw)
In-Reply-To: <1581937984-40353-1-git-send-email-yangyicong@hisilicon.com>

Remove "PCIe" suffix of PCIe speed strings in
pci_bus_speed_strings[] array. For example, if we use the
array to decode link speed in __pcie_print_link_status,
it'll lead to redundancy like:
- nvme 0000:01:00.0: 16.000 Gb/s available PCIe bandwidth,
  limited by 5 GT/s x4 link at 0000:00:01.1 (capable of
  31.504 Gb/s with 8 GT/s x4 link)
+ nvme 0000:01:00.0: 16.000 Gb/s available PCIe bandwidth,
  limited by 5 GT/s PCIe x4 link at 0000:00:01.1 (capable
  of 31.504 Gb/s with 8 GT/s PCIe x4 link)

The patch introduces changes in sysfs when display
bus speed of certain slot from cur_bus_speed/max_bus_speed
in /sys/bus/pci/slots/*. It may looks like:
-/sys/bus/pci/slots/0/cur_bus_speed: 8 GT/s PCIe
+/sys/bus/pci/slots/0/cur_bus_speed: 8 GT/s
The following patch will compensate and display slot
bus speed with "PCIe" suffix as before.

[1] https://lore.kernel.org/linux-pci/20200114224909.GA19633@google.com
[2] https://lore.kernel.org/linux-pci/20200205183531.GA229621@google.com
Signed-off-by: Yicong Yang <yangyicong@hisilicon.com>
---
 drivers/pci/probe.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c
index 4e997e7..6ce47d8 100644
--- a/drivers/pci/probe.c
+++ b/drivers/pci/probe.c
@@ -700,11 +700,11 @@ const char *pci_bus_speed_strings[] = {
 	"66 MHz PCI-X 533",	/* 0x11 */
 	"100 MHz PCI-X 533",	/* 0x12 */
 	"133 MHz PCI-X 533",	/* 0x13 */
-	"2.5 GT/s PCIe",	/* 0x14 */
-	"5.0 GT/s PCIe",	/* 0x15 */
-	"8.0 GT/s PCIe",	/* 0x16 */
-	"16.0 GT/s PCIe",	/* 0x17 */
-	"32.0 GT/s PCIe",	/* 0x18 */
+	"2.5 GT/s",	/* 0x14 */
+	"5.0 GT/s",	/* 0x15 */
+	"8.0 GT/s",	/* 0x16 */
+	"16.0 GT/s",	/* 0x17 */
+	"32.0 GT/s",	/* 0x18 */
 };
 const int pci_bus_speed_strings_size = ARRAY_SIZE(pci_bus_speed_strings);
 
-- 
2.8.1


  parent reply	other threads:[~2020-02-17 11:17 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-17 11:12 [PATCH v4 00/10] Improve link speed presentation process Yicong Yang
2020-02-17 11:12 ` [PATCH v4 01/10] PCI: add 32 GT/s decoding in some macros Yicong Yang
2020-02-17 11:12 ` [PATCH v4 02/10] PCI: Make pci_bus_speed_strings[] public Yicong Yang
2020-02-17 11:12 ` Yicong Yang [this message]
2020-02-17 11:12 ` [PATCH v4 04/10] PCI: Add comments for link speed info arrays Yicong Yang
2020-02-17 11:12 ` [PATCH v4 05/10] PCI: brcmstb: Use pcie_link_speed[] to decode link speed Yicong Yang
2020-02-17 11:13 ` [PATCH v4 06/10] PCI: Refactor and rename PCIE_SPEED2STR macro Yicong Yang
2020-02-17 11:13 ` [PATCH v4 07/10] PCI: Refactor bus_speed_read() with PCI_SPEED2STR macro Yicong Yang
2020-02-17 11:13 ` [PATCH v4 08/10] PCI: Add PCIe suffix when display PCIe slot bus speed Yicong Yang
2020-02-17 11:13 ` [PATCH v4 09/10] PCI: Add PCIE_LNKCAP2_SLS2SPEED macro Yicong Yang
2020-02-17 11:13 ` [PATCH v4 10/10] PCI: Reduce redundancy in current_link_speed_show() Yicong Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1581937984-40353-4-git-send-email-yangyicong@hisilicon.com \
    --to=yangyicong@hisilicon.com \
    --cc=f.fangjian@huawei.com \
    --cc=helgaas@kernel.org \
    --cc=huangdaode@huawei.com \
    --cc=linux-pci@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).