From: Chuanjia Liu <chuanjia.liu@mediatek.com> To: Bjorn Helgaas <helgaas@kernel.org> Cc: Rob Herring <robh+dt@kernel.org>, Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>, <devicetree@vger.kernel.org>, Ryder Lee <ryder.lee@mediatek.com>, Frank Wunderlich <frank-w@public-files.de>, <linux-pci@vger.kernel.org>, Matthias Brugger <matthias.bgg@gmail.com>, <linux-mediatek@lists.infradead.org>, <yong.wu@mediatek.com>, Bjorn Helgaas <bhelgaas@google.com>, <linux-arm-kernel@lists.infradead.org> Subject: Re: [PATCH v7 4/4] ARM: dts: mediatek: Modified MT7629 PCIe node Date: Mon, 9 Nov 2020 10:54:46 +0800 Message-ID: <1604890486.8050.7.camel@mhfsdcap03> (raw) In-Reply-To: <20201103225147.GA272037@bjorn-Precision-5520> On Tue, 2020-11-03 at 16:51 -0600, Bjorn Helgaas wrote: > This subject line is pointless. > > Every patch modifies something. Give us a hint about what you > modified and why. > > And use the present tense verb, i.e., "Modify ...", not "Modified". > Probably "Add" would be better than "Modify". Or "Update" with some > meaningful description of the update. > > On Thu, Oct 29, 2020 at 04:15:13PM +0800, Chuanjia Liu wrote: > > Remove unused property and add pciecfg node. > > Apparently this also removes "subsys" from the "reg" property. > And removes an interrupt. And adds "pcie_irq". Thanks for you review,I will update my subject and commit message. ARM: dts: mediatek: Update MT7629 PCIe node To match the new DTS Binding, Remove "subsys" and unused interrupt.Add "pcie_irq" property and pciecfg node. Is that ok? > > Signed-off-by: Chuanjia Liu <chuanjia.liu@mediatek.com> > > Acked-by: Ryder Lee <ryder.lee@mediatek.com> > > --- > > arch/arm/boot/dts/mt7629-rfb.dts | 3 ++- > > arch/arm/boot/dts/mt7629.dtsi | 22 ++++++++++++---------- > > 2 files changed, 14 insertions(+), 11 deletions(-) > > > > diff --git a/arch/arm/boot/dts/mt7629-rfb.dts b/arch/arm/boot/dts/mt7629-rfb.dts > > index 9980c10c6e29..eb536cbebd9b 100644 > > --- a/arch/arm/boot/dts/mt7629-rfb.dts > > +++ b/arch/arm/boot/dts/mt7629-rfb.dts > > @@ -140,9 +140,10 @@ > > }; > > }; > > > > -&pcie { > > +&pcie1 { > > pinctrl-names = "default"; > > pinctrl-0 = <&pcie_pins>; > > + status = "okay"; > > }; > > > > &pciephy1 { > > diff --git a/arch/arm/boot/dts/mt7629.dtsi b/arch/arm/boot/dts/mt7629.dtsi > > index 5cbb3d244c75..6d6397f0c2fc 100644 > > --- a/arch/arm/boot/dts/mt7629.dtsi > > +++ b/arch/arm/boot/dts/mt7629.dtsi > > @@ -360,16 +360,20 @@ > > #reset-cells = <1>; > > }; > > > > - pcie: pcie@1a140000 { > > + pciecfg: pciecfg@1a140000 { > > + compatible = "mediatek,generic-pciecfg", "syscon"; > > + reg = <0x1a140000 0x1000>; > > + }; > > + > > + pcie1: pcie@1a145000 { > > compatible = "mediatek,mt7629-pcie"; > > device_type = "pci"; > > - reg = <0x1a140000 0x1000>, > > - <0x1a145000 0x1000>; > > - reg-names = "subsys","port1"; > > + reg = <0x1a145000 0x1000>; > > + reg-names = "port1"; > > #address-cells = <3>; > > #size-cells = <2>; > > - interrupts = <GIC_SPI 176 IRQ_TYPE_LEVEL_LOW>, > > - <GIC_SPI 229 IRQ_TYPE_LEVEL_LOW>; > > + interrupts = <GIC_SPI 229 IRQ_TYPE_LEVEL_LOW>; > > + interrupt-names = "pcie_irq"; > > clocks = <&pciesys CLK_PCIE_P1_MAC_EN>, > > <&pciesys CLK_PCIE_P0_AHB_EN>, > > <&pciesys CLK_PCIE_P1_AUX_EN>, > > @@ -390,21 +394,19 @@ > > power-domains = <&scpsys MT7622_POWER_DOMAIN_HIF0>; > > bus-range = <0x00 0xff>; > > ranges = <0x82000000 0 0x20000000 0x20000000 0 0x10000000>; > > + status = "disabled"; > > > > - pcie1: pcie@1,0 { > > - device_type = "pci"; > > + slot1: pcie@1,0 { > > reg = <0x0800 0 0 0 0>; > > #address-cells = <3>; > > #size-cells = <2>; > > #interrupt-cells = <1>; > > ranges; > > - num-lanes = <1>; > > interrupt-map-mask = <0 0 0 7>; > > interrupt-map = <0 0 0 1 &pcie_intc1 0>, > > <0 0 0 2 &pcie_intc1 1>, > > <0 0 0 3 &pcie_intc1 2>, > > <0 0 0 4 &pcie_intc1 3>; > > - > > pcie_intc1: interrupt-controller { > > interrupt-controller; > > #address-cells = <0>; > > -- > > 2.18.0 > > _______________________________________________ > > linux-arm-kernel mailing list > > linux-arm-kernel@lists.infradead.org > > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply index Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-10-29 8:15 [PATCH v7 0/4] PCI: mediatek: Spilt PCIe node to comply with hardware design Chuanjia Liu 2020-10-29 8:15 ` [PATCH v7 1/4] dt-bindings: pci: mediatek: Modified the Device tree bindings Chuanjia Liu 2020-10-29 15:34 ` Rob Herring 2020-11-09 2:44 ` Chuanjia Liu 2020-11-02 16:19 ` Rob Herring 2020-11-09 2:48 ` Chuanjia Liu 2020-11-03 22:56 ` Bjorn Helgaas 2020-11-09 3:01 ` Chuanjia Liu 2020-10-29 8:15 ` [PATCH v7 2/4] PCI: mediatek: Add new method to get shared pcie-cfg base and irq Chuanjia Liu 2020-10-29 8:15 ` [PATCH v7 3/4] arm64: dts: mediatek: Split PCIe node for MT2712 and MT7622 Chuanjia Liu 2020-10-29 8:15 ` [PATCH v7 4/4] ARM: dts: mediatek: Modified MT7629 PCIe node Chuanjia Liu 2020-11-03 22:51 ` Bjorn Helgaas 2020-11-09 2:54 ` Chuanjia Liu [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1604890486.8050.7.camel@mhfsdcap03 \ --to=chuanjia.liu@mediatek.com \ --cc=bhelgaas@google.com \ --cc=devicetree@vger.kernel.org \ --cc=frank-w@public-files.de \ --cc=helgaas@kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-mediatek@lists.infradead.org \ --cc=linux-pci@vger.kernel.org \ --cc=lorenzo.pieralisi@arm.com \ --cc=matthias.bgg@gmail.com \ --cc=robh+dt@kernel.org \ --cc=ryder.lee@mediatek.com \ --cc=yong.wu@mediatek.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Linux-PCI Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/linux-pci/0 linux-pci/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 linux-pci linux-pci/ https://lore.kernel.org/linux-pci \ linux-pci@vger.kernel.org public-inbox-index linux-pci Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.kernel.vger.linux-pci AGPL code for this site: git clone https://public-inbox.org/public-inbox.git