From: Xiaofei Tan <tanxiaofei@huawei.com> To: <rjw@rjwysocki.net>, <lenb@kernel.org>, <rui.zhang@intel.com>, <bhelgaas@google.com> Cc: Xiaofei Tan <tanxiaofei@huawei.com>, <linux-acpi@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <linux-pci@vger.kernel.org>, <linuxarm@openeuler.org> Subject: [PATCH 03/15] ACPI: acpi_dbg: fix some coding style issues Date: Sat, 27 Mar 2021 14:40:44 +0800 [thread overview] Message-ID: <1616827256-51840-4-git-send-email-tanxiaofei@huawei.com> (raw) In-Reply-To: <1616827256-51840-1-git-send-email-tanxiaofei@huawei.com> Fix some coding style issues reported by checkpatch.pl, including following types: WARNING: space prohibited between function name and open parenthesis WARNING: else is not generally useful after a break or return Signed-off-by: Xiaofei Tan <tanxiaofei@huawei.com> --- drivers/acpi/acpi_dbg.c | 40 +++++++++++++++++++--------------------- 1 file changed, 19 insertions(+), 21 deletions(-) diff --git a/drivers/acpi/acpi_dbg.c b/drivers/acpi/acpi_dbg.c index d50261d..e641bc1 100644 --- a/drivers/acpi/acpi_dbg.c +++ b/drivers/acpi/acpi_dbg.c @@ -21,7 +21,7 @@ #include <linux/acpi.h> #include "internal.h" -#define ACPI_AML_BUF_ALIGN (sizeof (acpi_size)) +#define ACPI_AML_BUF_ALIGN (sizeof(acpi_size)) #define ACPI_AML_BUF_SIZE PAGE_SIZE #define circ_count(circ) \ @@ -613,16 +613,15 @@ static ssize_t acpi_aml_read(struct file *file, char __user *buf, if (ret == -EAGAIN) { if (file->f_flags & O_NONBLOCK) break; - else { - ret = wait_event_interruptible(acpi_aml_io.wait, - acpi_aml_user_readable()); - /* - * We need to retry when the condition - * becomes true. - */ - if (ret == 0) - goto again; - } + + ret = wait_event_interruptible(acpi_aml_io.wait, + acpi_aml_user_readable()); + /* + * We need to retry when the condition + * becomes true. + */ + if (ret == 0) + goto again; } if (ret < 0) { if (!acpi_aml_running()) @@ -683,16 +682,15 @@ static ssize_t acpi_aml_write(struct file *file, const char __user *buf, if (ret == -EAGAIN) { if (file->f_flags & O_NONBLOCK) break; - else { - ret = wait_event_interruptible(acpi_aml_io.wait, - acpi_aml_user_writable()); - /* - * We need to retry when the condition - * becomes true. - */ - if (ret == 0) - goto again; - } + + ret = wait_event_interruptible(acpi_aml_io.wait, + acpi_aml_user_writable()); + /* + * We need to retry when the condition + * becomes true. + */ + if (ret == 0) + goto again; } if (ret < 0) { if (!acpi_aml_running()) -- 2.8.1
next prev parent reply other threads:[~2021-03-27 6:44 UTC|newest] Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-03-27 6:40 [PATCH 00/15] acpi: " Xiaofei Tan 2021-03-27 6:40 ` [PATCH 01/15] ACPI: APD: fix a block comment align issue Xiaofei Tan 2021-03-27 6:40 ` [PATCH 02/15] ACPI: processor: fix some coding style issues Xiaofei Tan 2021-03-27 6:40 ` Xiaofei Tan [this message] 2021-03-27 6:40 ` [PATCH 04/15] ACPI: acpi_fpdt: replace __attribute__((packed)) by __packed Xiaofei Tan 2021-03-27 6:40 ` [PATCH 05/15] remove useless return statement for void function Xiaofei Tan 2021-03-27 6:49 ` Xiaofei Tan 2021-03-27 6:40 ` [PATCH 06/15] ACPI: acpi_lpss: fix some coding style issues Xiaofei Tan 2021-03-27 8:41 ` kernel test robot 2021-03-27 6:40 ` [PATCH 07/15] ACPI: acpi_memhotplug: fix a coding style issue Xiaofei Tan 2021-03-27 6:40 ` [PATCH 08/15] ACPI: acpi_pad: " Xiaofei Tan 2021-03-27 6:40 ` [PATCH 09/15] ACPI: battery: fix some coding style issues Xiaofei Tan 2021-03-27 6:40 ` [PATCH 10/15] ACPI: button: " Xiaofei Tan 2021-03-27 6:40 ` [PATCH 11/15] ACPI: cppc_acpi: " Xiaofei Tan 2021-03-27 6:40 ` [PATCH 12/15] ACPI: custom_method: fix a coding style issue Xiaofei Tan 2021-03-27 6:40 ` [PATCH 13/15] ACPI: device_pm: fix some coding style issues Xiaofei Tan 2021-03-27 6:40 ` [PATCH 14/15] ACPI: device_sysfs: " Xiaofei Tan 2021-03-27 6:40 ` [PATCH 15/15] ACPI: dock: " Xiaofei Tan 2021-03-27 7:20 ` [PATCH 00/15] acpi: " Xiaofei Tan
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1616827256-51840-4-git-send-email-tanxiaofei@huawei.com \ --to=tanxiaofei@huawei.com \ --cc=bhelgaas@google.com \ --cc=lenb@kernel.org \ --cc=linux-acpi@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pci@vger.kernel.org \ --cc=linuxarm@openeuler.org \ --cc=rjw@rjwysocki.net \ --cc=rui.zhang@intel.com \ --subject='Re: [PATCH 03/15] ACPI: acpi_dbg: fix some coding style issues' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).