* [PATCH] PCI: microchip: Make the struct event_descs static
@ 2021-05-09 4:19 Krzysztof Wilczyński
2021-06-03 16:12 ` Lorenzo Pieralisi
0 siblings, 1 reply; 2+ messages in thread
From: Krzysztof Wilczyński @ 2021-05-09 4:19 UTC (permalink / raw)
To: Bjorn Helgaas; +Cc: Lorenzo Pieralisi, Daire McNamara, Rob Herring, linux-pci
The struct event_descs does not have any users outside the
pcie-microchip-host.c file, and has no previous declaration,
thus it can be made static.
This resolves the following sparse warning:
drivers/pci/controller/pcie-microchip-host.c:352:3: warning: symbol 'event_descs' was not declared. Should it be static?
Signed-off-by: Krzysztof Wilczyński <kw@linux.com>
---
drivers/pci/controller/pcie-microchip-host.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pci/controller/pcie-microchip-host.c b/drivers/pci/controller/pcie-microchip-host.c
index 89c68c56d93b..fdab8202ae5d 100644
--- a/drivers/pci/controller/pcie-microchip-host.c
+++ b/drivers/pci/controller/pcie-microchip-host.c
@@ -341,7 +341,7 @@ static struct event_map local_status_to_event[] = {
LOCAL_STATUS_TO_EVENT_MAP(PM_MSI_INT_SYS_ERR),
};
-struct {
+static struct {
u32 base;
u32 offset;
u32 mask;
--
2.31.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] PCI: microchip: Make the struct event_descs static
2021-05-09 4:19 [PATCH] PCI: microchip: Make the struct event_descs static Krzysztof Wilczyński
@ 2021-06-03 16:12 ` Lorenzo Pieralisi
0 siblings, 0 replies; 2+ messages in thread
From: Lorenzo Pieralisi @ 2021-06-03 16:12 UTC (permalink / raw)
To: Bjorn Helgaas, Krzysztof Wilczyński
Cc: Lorenzo Pieralisi, linux-pci, Rob Herring, Daire McNamara
On Sun, 9 May 2021 04:19:32 +0000, Krzysztof Wilczyński wrote:
> The struct event_descs does not have any users outside the
> pcie-microchip-host.c file, and has no previous declaration,
> thus it can be made static.
>
> This resolves the following sparse warning:
>
> drivers/pci/controller/pcie-microchip-host.c:352:3: warning: symbol 'event_descs' was not declared. Should it be static?
Applied to pci/microchip, thanks!
[1/1] PCI: microchip: Make the struct event_descs static
https://git.kernel.org/lpieralisi/pci/c/1243106474
Thanks,
Lorenzo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-06-03 16:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-09 4:19 [PATCH] PCI: microchip: Make the struct event_descs static Krzysztof Wilczyński
2021-06-03 16:12 ` Lorenzo Pieralisi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).