From: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
To: bhelgaas@google.com, toan@os.amperecomputing.com,
robh@kernel.org, ErKun Yang <yangerkun@huawei.com>
Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
yukuai3@huawei.com, linux-pci@vger.kernel.org
Subject: Re: [PATCH v2] PCI: xgene-msi: Remove redundant dev_err call in xgene_msi_probe()
Date: Thu, 5 Aug 2021 12:12:04 +0100 [thread overview]
Message-ID: <162816190524.30159.389276372936290977.b4-ty@arm.com> (raw)
In-Reply-To: <20210408132751.1198171-1-yangerkun@huawei.com>
On Thu, 8 Apr 2021 21:27:51 +0800, ErKun Yang wrote:
> devm_ioremap_resource() internally calls __devm_ioremap_resource() which
> is where error checking and handling is actually having place. So the
> dev_err in xgene_msi_probe() seems redundant and remove it.
Applied to pci/xgene, thanks!
[1/1] PCI: xgene-msi: Remove redundant dev_err() call in xgene_msi_probe()
https://git.kernel.org/lpieralisi/pci/c/9e4ae52cab
Thanks,
Lorenzo
prev parent reply other threads:[~2021-08-05 11:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-08 13:27 [PATCH v2] PCI: xgene-msi: Remove redundant dev_err call in xgene_msi_probe() ErKun Yang
2021-04-08 13:21 ` ErKun Yang
2021-05-27 13:33 ` yangerkun
2021-08-05 11:12 ` Lorenzo Pieralisi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=162816190524.30159.389276372936290977.b4-ty@arm.com \
--to=lorenzo.pieralisi@arm.com \
--cc=bhelgaas@google.com \
--cc=linux-pci@vger.kernel.org \
--cc=robh@kernel.org \
--cc=toan@os.amperecomputing.com \
--cc=yangerkun@huawei.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).