* [PATCH v1 0/7] Add the iMX8MP PCIe support
@ 2022-03-07 6:29 Richard Zhu
2022-03-07 6:29 ` [PATCH v1 1/7] reset: imx7: Add the iMX8MP PCIe PHY PERST support Richard Zhu
` (6 more replies)
0 siblings, 7 replies; 11+ messages in thread
From: Richard Zhu @ 2022-03-07 6:29 UTC (permalink / raw)
To: p.zabel, l.stach, bhelgaas, lorenzo.pieralisi, robh, shawnguo
Cc: devicetree, linux-pci, linux-arm-kernel, linux-kernel, kernel, linux-imx
Based on the i.MX8MP GPC and blk-ctrl patch-set [1] issued by Lucas.
This series patches add the i.MX8MP PCIe support.
- i.MX8MP PCIe PHY has two resets refer to the i.MX8MM PCIe PHY.
Add one more PHY reset for i.MX8MP PCIe PHY accordingly.
- Add the i.MX8MP PCIe PHY support in the i.MX8M PCIe PHY driver.
And share as much as possible codes with i.MX8MM PCIe PHY.
- Add the i.MX8MP PCIe support in binding document, DTS files, and PCIe
driver.
Clean up some debug codes, re-send the v1 patch-set.
[1]:https://patchwork.kernel.org/project/linux-arm-kernel/cover/20220228201731.3330192-1-l.stach@pengutronix.de/
Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml | 1 +
Documentation/devicetree/bindings/phy/fsl,imx8-pcie-phy.yaml | 4 +-
arch/arm64/boot/dts/freescale/imx8mp-evk.dts | 55 ++++++++++++++++++
arch/arm64/boot/dts/freescale/imx8mp.dtsi | 46 +++++++++++++++-
drivers/pci/controller/dwc/pci-imx6.c | 19 ++++++-
drivers/phy/freescale/phy-fsl-imx8m-pcie.c | 248 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++---------------
drivers/reset/reset-imx7.c | 1 +
7 files changed, 327 insertions(+), 47 deletions(-)
[PATCH v1 1/7] reset: imx7: Add the iMX8MP PCIe PHY PERST support
[PATCH v1 2/7] dt-binding: phy: Add iMX8MP PCIe PHY binding
[PATCH v1 3/7] phy: freescale: imx8m-pcie: Add iMX8MP PCIe PHY
[PATCH v1 4/7] dt-bindings: imx6q-pcie: Add iMX8MP PCIe compatible
[PATCH v1 5/7] arm64: dts: imx8mp: add the iMX8MP PCIe support
[PATCH v1 6/7] arm64: dts: imx8mp-evk: Add PCIe support
[PATCH v1 7/7] PCI: imx6: Add the iMX8MP PCIe support
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH v1 1/7] reset: imx7: Add the iMX8MP PCIe PHY PERST support
2022-03-07 6:29 [PATCH v1 0/7] Add the iMX8MP PCIe support Richard Zhu
@ 2022-03-07 6:29 ` Richard Zhu
2022-03-07 6:29 ` [PATCH v1 2/7] dt-binding: phy: Add iMX8MP PCIe PHY binding Richard Zhu
` (5 subsequent siblings)
6 siblings, 0 replies; 11+ messages in thread
From: Richard Zhu @ 2022-03-07 6:29 UTC (permalink / raw)
To: p.zabel, l.stach, bhelgaas, lorenzo.pieralisi, robh, shawnguo
Cc: devicetree, linux-pci, linux-arm-kernel, linux-kernel, kernel,
linux-imx, Richard Zhu
Add the i.MX8MP PCIe PHY PERST support.
Signed-off-by: Richard Zhu <hongxing.zhu@nxp.com>
---
drivers/reset/reset-imx7.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/reset/reset-imx7.c b/drivers/reset/reset-imx7.c
index 185a333df66c..d2408725eb2c 100644
--- a/drivers/reset/reset-imx7.c
+++ b/drivers/reset/reset-imx7.c
@@ -329,6 +329,7 @@ static int imx8mp_reset_set(struct reset_controller_dev *rcdev,
break;
case IMX8MP_RESET_PCIE_CTRL_APPS_EN:
+ case IMX8MP_RESET_PCIEPHY_PERST:
value = assert ? 0 : bit;
break;
}
--
2.25.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH v1 2/7] dt-binding: phy: Add iMX8MP PCIe PHY binding
2022-03-07 6:29 [PATCH v1 0/7] Add the iMX8MP PCIe support Richard Zhu
2022-03-07 6:29 ` [PATCH v1 1/7] reset: imx7: Add the iMX8MP PCIe PHY PERST support Richard Zhu
@ 2022-03-07 6:29 ` Richard Zhu
2022-03-07 6:29 ` [PATCH v1 3/7] phy: freescale: imx8m-pcie: Add iMX8MP PCIe PHY support Richard Zhu
` (4 subsequent siblings)
6 siblings, 0 replies; 11+ messages in thread
From: Richard Zhu @ 2022-03-07 6:29 UTC (permalink / raw)
To: p.zabel, l.stach, bhelgaas, lorenzo.pieralisi, robh, shawnguo
Cc: devicetree, linux-pci, linux-arm-kernel, linux-kernel, kernel,
linux-imx, Richard Zhu
Add i.MX8MP PCIe PHY binding.
Signed-off-by: Richard Zhu <hongxing.zhu@nxp.com>
---
Documentation/devicetree/bindings/phy/fsl,imx8-pcie-phy.yaml | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/phy/fsl,imx8-pcie-phy.yaml b/Documentation/devicetree/bindings/phy/fsl,imx8-pcie-phy.yaml
index b6421eedece3..3646b3ed4375 100644
--- a/Documentation/devicetree/bindings/phy/fsl,imx8-pcie-phy.yaml
+++ b/Documentation/devicetree/bindings/phy/fsl,imx8-pcie-phy.yaml
@@ -16,6 +16,7 @@ properties:
compatible:
enum:
- fsl,imx8mm-pcie-phy
+ - fsl,imx8mp-pcie-phy
reg:
maxItems: 1
@@ -28,11 +29,12 @@ properties:
- const: ref
resets:
- maxItems: 1
+ maxItems: 2
reset-names:
items:
- const: pciephy
+ - const: perst
fsl,refclk-pad-mode:
description: |
--
2.25.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH v1 3/7] phy: freescale: imx8m-pcie: Add iMX8MP PCIe PHY support
2022-03-07 6:29 [PATCH v1 0/7] Add the iMX8MP PCIe support Richard Zhu
2022-03-07 6:29 ` [PATCH v1 1/7] reset: imx7: Add the iMX8MP PCIe PHY PERST support Richard Zhu
2022-03-07 6:29 ` [PATCH v1 2/7] dt-binding: phy: Add iMX8MP PCIe PHY binding Richard Zhu
@ 2022-03-07 6:29 ` Richard Zhu
2022-03-07 6:29 ` [PATCH v1 4/7] dt-bindings: imx6q-pcie: Add iMX8MP PCIe compatible string Richard Zhu
` (3 subsequent siblings)
6 siblings, 0 replies; 11+ messages in thread
From: Richard Zhu @ 2022-03-07 6:29 UTC (permalink / raw)
To: p.zabel, l.stach, bhelgaas, lorenzo.pieralisi, robh, shawnguo
Cc: devicetree, linux-pci, linux-arm-kernel, linux-kernel, kernel,
linux-imx, Richard Zhu
Add the i.MX8MP PCIe PHY support
Signed-off-by: Richard Zhu <hongxing.zhu@nxp.com>
---
drivers/phy/freescale/phy-fsl-imx8m-pcie.c | 248 +++++++++++++++++----
1 file changed, 204 insertions(+), 44 deletions(-)
diff --git a/drivers/phy/freescale/phy-fsl-imx8m-pcie.c b/drivers/phy/freescale/phy-fsl-imx8m-pcie.c
index 04b1aafb29f4..fbaec72d9143 100644
--- a/drivers/phy/freescale/phy-fsl-imx8m-pcie.c
+++ b/drivers/phy/freescale/phy-fsl-imx8m-pcie.c
@@ -11,12 +11,16 @@
#include <linux/mfd/syscon.h>
#include <linux/mfd/syscon/imx7-iomuxc-gpr.h>
#include <linux/module.h>
+#include <linux/of_address.h>
+#include <linux/of_device.h>
#include <linux/phy/phy.h>
#include <linux/platform_device.h>
#include <linux/regmap.h>
#include <linux/reset.h>
#include <dt-bindings/phy/phy-imx8-pcie.h>
+#define IMX8MM_PCIE_PHY_CMN_REG020 0x80
+#define PLL_ANA_LPF_R_SEL_FINE_0_4 0x04
#define IMX8MM_PCIE_PHY_CMN_REG061 0x184
#define ANA_PLL_CLK_OUT_TO_EXT_IO_EN BIT(0)
#define IMX8MM_PCIE_PHY_CMN_REG062 0x188
@@ -30,12 +34,47 @@
#define IMX8MM_PCIE_PHY_CMN_REG065 0x194
#define ANA_AUX_RX_TERM (BIT(7) | BIT(4))
#define ANA_AUX_TX_LVL GENMASK(3, 0)
-#define IMX8MM_PCIE_PHY_CMN_REG75 0x1D4
-#define PCIE_PHY_CMN_REG75_PLL_DONE 0x3
-#define PCIE_PHY_TRSV_REG5 0x414
-#define PCIE_PHY_TRSV_REG5_GEN1_DEEMP 0x2D
-#define PCIE_PHY_TRSV_REG6 0x418
-#define PCIE_PHY_TRSV_REG6_GEN2_DEEMP 0xF
+#define IMX8MM_PCIE_PHY_CMN_REG075 0x1D4
+#define ANA_PLL_DONE 0x3
+#define IMX8MM_PCIE_PHY_CMN_REG076 0x200
+#define LANE_RESET_MUX_SEL 0x00
+#define IMX8MM_PCIE_PHY_CMN_REG078 0x208
+#define LANE_TX_DATA_CLK_MUX_SEL 0x00
+
+#define PCIE_PHY_TRSV_REG001 0x404
+#define LN0_OVRD_TX_DRV_LVL_G1 0x3F
+#define PCIE_PHY_TRSV_REG002 0x408
+#define LN0_OVRD_TX_DRV_LVL_G2 0x1F
+#define PCIE_PHY_TRSV_REG003 0x40C
+#define LN0_OVRD_TX_DRV_LVL_G3 0x1F
+#define PCIE_PHY_TRSV_REG005 0x414
+#define LN0_OVRD_TX_DRV_PST_LVL_G1 0x2B
+#define PCIE_PHY_TRSV_REG006 0x418
+#define LN0_OVRD_TX_DRV_PST_LVL_G2 0xB
+#define PCIE_PHY_TRSV_REG007 0x41C
+#define LN0_OVRD_TX_DRV_PST_LVL_G3 0xB
+#define PCIE_PHY_TRSV_REG009 0x424
+#define LN0_OVRD_TX_DRV_PRE_LVL_G1 0x15
+#define PCIE_PHY_TRSV_REG00A 0x428
+#define LN0_OVRD_TX_DRV_PRE_LVL_G23 0x55
+#define PCIE_PHY_TRSV_REG059 0x4EC
+#define LN0_OVRD_RX_CTLE_RS1_G1 0x13
+#define PCIE_PHY_TRSV_REG060 0x4F0
+#define LN0_OVRD_RX_CTLE_RS1_G2_G3 0x25
+#define PCIE_PHY_TRSV_REG069 0x514
+#define LN0_ANA_RX_CTLE_IBLEED 0x7
+#define PCIE_PHY_TRSV_REG107 0x5AC
+#define LN0_OVRD_RX_RTERM_VCM_EN 0xB8
+#define PCIE_PHY_TRSV_REG109 0x5B4
+#define LN0_ANA_OVRD_RX_SQHS_DIFN_OC 0xD4
+#define PCIE_PHY_TRSV_REG110 0x5B8
+#define LN0_ANA_OVRD_RX_SQHS_DIFP_OC 0x6A
+#define PCIE_PHY_TRSV_REG158 0x678
+#define LN0_RX_CDR_FBB_FINE_G1_G2 0x55
+#define PCIE_PHY_TRSV_REG159 0x67C
+#define LN0_RX_CDR_FBB_FINE_G3_G4 0x53
+#define PCIE_PHY_TRSV_REG206 0x738
+#define LN0_TG_RX_SIGVAL_LBF_DELAY 0x4
#define IMX8MM_GPR_PCIE_REF_CLK_SEL GENMASK(25, 24)
#define IMX8MM_GPR_PCIE_REF_CLK_PLL FIELD_PREP(IMX8MM_GPR_PCIE_REF_CLK_SEL, 0x3)
@@ -46,16 +85,43 @@
#define IMX8MM_GPR_PCIE_SSC_EN BIT(16)
#define IMX8MM_GPR_PCIE_AUX_EN_OVERRIDE BIT(9)
+#define IMX8MP_GPR_REG0 0x0
+#define IMX8MP_GPR_CLK_MOD_EN BIT(0)
+#define IMX8MP_GPR_PHY_APB_RST BIT(4)
+#define IMX8MP_GPR_PHY_INIT_RST BIT(5)
+#define IMX8MP_GPR_REG1 0x4
+#define IMX8MP_GPR_PM_EN_CORE_CLK BIT(0)
+#define IMX8MP_GPR_PLL_LOCK BIT(13)
+#define IMX8MP_GPR_REG2 0x8
+#define IMX8MP_GPR_P_PLL_MASK GENMASK(5, 0)
+#define IMX8MP_GPR_M_PLL_MASK GENMASK(15, 6)
+#define IMX8MP_GPR_S_PLL_MASK GENMASK(18, 16)
+#define IMX8MP_GPR_P_PLL (0xc << 0)
+#define IMX8MP_GPR_M_PLL (0x320 << 6)
+#define IMX8MP_GPR_S_PLL (0x4 << 16)
+#define IMX8MP_GPR_REG3 0xc
+#define IMX8MP_GPR_PLL_CKE BIT(17)
+#define IMX8MP_GPR_PLL_RST BIT(31)
+
+enum imx8_pcie_phy_type {
+ IMX8MM,
+ IMX8MP,
+};
+
struct imx8_pcie_phy {
void __iomem *base;
+ struct device *dev;
struct clk *clk;
struct phy *phy;
+ struct regmap *hsio_blk_ctrl;
struct regmap *iomuxc_gpr;
struct reset_control *reset;
+ struct reset_control *perst;
u32 refclk_pad_mode;
u32 tx_deemph_gen1;
u32 tx_deemph_gen2;
bool clkreq_unused;
+ enum imx8_pcie_phy_type variant;
};
static int imx8_pcie_phy_init(struct phy *phy)
@@ -67,6 +133,87 @@ static int imx8_pcie_phy_init(struct phy *phy)
reset_control_assert(imx8_phy->reset);
pad_mode = imx8_phy->refclk_pad_mode;
+ switch (imx8_phy->variant) {
+ case IMX8MM:
+ /* Tune PHY de-emphasis setting to pass PCIe compliance. */
+ if (imx8_phy->tx_deemph_gen1)
+ writel(imx8_phy->tx_deemph_gen1,
+ imx8_phy->base + PCIE_PHY_TRSV_REG005);
+ if (imx8_phy->tx_deemph_gen2)
+ writel(imx8_phy->tx_deemph_gen2,
+ imx8_phy->base + PCIE_PHY_TRSV_REG006);
+ break;
+ case IMX8MP:
+ reset_control_assert(imx8_phy->perst);
+ /* Set P=12,M=800,S=4 and must set ICP=2'b01. */
+ regmap_update_bits(imx8_phy->hsio_blk_ctrl, IMX8MP_GPR_REG2,
+ IMX8MP_GPR_P_PLL_MASK |
+ IMX8MP_GPR_M_PLL_MASK |
+ IMX8MP_GPR_S_PLL_MASK,
+ IMX8MP_GPR_P_PLL |
+ IMX8MP_GPR_M_PLL |
+ IMX8MP_GPR_S_PLL);
+ /* wait greater than 1/F_FREF =1/2MHZ=0.5us */
+ udelay(1);
+
+ regmap_update_bits(imx8_phy->hsio_blk_ctrl, IMX8MP_GPR_REG3,
+ IMX8MP_GPR_PLL_RST,
+ IMX8MP_GPR_PLL_RST);
+ udelay(10);
+
+ /* Set 1 to pll_cke of GPR_REG3 */
+ regmap_update_bits(imx8_phy->hsio_blk_ctrl, IMX8MP_GPR_REG3,
+ IMX8MP_GPR_PLL_CKE,
+ IMX8MP_GPR_PLL_CKE);
+
+ /* Lock time should be greater than 300cycle=300*0.5us=150us */
+ ret = regmap_read_poll_timeout(imx8_phy->hsio_blk_ctrl,
+ IMX8MP_GPR_REG1, val,
+ val & IMX8MP_GPR_PLL_LOCK,
+ 10, 1000);
+ if (ret) {
+ dev_err(imx8_phy->dev, "PCIe PLL lock timeout\n");
+ return ret;
+ }
+
+ /* pcie_clock_module_en */
+ regmap_update_bits(imx8_phy->hsio_blk_ctrl, IMX8MP_GPR_REG0,
+ IMX8MP_GPR_CLK_MOD_EN,
+ IMX8MP_GPR_CLK_MOD_EN);
+ udelay(10);
+
+ reset_control_deassert(imx8_phy->reset);
+ reset_control_deassert(imx8_phy->perst);
+
+ /* release pcie_phy_apb_reset and pcie_phy_init_resetn */
+ regmap_update_bits(imx8_phy->hsio_blk_ctrl, IMX8MP_GPR_REG0,
+ IMX8MP_GPR_PHY_APB_RST |
+ IMX8MP_GPR_PHY_INIT_RST,
+ IMX8MP_GPR_PHY_APB_RST |
+ IMX8MP_GPR_PHY_INIT_RST);
+ break;
+ }
+
+ if (pad_mode == IMX8_PCIE_REFCLK_PAD_INPUT) {
+ /* Configure the pad as input */
+ val = readl(imx8_phy->base + IMX8MM_PCIE_PHY_CMN_REG061);
+ writel(val & ~ANA_PLL_CLK_OUT_TO_EXT_IO_EN,
+ imx8_phy->base + IMX8MM_PCIE_PHY_CMN_REG061);
+ } else if (pad_mode == IMX8_PCIE_REFCLK_PAD_OUTPUT) {
+ /* Configure the PHY to output the refclock via pad */
+ writel(ANA_PLL_CLK_OUT_TO_EXT_IO_EN,
+ imx8_phy->base + IMX8MM_PCIE_PHY_CMN_REG061);
+ writel(ANA_PLL_CLK_OUT_TO_EXT_IO_SEL,
+ imx8_phy->base + IMX8MM_PCIE_PHY_CMN_REG062);
+ writel(AUX_PLL_REFCLK_SEL_SYS_PLL,
+ imx8_phy->base + IMX8MM_PCIE_PHY_CMN_REG063);
+ val = ANA_AUX_RX_TX_SEL_TX | ANA_AUX_TX_TERM;
+ writel(val | ANA_AUX_RX_TERM_GND_EN,
+ imx8_phy->base + IMX8MM_PCIE_PHY_CMN_REG064);
+ writel(ANA_AUX_RX_TERM | ANA_AUX_TX_LVL,
+ imx8_phy->base + IMX8MM_PCIE_PHY_CMN_REG065);
+ }
+
/* Set AUX_EN_OVERRIDE 1'b0, when the CLKREQ# isn't hooked */
regmap_update_bits(imx8_phy->iomuxc_gpr, IOMUXC_GPR14,
IMX8MM_GPR_PCIE_AUX_EN_OVERRIDE,
@@ -91,42 +238,30 @@ static int imx8_pcie_phy_init(struct phy *phy)
regmap_update_bits(imx8_phy->iomuxc_gpr, IOMUXC_GPR14,
IMX8MM_GPR_PCIE_CMN_RST,
IMX8MM_GPR_PCIE_CMN_RST);
- usleep_range(200, 500);
- if (pad_mode == IMX8_PCIE_REFCLK_PAD_INPUT) {
- /* Configure the pad as input */
- val = readl(imx8_phy->base + IMX8MM_PCIE_PHY_CMN_REG061);
- writel(val & ~ANA_PLL_CLK_OUT_TO_EXT_IO_EN,
- imx8_phy->base + IMX8MM_PCIE_PHY_CMN_REG061);
- } else if (pad_mode == IMX8_PCIE_REFCLK_PAD_OUTPUT) {
- /* Configure the PHY to output the refclock via pad */
- writel(ANA_PLL_CLK_OUT_TO_EXT_IO_EN,
- imx8_phy->base + IMX8MM_PCIE_PHY_CMN_REG061);
- writel(ANA_PLL_CLK_OUT_TO_EXT_IO_SEL,
- imx8_phy->base + IMX8MM_PCIE_PHY_CMN_REG062);
- writel(AUX_PLL_REFCLK_SEL_SYS_PLL,
- imx8_phy->base + IMX8MM_PCIE_PHY_CMN_REG063);
- val = ANA_AUX_RX_TX_SEL_TX | ANA_AUX_TX_TERM;
- writel(val | ANA_AUX_RX_TERM_GND_EN,
- imx8_phy->base + IMX8MM_PCIE_PHY_CMN_REG064);
- writel(ANA_AUX_RX_TERM | ANA_AUX_TX_LVL,
- imx8_phy->base + IMX8MM_PCIE_PHY_CMN_REG065);
+ switch (imx8_phy->variant) {
+ case IMX8MM:
+ reset_control_deassert(imx8_phy->reset);
+ usleep_range(200, 500);
+ break;
+
+ case IMX8MP:
+ /* wait for core_clk enabled */
+ ret = regmap_read_poll_timeout(imx8_phy->hsio_blk_ctrl,
+ IMX8MP_GPR_REG1, val,
+ val & IMX8MP_GPR_PM_EN_CORE_CLK,
+ 10, 20000);
+ if (ret) {
+ dev_err(imx8_phy->dev, "PCIe CORE CLK enable failed\n");
+ return ret;
+ }
+
+ break;
}
- /* Tune PHY de-emphasis setting to pass PCIe compliance. */
- if (imx8_phy->tx_deemph_gen1)
- writel(imx8_phy->tx_deemph_gen1,
- imx8_phy->base + PCIE_PHY_TRSV_REG5);
- if (imx8_phy->tx_deemph_gen2)
- writel(imx8_phy->tx_deemph_gen2,
- imx8_phy->base + PCIE_PHY_TRSV_REG6);
-
- reset_control_deassert(imx8_phy->reset);
-
/* Polling to check the phy is ready or not. */
- ret = readl_poll_timeout(imx8_phy->base + IMX8MM_PCIE_PHY_CMN_REG75,
- val, val == PCIE_PHY_CMN_REG75_PLL_DONE,
- 10, 20000);
+ ret = readl_poll_timeout(imx8_phy->base + IMX8MM_PCIE_PHY_CMN_REG075,
+ val, val == ANA_PLL_DONE, 10, 20000);
return ret;
}
@@ -153,18 +288,33 @@ static const struct phy_ops imx8_pcie_phy_ops = {
.owner = THIS_MODULE,
};
+static const struct of_device_id imx8_pcie_phy_of_match[] = {
+ {.compatible = "fsl,imx8mm-pcie-phy", .data = (void *)IMX8MM},
+ {.compatible = "fsl,imx8mp-pcie-phy", .data = (void *)IMX8MP},
+ { },
+};
+MODULE_DEVICE_TABLE(of, imx8_pcie_phy_of_match);
+
static int imx8_pcie_phy_probe(struct platform_device *pdev)
{
struct phy_provider *phy_provider;
struct device *dev = &pdev->dev;
+ const struct of_device_id *of_id;
struct device_node *np = dev->of_node;
struct imx8_pcie_phy *imx8_phy;
struct resource *res;
+ of_id = of_match_device(imx8_pcie_phy_of_match, dev);
+ if (!of_id)
+ return -EINVAL;
+
imx8_phy = devm_kzalloc(dev, sizeof(*imx8_phy), GFP_KERNEL);
if (!imx8_phy)
return -ENOMEM;
+ imx8_phy->dev = dev;
+ imx8_phy->variant = (enum imx8_pcie_phy_type)of_id->data;
+
/* get PHY refclk pad mode */
of_property_read_u32(np, "fsl,refclk-pad-mode",
&imx8_phy->refclk_pad_mode);
@@ -201,6 +351,22 @@ static int imx8_pcie_phy_probe(struct platform_device *pdev)
dev_err(dev, "Failed to get PCIEPHY reset control\n");
return PTR_ERR(imx8_phy->reset);
}
+ if (imx8_phy->variant == IMX8MP) {
+ /* Grab HSIO MIX config register range */
+ imx8_phy->hsio_blk_ctrl =
+ syscon_regmap_lookup_by_compatible("fsl,imx8mp-hsio-blk-ctrl");
+ if (IS_ERR(imx8_phy->hsio_blk_ctrl)) {
+ dev_err(dev, "unable to find hsio mix registers\n");
+ return PTR_ERR(imx8_phy->hsio_blk_ctrl);
+ }
+
+ imx8_phy->perst =
+ devm_reset_control_get_exclusive(dev, "perst");
+ if (IS_ERR(imx8_phy->perst)) {
+ dev_err(dev, "Failed to get PCIEPHY perst control\n");
+ return PTR_ERR(imx8_phy->perst);
+ }
+ }
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
imx8_phy->base = devm_ioremap_resource(dev, res);
@@ -218,12 +384,6 @@ static int imx8_pcie_phy_probe(struct platform_device *pdev)
return PTR_ERR_OR_ZERO(phy_provider);
}
-static const struct of_device_id imx8_pcie_phy_of_match[] = {
- {.compatible = "fsl,imx8mm-pcie-phy",},
- { },
-};
-MODULE_DEVICE_TABLE(of, imx8_pcie_phy_of_match);
-
static struct platform_driver imx8_pcie_phy_driver = {
.probe = imx8_pcie_phy_probe,
.driver = {
--
2.25.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH v1 4/7] dt-bindings: imx6q-pcie: Add iMX8MP PCIe compatible string
2022-03-07 6:29 [PATCH v1 0/7] Add the iMX8MP PCIe support Richard Zhu
` (2 preceding siblings ...)
2022-03-07 6:29 ` [PATCH v1 3/7] phy: freescale: imx8m-pcie: Add iMX8MP PCIe PHY support Richard Zhu
@ 2022-03-07 6:29 ` Richard Zhu
2022-03-07 8:02 ` (EXT) " Alexander Stein
2022-03-07 6:29 ` [PATCH v1 5/7] arm64: dts: imx8mp: add the iMX8MP PCIe support Richard Zhu
` (2 subsequent siblings)
6 siblings, 1 reply; 11+ messages in thread
From: Richard Zhu @ 2022-03-07 6:29 UTC (permalink / raw)
To: p.zabel, l.stach, bhelgaas, lorenzo.pieralisi, robh, shawnguo
Cc: devicetree, linux-pci, linux-arm-kernel, linux-kernel, kernel,
linux-imx, Richard Zhu
Add i.MX8MP PCIe compatible string.
Signed-off-by: Richard Zhu <hongxing.zhu@nxp.com>
---
Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml
index 36c8a06d17a0..252e5b72aee0 100644
--- a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml
+++ b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml
@@ -26,6 +26,7 @@ properties:
- fsl,imx7d-pcie
- fsl,imx8mq-pcie
- fsl,imx8mm-pcie
+ - fsl,imx8mp-pcie
reg:
items:
--
2.25.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH v1 5/7] arm64: dts: imx8mp: add the iMX8MP PCIe support
2022-03-07 6:29 [PATCH v1 0/7] Add the iMX8MP PCIe support Richard Zhu
` (3 preceding siblings ...)
2022-03-07 6:29 ` [PATCH v1 4/7] dt-bindings: imx6q-pcie: Add iMX8MP PCIe compatible string Richard Zhu
@ 2022-03-07 6:29 ` Richard Zhu
2022-03-07 6:29 ` [PATCH v1 6/7] arm64: dts: imx8mp-evk: Add " Richard Zhu
2022-03-07 6:29 ` [PATCH v1 7/7] PCI: imx6: Add the iMX8MP " Richard Zhu
6 siblings, 0 replies; 11+ messages in thread
From: Richard Zhu @ 2022-03-07 6:29 UTC (permalink / raw)
To: p.zabel, l.stach, bhelgaas, lorenzo.pieralisi, robh, shawnguo
Cc: devicetree, linux-pci, linux-arm-kernel, linux-kernel, kernel,
linux-imx, Richard Zhu
Add the i.MX8MP PCIe support.
Signed-off-by: Richard Zhu <hongxing.zhu@nxp.com>
---
arch/arm64/boot/dts/freescale/imx8mp.dtsi | 46 ++++++++++++++++++++++-
1 file changed, 45 insertions(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
index b40a5646f205..e7b3d8029e34 100644
--- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
@@ -5,6 +5,7 @@
#include <dt-bindings/clock/imx8mp-clock.h>
#include <dt-bindings/power/imx8mp-power.h>
+#include <dt-bindings/reset/imx8mp-reset.h>
#include <dt-bindings/gpio/gpio.h>
#include <dt-bindings/input/input.h>
#include <dt-bindings/interrupt-controller/arm-gic.h>
@@ -375,7 +376,8 @@ iomuxc: pinctrl@30330000 {
};
gpr: iomuxc-gpr@30340000 {
- compatible = "fsl,imx8mp-iomuxc-gpr", "syscon";
+ compatible = "fsl,imx8mp-iomuxc-gpr",
+ "fsl,imx6q-iomuxc-gpr", "syscon";
reg = <0x30340000 0x10000>;
};
@@ -965,6 +967,17 @@ aips4: bus@32c00000 {
#size-cells = <1>;
ranges;
+ pcie_phy: pcie-phy@32f00000 {
+ compatible = "fsl,imx8mp-pcie-phy";
+ reg = <0x32f00000 0x10000>;
+ resets = <&src IMX8MP_RESET_PCIEPHY>,
+ <&src IMX8MP_RESET_PCIEPHY_PERST>;
+ reset-names = "pciephy", "perst";
+ power-domains = <&hsio_blk_ctrl IMX8MP_HSIOBLK_PD_PCIE_PHY>;
+ #phy-cells = <0>;
+ status = "disabled";
+ };
+
hsio_blk_ctrl: blk-ctrl@32f10000 {
compatible = "fsl,imx8mp-hsio-blk-ctrl", "syscon";
reg = <0x32f10000 0x24>;
@@ -980,6 +993,37 @@ hsio_blk_ctrl: blk-ctrl@32f10000 {
};
};
+ pcie: pcie@33800000 {
+ compatible = "fsl,imx8mp-pcie";
+ reg = <0x33800000 0x400000>, <0x1ff00000 0x80000>;
+ reg-names = "dbi", "config";
+ #address-cells = <3>;
+ #size-cells = <2>;
+ device_type = "pci";
+ bus-range = <0x00 0xff>;
+ ranges = <0x81000000 0 0x00000000 0x1ff80000 0 0x00010000 /* downstream I/O 64KB */
+ 0x82000000 0 0x18000000 0x18000000 0 0x07f00000>; /* non-prefetchable memory */
+ num-lanes = <1>;
+ num-viewport = <4>;
+ interrupts = <GIC_SPI 140 IRQ_TYPE_LEVEL_HIGH>;
+ interrupt-names = "msi";
+ #interrupt-cells = <1>;
+ interrupt-map-mask = <0 0 0 0x7>;
+ interrupt-map = <0 0 0 1 &gic GIC_SPI 126 IRQ_TYPE_LEVEL_HIGH>,
+ <0 0 0 2 &gic GIC_SPI 125 IRQ_TYPE_LEVEL_HIGH>,
+ <0 0 0 3 &gic GIC_SPI 124 IRQ_TYPE_LEVEL_HIGH>,
+ <0 0 0 4 &gic GIC_SPI 123 IRQ_TYPE_LEVEL_HIGH>;
+ fsl,max-link-speed = <3>;
+ linux,pci-domain = <0>;
+ power-domains = <&hsio_blk_ctrl IMX8MP_HSIOBLK_PD_PCIE>;
+ resets = <&src IMX8MP_RESET_PCIE_CTRL_APPS_EN>,
+ <&src IMX8MP_RESET_PCIE_CTRL_APPS_TURNOFF>;
+ reset-names = "apps", "turnoff";
+ phys = <&pcie_phy>;
+ phy-names = "pcie-phy";
+ status = "disabled";
+ };
+
gpu3d: gpu@38000000 {
compatible = "vivante,gc";
reg = <0x38000000 0x8000>;
--
2.25.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH v1 6/7] arm64: dts: imx8mp-evk: Add PCIe support
2022-03-07 6:29 [PATCH v1 0/7] Add the iMX8MP PCIe support Richard Zhu
` (4 preceding siblings ...)
2022-03-07 6:29 ` [PATCH v1 5/7] arm64: dts: imx8mp: add the iMX8MP PCIe support Richard Zhu
@ 2022-03-07 6:29 ` Richard Zhu
2022-03-07 6:29 ` [PATCH v1 7/7] PCI: imx6: Add the iMX8MP " Richard Zhu
6 siblings, 0 replies; 11+ messages in thread
From: Richard Zhu @ 2022-03-07 6:29 UTC (permalink / raw)
To: p.zabel, l.stach, bhelgaas, lorenzo.pieralisi, robh, shawnguo
Cc: devicetree, linux-pci, linux-arm-kernel, linux-kernel, kernel,
linux-imx, Richard Zhu
Add PCIe support on i.MX8MP EVK board.
Signed-off-by: Richard Zhu <hongxing.zhu@nxp.com>
---
arch/arm64/boot/dts/freescale/imx8mp-evk.dts | 55 ++++++++++++++++++++
1 file changed, 55 insertions(+)
diff --git a/arch/arm64/boot/dts/freescale/imx8mp-evk.dts b/arch/arm64/boot/dts/freescale/imx8mp-evk.dts
index 2eb943210678..ed77455a3f73 100644
--- a/arch/arm64/boot/dts/freescale/imx8mp-evk.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mp-evk.dts
@@ -5,6 +5,7 @@
/dts-v1/;
+#include <dt-bindings/phy/phy-imx8-pcie.h>
#include "imx8mp.dtsi"
/ {
@@ -33,6 +34,12 @@ memory@40000000 {
<0x1 0x00000000 0 0xc0000000>;
};
+ pcie0_refclk: pcie0-refclk {
+ compatible = "fixed-clock";
+ #clock-cells = <0>;
+ clock-frequency = <100000000>;
+ };
+
reg_can1_stby: regulator-can1-stby {
compatible = "regulator-fixed";
regulator-name = "can1-stby";
@@ -55,6 +62,17 @@ reg_can2_stby: regulator-can2-stby {
enable-active-high;
};
+ reg_pcie0: regulator-pcie {
+ compatible = "regulator-fixed";
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_pcie0_reg>;
+ regulator-name = "MPCIE_3V3";
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3300000>;
+ gpio = <&gpio2 6 GPIO_ACTIVE_HIGH>;
+ enable-active-high;
+ };
+
reg_usdhc2_vmmc: regulator-usdhc2 {
compatible = "regulator-fixed";
pinctrl-names = "default";
@@ -297,6 +315,30 @@ pca6416: gpio@20 {
};
};
+&pcie_phy {
+ fsl,refclk-pad-mode = <IMX8_PCIE_REFCLK_PAD_INPUT>;
+ clocks = <&pcie0_refclk>;
+ clock-names = "ref";
+ status = "okay";
+};
+
+&pcie{
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_pcie0>;
+ reset-gpio = <&gpio2 7 GPIO_ACTIVE_LOW>;
+ clocks = <&clk IMX8MP_CLK_HSIO_ROOT>,
+ <&clk IMX8MP_CLK_PCIE_ROOT>,
+ <&clk IMX8MP_CLK_HSIO_AXI>;
+ clock-names = "pcie", "pcie_aux", "pcie_bus";
+ assigned-clocks = <&clk IMX8MP_CLK_HSIO_AXI>,
+ <&clk IMX8MP_CLK_PCIE_AUX>;
+ assigned-clock-rates = <500000000>, <10000000>;
+ assigned-clock-parents = <&clk IMX8MP_SYS_PLL2_500M>,
+ <&clk IMX8MP_SYS_PLL2_50M>;
+ vpcie-supply = <®_pcie0>;
+ status = "okay";
+};
+
&snvs_pwrkey {
status = "okay";
};
@@ -442,6 +484,19 @@ MX8MP_IOMUXC_I2C3_SDA__I2C3_SDA 0x400001c3
>;
};
+ pinctrl_pcie0: pcie0grp {
+ fsl,pins = <
+ MX8MP_IOMUXC_I2C4_SCL__PCIE_CLKREQ_B 0x61 /* open drain, pull up */
+ MX8MP_IOMUXC_SD1_DATA5__GPIO2_IO07 0x41
+ >;
+ };
+
+ pinctrl_pcie0_reg: pcie0reggrp {
+ fsl,pins = <
+ MX8MP_IOMUXC_SD1_DATA4__GPIO2_IO06 0x41
+ >;
+ };
+
pinctrl_pmic: pmicgrp {
fsl,pins = <
MX8MP_IOMUXC_GPIO1_IO03__GPIO1_IO03 0x000001c0
--
2.25.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH v1 7/7] PCI: imx6: Add the iMX8MP PCIe support
2022-03-07 6:29 [PATCH v1 0/7] Add the iMX8MP PCIe support Richard Zhu
` (5 preceding siblings ...)
2022-03-07 6:29 ` [PATCH v1 6/7] arm64: dts: imx8mp-evk: Add " Richard Zhu
@ 2022-03-07 6:29 ` Richard Zhu
6 siblings, 0 replies; 11+ messages in thread
From: Richard Zhu @ 2022-03-07 6:29 UTC (permalink / raw)
To: p.zabel, l.stach, bhelgaas, lorenzo.pieralisi, robh, shawnguo
Cc: devicetree, linux-pci, linux-arm-kernel, linux-kernel, kernel,
linux-imx, Richard Zhu
Add the i.MX8MP PCIe support.
Signed-off-by: Richard Zhu <hongxing.zhu@nxp.com>
---
drivers/pci/controller/dwc/pci-imx6.c | 19 ++++++++++++++++++-
1 file changed, 18 insertions(+), 1 deletion(-)
diff --git a/drivers/pci/controller/dwc/pci-imx6.c b/drivers/pci/controller/dwc/pci-imx6.c
index bb662f90d4f3..4d34f0c88550 100644
--- a/drivers/pci/controller/dwc/pci-imx6.c
+++ b/drivers/pci/controller/dwc/pci-imx6.c
@@ -51,6 +51,7 @@ enum imx6_pcie_variants {
IMX7D,
IMX8MQ,
IMX8MM,
+ IMX8MP,
};
#define IMX6_PCIE_FLAG_IMX6_PHY BIT(0)
@@ -379,6 +380,7 @@ static void imx6_pcie_assert_core_reset(struct imx6_pcie *imx6_pcie)
reset_control_assert(imx6_pcie->pciephy_reset);
fallthrough;
case IMX8MM:
+ case IMX8MP:
reset_control_assert(imx6_pcie->apps_reset);
break;
case IMX6SX:
@@ -407,7 +409,8 @@ static void imx6_pcie_assert_core_reset(struct imx6_pcie *imx6_pcie)
static unsigned int imx6_pcie_grp_offset(const struct imx6_pcie *imx6_pcie)
{
WARN_ON(imx6_pcie->drvdata->variant != IMX8MQ &&
- imx6_pcie->drvdata->variant != IMX8MM);
+ imx6_pcie->drvdata->variant != IMX8MM &&
+ imx6_pcie->drvdata->variant != IMX8MP);
return imx6_pcie->controller_id == 1 ? IOMUXC_GPR16 : IOMUXC_GPR14;
}
@@ -448,6 +451,7 @@ static int imx6_pcie_enable_ref_clk(struct imx6_pcie *imx6_pcie)
break;
case IMX8MM:
case IMX8MQ:
+ case IMX8MP:
ret = clk_prepare_enable(imx6_pcie->pcie_aux);
if (ret) {
dev_err(dev, "unable to enable pcie_aux clock\n");
@@ -503,6 +507,7 @@ static int imx6_pcie_clk_enable(struct imx6_pcie *imx6_pcie)
switch (imx6_pcie->drvdata->variant) {
case IMX8MM:
+ case IMX8MP:
if (phy_power_on(imx6_pcie->phy))
dev_err(dev, "unable to power on PHY\n");
break;
@@ -603,6 +608,7 @@ static int imx6_pcie_deassert_core_reset(struct imx6_pcie *imx6_pcie)
reset_control_deassert(imx6_pcie->pciephy_reset);
break;
case IMX8MM:
+ case IMX8MP:
if (phy_init(imx6_pcie->phy))
dev_err(dev, "waiting for phy ready timeout!\n");
break;
@@ -678,6 +684,7 @@ static void imx6_pcie_init_phy(struct imx6_pcie *imx6_pcie)
{
switch (imx6_pcie->drvdata->variant) {
case IMX8MM:
+ case IMX8MP:
/*
* The PHY initialization had been done in the PHY
* driver, break here directly.
@@ -823,6 +830,7 @@ static void imx6_pcie_ltssm_enable(struct device *dev)
case IMX7D:
case IMX8MQ:
case IMX8MM:
+ case IMX8MP:
reset_control_deassert(imx6_pcie->apps_reset);
break;
}
@@ -938,6 +946,7 @@ static void imx6_pcie_host_exit(struct pcie_port *pp)
imx6_pcie_clk_disable(imx6_pcie);
switch (imx6_pcie->drvdata->variant) {
case IMX8MM:
+ case IMX8MP:
if (phy_power_off(imx6_pcie->phy))
dev_err(dev, "unable to power off phy\n");
phy_exit(imx6_pcie->phy);
@@ -972,6 +981,7 @@ static void imx6_pcie_ltssm_disable(struct device *dev)
break;
case IMX7D:
case IMX8MM:
+ case IMX8MP:
reset_control_assert(imx6_pcie->apps_reset);
break;
default:
@@ -1028,6 +1038,7 @@ static int imx6_pcie_suspend_noirq(struct device *dev)
imx6_pcie_clk_disable(imx6_pcie);
switch (imx6_pcie->drvdata->variant) {
case IMX8MM:
+ case IMX8MP:
if (phy_power_off(imx6_pcie->phy))
dev_err(dev, "unable to power off PHY\n");
phy_exit(imx6_pcie->phy);
@@ -1177,6 +1188,7 @@ static int imx6_pcie_probe(struct platform_device *pdev)
}
break;
case IMX8MM:
+ case IMX8MP:
imx6_pcie->pcie_aux = devm_clk_get(dev, "pcie_aux");
if (IS_ERR(imx6_pcie->pcie_aux))
return dev_err_probe(dev, PTR_ERR(imx6_pcie->pcie_aux),
@@ -1327,6 +1339,10 @@ static const struct imx6_pcie_drvdata drvdata[] = {
.variant = IMX8MM,
.flags = IMX6_PCIE_FLAG_SUPPORTS_SUSPEND,
},
+ [IMX8MP] = {
+ .variant = IMX8MP,
+ .flags = IMX6_PCIE_FLAG_SUPPORTS_SUSPEND,
+ },
};
static const struct of_device_id imx6_pcie_of_match[] = {
@@ -1336,6 +1352,7 @@ static const struct of_device_id imx6_pcie_of_match[] = {
{ .compatible = "fsl,imx7d-pcie", .data = &drvdata[IMX7D], },
{ .compatible = "fsl,imx8mq-pcie", .data = &drvdata[IMX8MQ], },
{ .compatible = "fsl,imx8mm-pcie", .data = &drvdata[IMX8MM], },
+ { .compatible = "fsl,imx8mp-pcie", .data = &drvdata[IMX8MP], },
{},
};
--
2.25.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: (EXT) [PATCH v1 4/7] dt-bindings: imx6q-pcie: Add iMX8MP PCIe compatible string
2022-03-07 6:29 ` [PATCH v1 4/7] dt-bindings: imx6q-pcie: Add iMX8MP PCIe compatible string Richard Zhu
@ 2022-03-07 8:02 ` Alexander Stein
2022-03-07 8:19 ` Hongxing Zhu
0 siblings, 1 reply; 11+ messages in thread
From: Alexander Stein @ 2022-03-07 8:02 UTC (permalink / raw)
To: Richard Zhu
Cc: p.zabel, l.stach, bhelgaas, lorenzo.pieralisi, robh, shawnguo,
linux-arm-kernel, devicetree, linux-pci, linux-arm-kernel,
linux-kernel, kernel, linux-imx, Richard Zhu
Hi Richard,
thanks for providing a patch supporting PCie on iMX8MP.
Am Montag, 7. März 2022, 07:29:13 CET schrieb Richard Zhu:
> Add i.MX8MP PCIe compatible string.
>
> Signed-off-by: Richard Zhu <hongxing.zhu@nxp.com>
> ---
> Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml
> b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml index
> 36c8a06d17a0..252e5b72aee0 100644
> --- a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml
> +++ b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml
> @@ -26,6 +26,7 @@ properties:
> - fsl,imx7d-pcie
> - fsl,imx8mq-pcie
> - fsl,imx8mm-pcie
> + - fsl,imx8mp-pcie
>
> reg:
> items:
Which branch is this based on? I don't have 'fsl,imx8mm-pcie' entry in my
tree. Another patch 7 also doesn't apply cleanly.
Regards
Alexander
^ permalink raw reply [flat|nested] 11+ messages in thread
* RE: (EXT) [PATCH v1 4/7] dt-bindings: imx6q-pcie: Add iMX8MP PCIe compatible string
2022-03-07 8:02 ` (EXT) " Alexander Stein
@ 2022-03-07 8:19 ` Hongxing Zhu
2022-03-07 8:42 ` (EXT) " Alexander Stein
0 siblings, 1 reply; 11+ messages in thread
From: Hongxing Zhu @ 2022-03-07 8:19 UTC (permalink / raw)
To: Alexander Stein
Cc: p.zabel, l.stach, bhelgaas, lorenzo.pieralisi, robh, shawnguo,
linux-arm-kernel, devicetree, linux-pci, linux-arm-kernel,
linux-kernel, kernel, dl-linux-imx
> -----Original Message-----
> From: Alexander Stein <alexander.stein@ew.tq-group.com>
> Sent: 2022年3月7日 16:03
> To: Hongxing Zhu <hongxing.zhu@nxp.com>
> Cc: p.zabel@pengutronix.de; l.stach@pengutronix.de; bhelgaas@google.com;
> lorenzo.pieralisi@arm.com; robh@kernel.org; shawnguo@kernel.org;
> linux-arm-kernel@lists.infradead.org; devicetree@vger.kernel.org;
> linux-pci@vger.kernel.org; linux-arm-kernel@lists.infradead.org;
> linux-kernel@vger.kernel.org; kernel@pengutronix.de; dl-linux-imx
> <linux-imx@nxp.com>; Hongxing Zhu <hongxing.zhu@nxp.com>
> Subject: Re: (EXT) [PATCH v1 4/7] dt-bindings: imx6q-pcie: Add iMX8MP PCIe
> compatible string
>
> Hi Richard,
>
> thanks for providing a patch supporting PCie on iMX8MP.
>
> Am Montag, 7. März 2022, 07:29:13 CET schrieb Richard Zhu:
> > Add i.MX8MP PCIe compatible string.
> >
> > Signed-off-by: Richard Zhu <hongxing.zhu@nxp.com>
> > ---
> > Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml
> > b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml index
> > 36c8a06d17a0..252e5b72aee0 100644
> > --- a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml
> > +++ b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml
> > @@ -26,6 +26,7 @@ properties:
> > - fsl,imx7d-pcie
> > - fsl,imx8mq-pcie
> > - fsl,imx8mm-pcie
> > + - fsl,imx8mp-pcie
> >
> > reg:
> > items:
>
> Which branch is this based on? I don't have 'fsl,imx8mm-pcie' entry in my tree.
> Another patch 7 also doesn't apply cleanly.
>
Hi Alexander:
Thanks for your quick reply.
In the past days, I had summit some patches, and wait for ack or reviewed tags.
But they might have some conflictions when do the codes merge.
I'm waiting for the ack, and will re-base them in a proper sequence later.
About the #4 patch apply, it's better to pick the following commit, since it had
Lucas' Reviewed-by tag, and wait for merge.
https://patchwork.ozlabs.org/project/linux-pci/patch/1646293805-18248-1-git-send-email-hongxing.zhu@nxp.com/
About the #7 patch, I do the changes based on the following patch-set.
https://patchwork.ozlabs.org/project/linux-pci/cover/1645760667-10510-1-git-send-email-hongxing.zhu@nxp.com/
I would add the dependency patch-set later in the cover-letter later.
Sorry to bring in-conveniency to you.
BTW, If you want to tests PCIe on i.MX8MM EVK board too, the following dts
changes should be cherry-picked from Shawn's git.
b4d36c10bf17 arm64: dts: imx8mm-evk: Add the pcie support on imx8mm evk board
aaeba6a8e226 arm64: dts: imx8mm: Add the pcie support
cfc5078432ca arm64: dts: imx8mm: Add the pcie phy support
Best Regards
Richard Zhu
> Regards
> Alexander
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: (EXT) RE: (EXT) [PATCH v1 4/7] dt-bindings: imx6q-pcie: Add iMX8MP PCIe compatible string
2022-03-07 8:19 ` Hongxing Zhu
@ 2022-03-07 8:42 ` Alexander Stein
0 siblings, 0 replies; 11+ messages in thread
From: Alexander Stein @ 2022-03-07 8:42 UTC (permalink / raw)
To: Hongxing Zhu
Cc: p.zabel, l.stach, bhelgaas, lorenzo.pieralisi, robh, shawnguo,
linux-arm-kernel, devicetree, linux-pci, linux-arm-kernel,
linux-kernel, kernel, dl-linux-imx
Hi Richard,
Am Montag, 7. März 2022, 09:19:52 CET schrieb Hongxing Zhu:
> > -----Original Message-----
> > From: Alexander Stein <alexander.stein@ew.tq-group.com>
> > Sent: 2022年3月7日 16:03
> > To: Hongxing Zhu <hongxing.zhu@nxp.com>
> > Cc: p.zabel@pengutronix.de; l.stach@pengutronix.de; bhelgaas@google.com;
> > lorenzo.pieralisi@arm.com; robh@kernel.org; shawnguo@kernel.org;
> > linux-arm-kernel@lists.infradead.org; devicetree@vger.kernel.org;
> > linux-pci@vger.kernel.org; linux-arm-kernel@lists.infradead.org;
> > linux-kernel@vger.kernel.org; kernel@pengutronix.de; dl-linux-imx
> > <linux-imx@nxp.com>; Hongxing Zhu <hongxing.zhu@nxp.com>
> > Subject: Re: (EXT) [PATCH v1 4/7] dt-bindings: imx6q-pcie: Add iMX8MP
> > PCIe
> > compatible string
> >
> > Hi Richard,
> >
> > thanks for providing a patch supporting PCie on iMX8MP.
> >
> > Am Montag, 7. März 2022, 07:29:13 CET schrieb Richard Zhu:
> >
> > > Add i.MX8MP PCIe compatible string.
> > >
> > >
> > >
> > > Signed-off-by: Richard Zhu <hongxing.zhu@nxp.com>
> > > ---
> > >
> > > Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > >
> > >
> > > diff --git a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml
> > > b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml index
> > > 36c8a06d17a0..252e5b72aee0 100644
> > > --- a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml
> > > +++ b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml
> > > @@ -26,6 +26,7 @@ properties:
> > >
> > > - fsl,imx7d-pcie
> > > - fsl,imx8mq-pcie
> > > - fsl,imx8mm-pcie
> > >
> > > + - fsl,imx8mp-pcie
> > >
> > >
> > >
> > > reg:
> > >
> > > items:
> >
> >
> > Which branch is this based on? I don't have 'fsl,imx8mm-pcie' entry in my
> > tree.
Another patch 7 also doesn't apply cleanly.
> >
>
> Hi Alexander:
> Thanks for your quick reply.
Thanks for your fast response. I just wanted to give it a try on our own
custom iMX8MP board. I did see the PCIe RC, but not EP (yet), no link up for
now.
> In the past days, I had summit some patches, and wait for ack or reviewed
> tags.
But they might have some conflictions when do the codes merge.
> I'm waiting for the ack, and will re-base them in a proper sequence later.
>
> About the #4 patch apply, it's better to pick the following commit, since it
> had
Lucas' Reviewed-by tag, and wait for merge.
> https://patchwork.ozlabs.org/project/linux-pci/patch/1646293805-18248-1-git-> send-email-hongxing.zhu@nxp.com/
> About the #7 patch, I do the changes based on the following patch-set.
> https://patchwork.ozlabs.org/project/linux-pci/cover/1645760667-10510-1-git-> send-email-hongxing.zhu@nxp.com/
> I would add the dependency patch-set later in the cover-letter later.
> Sorry to bring in-conveniency to you.
Thanks I'll retry with the dependencies updated, so I hopefully won't miss
something.
> BTW, If you want to tests PCIe on i.MX8MM EVK board too, the following dts
> changes should be cherry-picked from Shawn's git.
> b4d36c10bf17 arm64: dts: imx8mm-evk: Add the pcie support on imx8mm evk
> board
aaeba6a8e226 arm64: dts: imx8mm: Add the pcie support
> cfc5078432ca arm64: dts: imx8mm: Add the pcie phy support
Thanks I'll keep the imx8mm support in mind.
Best regards
Alexander
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2022-03-07 8:42 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-07 6:29 [PATCH v1 0/7] Add the iMX8MP PCIe support Richard Zhu
2022-03-07 6:29 ` [PATCH v1 1/7] reset: imx7: Add the iMX8MP PCIe PHY PERST support Richard Zhu
2022-03-07 6:29 ` [PATCH v1 2/7] dt-binding: phy: Add iMX8MP PCIe PHY binding Richard Zhu
2022-03-07 6:29 ` [PATCH v1 3/7] phy: freescale: imx8m-pcie: Add iMX8MP PCIe PHY support Richard Zhu
2022-03-07 6:29 ` [PATCH v1 4/7] dt-bindings: imx6q-pcie: Add iMX8MP PCIe compatible string Richard Zhu
2022-03-07 8:02 ` (EXT) " Alexander Stein
2022-03-07 8:19 ` Hongxing Zhu
2022-03-07 8:42 ` (EXT) " Alexander Stein
2022-03-07 6:29 ` [PATCH v1 5/7] arm64: dts: imx8mp: add the iMX8MP PCIe support Richard Zhu
2022-03-07 6:29 ` [PATCH v1 6/7] arm64: dts: imx8mp-evk: Add " Richard Zhu
2022-03-07 6:29 ` [PATCH v1 7/7] PCI: imx6: Add the iMX8MP " Richard Zhu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).