[PATCH v2 0/2] dt-bindings: PCI: ti,j721e-pci-*: resolve unexpected property warnings

[PATCH v2 0/2] dt-bindings: PCI: ti,j721e-pci-*: resolve unexpected property warnings

[Matt Ranostay]

Resolve unexpected property warnings related to interrupts in both J721E PCI EP and host
yaml files.

Changes from v1:
* Fix typo in commit message
* Add missing Cc to maintainers

Matt Ranostay (2):
  dt-bindings: PCI: ti,j721e-pci-host: add interrupt controller
    definition
  dt-bindings: PCI: ti,j721e-pci-*: Add missing interrupt properties

 .../bindings/pci/ti,j721e-pci-ep.yaml         |  7 +++++++
 .../bindings/pci/ti,j721e-pci-host.yaml       | 20 +++++++++++++++++++
 2 files changed, 27 insertions(+)

-- 
2.38.0.rc0.52.gdda7228a83

[PATCH v2 1/2] dt-bindings: PCI: ti,j721e-pci-host: add interrupt controller definition

[Matt Ranostay]

Add missing 'interrupt-controller' property and related subnodes to resolve
the following warning:

arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dtb: pcie@2910000: Unevaluated properties are not allowed ('interrupt-controller' was unexpected)
        From schema: Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml

Signed-off-by: Matt Ranostay <mranostay@ti.com>
---
 .../devicetree/bindings/pci/ti,j721e-pci-host.yaml  | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml b/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml
index 2115d5a3f0e1..0f5914a22c14 100644
--- a/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml
+++ b/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml
@@ -76,6 +76,19 @@ properties:
 
   msi-map: true
 
+  interrupt-controller:
+    type: object
+    additionalProperties: false
+
+    properties:
+      interrupt-controller: true
+
+      '#interrupt-cells':
+        const: 1
+
+      interrupts:
+        maxItems: 1
+
 required:
   - compatible
   - reg
-- 
2.38.0.rc0.52.gdda7228a83

[PATCH v2 2/2] dt-bindings: PCI: ti,j721e-pci-*: Add missing interrupt properties

[Matt Ranostay]

Both interrupts, and interrupt names weren't defined in both EP and host
yaml. Also define the only possible interrupt-name as link_state, and
maxItems of interrupts to one.

This patch resolves the following warning:

arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dtb: pcie-ep@2910000: Unevaluated properties are not allowed ('interrupt-names', 'interrupts' were unexpected)
        From schema Documentation/devicetree/bindings/pci/ti,j721e-pci-ep.yaml

Signed-off-by: Matt Ranostay <mranostay@ti.com>
---
 Documentation/devicetree/bindings/pci/ti,j721e-pci-ep.yaml | 7 +++++++
 .../devicetree/bindings/pci/ti,j721e-pci-host.yaml         | 7 +++++++
 2 files changed, 14 insertions(+)

diff --git a/Documentation/devicetree/bindings/pci/ti,j721e-pci-ep.yaml b/Documentation/devicetree/bindings/pci/ti,j721e-pci-ep.yaml
index aed437dac363..10e6eabdff53 100644
--- a/Documentation/devicetree/bindings/pci/ti,j721e-pci-ep.yaml
+++ b/Documentation/devicetree/bindings/pci/ti,j721e-pci-ep.yaml
@@ -58,6 +58,13 @@ properties:
   dma-coherent:
     description: Indicates that the PCIe IP block can ensure the coherency
 
+  interrupts:
+    maxItems: 1
+
+  interrupt-names:
+    items:
+      - const: link_state
+
 required:
   - compatible
   - reg
diff --git a/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml b/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml
index 0f5914a22c14..d9df7cd922f1 100644
--- a/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml
+++ b/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml
@@ -76,6 +76,13 @@ properties:
 
   msi-map: true
 
+  interrupts:
+    maxItems: 1
+
+  interrupt-names:
+    items:
+      - const: link_state
+
   interrupt-controller:
     type: object
     additionalProperties: false
-- 
2.38.0.rc0.52.gdda7228a83

Re: [PATCH v2 0/2] dt-bindings: PCI: ti,j721e-pci-*: resolve unexpected property warnings

[Krzysztof Kozlowski]

On 25/09/2022 00:35, Matt Ranostay wrote:
> Resolve unexpected property warnings related to interrupts in both J721E PCI EP and host
> yaml files.
> 

Thanks for cc-ing. On what tree do you base your patch? Looks like
something old. If so, you need to rebase to some recent kernel.

Best regards,
Krzysztof

Re: [PATCH v2 0/2] dt-bindings: PCI: ti,j721e-pci-*: resolve unexpected property warnings

[Matt Ranostay]

On Sun, Sep 25, 2022 at 11:21:02AM +0200, Krzysztof Kozlowski wrote:
> On 25/09/2022 00:35, Matt Ranostay wrote:
> > Resolve unexpected property warnings related to interrupts in both J721E PCI EP and host
> > yaml files.
> > 
> 
> Thanks for cc-ing. On what tree do you base your patch? Looks like
> something old. If so, you need to rebase to some recent kernel.
>

It was on linux-next from Sep 23rd. So would seem odd if the rebasing seems
from an older tree. 

- Matt

> Best regards,
> Krzysztof
> 

Re: [PATCH v2 0/2] dt-bindings: PCI: ti,j721e-pci-*: resolve unexpected property warnings

[Krzysztof Kozlowski]

On 26/09/2022 05:06, Matt Ranostay wrote:
> On Sun, Sep 25, 2022 at 11:21:02AM +0200, Krzysztof Kozlowski wrote:
>> On 25/09/2022 00:35, Matt Ranostay wrote:
>>> Resolve unexpected property warnings related to interrupts in both J721E PCI EP and host
>>> yaml files.
>>>
>>
>> Thanks for cc-ing. On what tree do you base your patch? Looks like
>> something old. If so, you need to rebase to some recent kernel.
>>
> 
> It was on linux-next from Sep 23rd. So would seem odd if the rebasing seems
> from an older tree. 
That's good, but then why you did not use scripts/get_maintainers.pl as
I asked...

Best regards,
Krzysztof

Re: [PATCH v2 1/2] dt-bindings: PCI: ti,j721e-pci-host: add interrupt controller definition

[Rob Herring]

On Sat, 24 Sep 2022 15:35:16 -0700, Matt Ranostay wrote:
> Add missing 'interrupt-controller' property and related subnodes to resolve
> the following warning:
> 
> arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dtb: pcie@2910000: Unevaluated properties are not allowed ('interrupt-controller' was unexpected)
>         From schema: Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml
> 
> Signed-off-by: Matt Ranostay <mranostay@ti.com>
> ---
>  .../devicetree/bindings/pci/ti,j721e-pci-host.yaml  | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
> 

Acked-by: Rob Herring <robh@kernel.org>

Re: [PATCH v2 2/2] dt-bindings: PCI: ti,j721e-pci-*: Add missing interrupt properties

[Rob Herring]

On Sat, 24 Sep 2022 15:35:17 -0700, Matt Ranostay wrote:
> Both interrupts, and interrupt names weren't defined in both EP and host
> yaml. Also define the only possible interrupt-name as link_state, and
> maxItems of interrupts to one.
> 
> This patch resolves the following warning:
> 
> arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dtb: pcie-ep@2910000: Unevaluated properties are not allowed ('interrupt-names', 'interrupts' were unexpected)
>         From schema Documentation/devicetree/bindings/pci/ti,j721e-pci-ep.yaml
> 
> Signed-off-by: Matt Ranostay <mranostay@ti.com>
> ---
>  Documentation/devicetree/bindings/pci/ti,j721e-pci-ep.yaml | 7 +++++++
>  .../devicetree/bindings/pci/ti,j721e-pci-host.yaml         | 7 +++++++
>  2 files changed, 14 insertions(+)
> 

Acked-by: Rob Herring <robh@kernel.org>