From: Krishna Chaitanya Chundru <quic_krichai@quicinc.com>
To: Stephen Boyd <swboyd@chromium.org>, <helgaas@kernel.org>
Cc: linux-pci@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org, quic_vbadigan@quicinc.com,
quic_hemantk@quicinc.com, quic_ramkri@quicinc.com,
manivannan.sadhasivam@linaro.org,
"Andy Gross" <agross@kernel.org>,
"Bjorn Andersson" <bjorn.andersson@linaro.org>,
"Stanimir Varbanov" <svarbanov@mm-sol.com>,
"Lorenzo Pieralisi" <lorenzo.pieralisi@arm.com>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Bjorn Helgaas" <bhelgaas@google.com>
Subject: Re: [PATCH v1] PCI: qcom: Allow L1 and its sub states on qcom dwc wrapper
Date: Wed, 15 Jun 2022 18:44:19 +0530 [thread overview]
Message-ID: <1e92745e-6fa4-a3bd-d0cb-5c1f78efbead@quicinc.com> (raw)
In-Reply-To: <CAE-0n52hpKxMG=gq1rPGx0cM2VKNRo+WHVW+ExCScJ8UwZKgGA@mail.gmail.com>
On 6/9/2022 3:47 AM, Stephen Boyd wrote:
> Quoting Krishna chaitanya chundru (2022-06-03 00:18:50)
>> Allow L1 and its sub-states in the qcom dwc pcie wrapper.
>> By default its disabled. So enable it explicitly.
>>
> Would be good to add some more details about why it's disabled by
> default. I guess it's disabled by default in the hardware and enabling
> it is OK to do unconditionally for all qcom dwc pcie devices?
This is disabled by default in the hardware. We can enable this for all
qcom devices unconditionally because
Adding this patch alone will not allow aspm transitions we need to
enable aspm configs. If particular devices doesn't want aspm
they can disable using aspm configs.
next prev parent reply other threads:[~2022-06-15 13:14 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-03 7:18 [PATCH v1] PCI: qcom: Allow L1 and its sub states on qcom dwc wrapper Krishna chaitanya chundru
2022-06-08 22:17 ` Stephen Boyd
2022-06-15 13:14 ` Krishna Chaitanya Chundru [this message]
2022-06-15 15:44 ` Bjorn Helgaas
2022-06-09 11:26 ` Manivannan Sadhasivam
2022-06-15 13:14 ` Krishna Chaitanya Chundru
2022-06-15 13:15 ` [PATCH v2] PCI: qcom: Allow L1 and its sub states Krishna chaitanya chundru
2022-06-24 8:02 ` Krishna Chaitanya Chundru
2022-06-24 9:02 ` Manivannan Sadhasivam
2022-06-24 17:11 ` Bjorn Helgaas
2022-07-15 8:24 ` Manivannan Sadhasivam
2022-07-15 11:29 ` Krishna Chaitanya Chundru
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1e92745e-6fa4-a3bd-d0cb-5c1f78efbead@quicinc.com \
--to=quic_krichai@quicinc.com \
--cc=agross@kernel.org \
--cc=bhelgaas@google.com \
--cc=bjorn.andersson@linaro.org \
--cc=helgaas@kernel.org \
--cc=kw@linux.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=manivannan.sadhasivam@linaro.org \
--cc=quic_hemantk@quicinc.com \
--cc=quic_ramkri@quicinc.com \
--cc=quic_vbadigan@quicinc.com \
--cc=robh@kernel.org \
--cc=svarbanov@mm-sol.com \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).