From: Taku Izumi <izumi.taku@jp.fujitsu.com>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: linux-pci@vger.kernel.org, linux-acpi@vger.kernel.org,
kaneshige.kenji@jp.fujitsu.com, yinghai@kernel.org,
jiang.liu@huawei.com
Subject: Re: [PATCH 0/7][RESEND] acpi, pci: hostbridge hotplug support
Date: Mon, 3 Sep 2012 11:28:45 +0900 [thread overview]
Message-ID: <20120903112845.0c583e70.izumi.taku@jp.fujitsu.com> (raw)
In-Reply-To: <CAErSpo5eqyuK_yKshHbDyK5LBBG9cCn1MpmHbqpvVYe6x7AxFg@mail.gmail.com>
Hi Bjorn,
Sorry for late response.
I've returned to Japan. It was nice to see you.
On Wed, 29 Aug 2012 23:23:49 -0700
Bjorn Helgaas <bhelgaas@google.com> wrote:
> On Thu, Aug 9, 2012 at 11:09 PM, Taku Izumi <izumi.taku@jp.fujitsu.com> wrote:
> > Hi all,
> >
> >
> > I'd like to merge hostbridge hotplug feature.
> > I looked at Yinghai's branch and found that this branch contains
> > many work and can be split into some parts.
> > I believe it is good to merge step by step.
> >
> > My idea is splitting into the following 4 parts:
> > 1. basic hostbirdge hotplug work
> > 2. acpiphp work
> > 3. /sysfs interface work (logical hotplug?)
> > 4. cleanup
> >
> > This patchset is 1st step based on the following Yinghai's branch:
> >
> > git://git.kernel.org/pub/scm/linux/kernel/git/yinghai/linux-yinghai.git
> > for-pci-root-bus-hotplug
> >
> > * [PATCH 1/7][RESEND] x86, PCI: Fix non acpi path pci_sysdata leaking with release_fn
> > * [PATCH 2/7][RESEND] PCI: Correctly clean up pci root buses in function pci_remove_bus()
> > * [PATCH 3/7][RESEND] ACPI, PCI: Use normal list for struct acpi_pci_driver
> > * [PATCH 4/7][RESEND] ACPI, PCI: Notify acpi_pci_drivers when hot-plugging PCI root bridges
> > * [PATCH 5/7][RESEND] ACPI, PCI: Protect global lists in drivers/acpi/pci_root.c
> > * [PATCH 6/7][RESEND] ACPI, PCI: add hostbridge removal function
> > * [PATCH 7/7][RESEND] ACPI, PCI: add resoruce-assign code for devices under hot-added hostbridge
>
> I looked at merging these tonight. But I noticed there are still a
> few unanswered questions I asked earlier.
>
> 1) For patch [1/7], I pointed out that there is currently no way to
> remove a non-ACPI host bridge, which means the fact that we don't free
> the pci_sysdata is not really a leak. If you want to add the
> release_fn so that you can add support for removing and adding these
> non-ACPI host bridges in the future, I do not understand that. It
> just doesn't make sense to me to try to support hotplug for those
> bridges.
I see. I plan on ACPI-based host bridge hotplug, so I omit this patch now.
> 2) For patch [2/7], I'm still curious about the scenario where this
> patch makes a difference (see my previous response for details).
I'll omit this patch too according to Jian's comment.
> 3) Patch [5/7], adds mutual exclusion to two different lists, using
> two different mechanisms (mutex and RCU). It would be easier for
> people to review if this were done in two separate patches.
>
OK. I'll sprit into 2 patches.
And I'll resend new version one soon.
--
Best regards,
Taku Izumi <izumi.taku@jp.fujitsu.com>
next prev parent reply other threads:[~2012-09-03 2:28 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-10 6:09 [PATCH 0/7][RESEND] acpi, pci: hostbridge hotplug support Taku Izumi
2012-08-10 6:11 ` [PATCH 1/7][RESEND] x86, PCI: Fix non acpi path pci_sysdata leaking with release_fn Taku Izumi
2012-08-16 16:42 ` Bjorn Helgaas
2012-08-10 6:12 ` [PATCH 2/7][RESEND] PCI: Correctly clean up pci root buses in function pci_remove_bus() Taku Izumi
2012-08-16 17:11 ` Bjorn Helgaas
2012-08-30 15:43 ` Jiang Liu
2012-08-10 6:12 ` [PATCH 3/7][RESEND] ACPI, PCI: Use normal list for struct acpi_pci_driver Taku Izumi
2012-08-10 6:13 ` [PATCH 4/7][RESEND] ACPI, PCI: Notify acpi_pci_drivers when hot-plugging PCI root bridges Taku Izumi
2012-08-10 6:14 ` [PATCH 5/7][RESEND] ACPI, PCI: Protect global lists in drivers/acpi/pci_root.c Taku Izumi
2012-08-16 17:25 ` Bjorn Helgaas
2012-08-10 6:14 ` [PATCH 6/7][RESEND] ACPI, PCI: add hostbridge removal function Taku Izumi
2012-08-10 6:15 ` [PATCH 7/7][RESEND] ACPI, PCI: add resoruce-assign code for devices under hot-added hostbridge Taku Izumi
2012-08-10 16:41 ` [PATCH 0/7][RESEND] acpi, pci: hostbridge hotplug support Yinghai Lu
2012-08-20 5:02 ` Taku Izumi
2012-08-30 6:23 ` Bjorn Helgaas
2012-08-30 6:33 ` Jiang Liu
2012-08-30 15:48 ` Yinghai Lu
2012-08-30 16:38 ` Jiang Liu
2012-08-30 17:29 ` Yinghai Lu
2012-08-31 0:43 ` Bjorn Helgaas
2012-08-31 1:03 ` Jiang Liu
2012-08-31 5:04 ` Bjorn Helgaas
2012-08-31 5:19 ` Jiang Liu
2012-08-31 5:42 ` Bjorn Helgaas
2012-08-31 16:44 ` Yinghai Lu
2012-09-01 3:56 ` Jiang Liu
2012-09-03 2:28 ` Taku Izumi [this message]
2012-09-03 4:04 ` Jiang Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120903112845.0c583e70.izumi.taku@jp.fujitsu.com \
--to=izumi.taku@jp.fujitsu.com \
--cc=bhelgaas@google.com \
--cc=jiang.liu@huawei.com \
--cc=kaneshige.kenji@jp.fujitsu.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).