From: Yinghai Lu <yinghai@kernel.org>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: Jiang Liu <jiang.liu@huawei.com>,
Taku Izumi <izumi.taku@jp.fujitsu.com>,
linux-pci@vger.kernel.org, linux-acpi@vger.kernel.org,
kaneshige.kenji@jp.fujitsu.com
Subject: Re: [PATCH 0/7][RESEND] acpi, pci: hostbridge hotplug support
Date: Fri, 31 Aug 2012 09:44:20 -0700 [thread overview]
Message-ID: <CAE9FiQWtv05guh+oDzAn8CNBr+G8+Wycir7XhAcrgezY5E13Cw@mail.gmail.com> (raw)
In-Reply-To: <CAErSpo692O3z44b=q3qTjg-Pf4V4F=c-5H5Z_uVsDoQv+ASejQ@mail.gmail.com>
On Thu, Aug 30, 2012 at 10:42 PM, Bjorn Helgaas <bhelgaas@google.com> wrote:
>
> That's true. I think we should blindly probe for devices only when
> (1) the system does not have ACPI or (2) the DMI BIOS date is older
> than some date, e.g., 1 Jan 2013. For new systems with ACPI, we
> should only look at the host bridges described in ACPI.
if those buses do not get scanned, then it should be enough.
how about just removing pcibios_last_bus probing code?
diff --git a/arch/x86/pci/mmconfig-shared.c b/arch/x86/pci/mmconfig-shared.c
index 937bcec..3f3c460 100644
--- a/arch/x86/pci/mmconfig-shared.c
+++ b/arch/x86/pci/mmconfig-shared.c
@@ -616,16 +616,6 @@ static void __init __pci_mmcfg_init(int early)
if (list_empty(&pci_mmcfg_list))
return;
- if (pcibios_last_bus < 0) {
- const struct pci_mmcfg_region *cfg;
-
- list_for_each_entry(cfg, &pci_mmcfg_list, list) {
- if (cfg->segment)
- break;
- pcibios_last_bus = cfg->end_bus;
- }
- }
-
if (pci_mmcfg_arch_init())
pci_probe = (pci_probe & ~PCI_PROBE_MASK) | PCI_PROBE_MMCONF;
else {
also Nehalem *EX* and Westmere *EX* does not support EDAC.
so if the user with Nehalem/Westmere Desktop version, want to use to
EDAC, they could just append
pci=last_bus=255 to get those buses scanned.
Yinghai
next prev parent reply other threads:[~2012-08-31 16:44 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-10 6:09 [PATCH 0/7][RESEND] acpi, pci: hostbridge hotplug support Taku Izumi
2012-08-10 6:11 ` [PATCH 1/7][RESEND] x86, PCI: Fix non acpi path pci_sysdata leaking with release_fn Taku Izumi
2012-08-16 16:42 ` Bjorn Helgaas
2012-08-10 6:12 ` [PATCH 2/7][RESEND] PCI: Correctly clean up pci root buses in function pci_remove_bus() Taku Izumi
2012-08-16 17:11 ` Bjorn Helgaas
2012-08-30 15:43 ` Jiang Liu
2012-08-10 6:12 ` [PATCH 3/7][RESEND] ACPI, PCI: Use normal list for struct acpi_pci_driver Taku Izumi
2012-08-10 6:13 ` [PATCH 4/7][RESEND] ACPI, PCI: Notify acpi_pci_drivers when hot-plugging PCI root bridges Taku Izumi
2012-08-10 6:14 ` [PATCH 5/7][RESEND] ACPI, PCI: Protect global lists in drivers/acpi/pci_root.c Taku Izumi
2012-08-16 17:25 ` Bjorn Helgaas
2012-08-10 6:14 ` [PATCH 6/7][RESEND] ACPI, PCI: add hostbridge removal function Taku Izumi
2012-08-10 6:15 ` [PATCH 7/7][RESEND] ACPI, PCI: add resoruce-assign code for devices under hot-added hostbridge Taku Izumi
2012-08-10 16:41 ` [PATCH 0/7][RESEND] acpi, pci: hostbridge hotplug support Yinghai Lu
2012-08-20 5:02 ` Taku Izumi
2012-08-30 6:23 ` Bjorn Helgaas
2012-08-30 6:33 ` Jiang Liu
2012-08-30 15:48 ` Yinghai Lu
2012-08-30 16:38 ` Jiang Liu
2012-08-30 17:29 ` Yinghai Lu
2012-08-31 0:43 ` Bjorn Helgaas
2012-08-31 1:03 ` Jiang Liu
2012-08-31 5:04 ` Bjorn Helgaas
2012-08-31 5:19 ` Jiang Liu
2012-08-31 5:42 ` Bjorn Helgaas
2012-08-31 16:44 ` Yinghai Lu [this message]
2012-09-01 3:56 ` Jiang Liu
2012-09-03 2:28 ` Taku Izumi
2012-09-03 4:04 ` Jiang Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAE9FiQWtv05guh+oDzAn8CNBr+G8+Wycir7XhAcrgezY5E13Cw@mail.gmail.com \
--to=yinghai@kernel.org \
--cc=bhelgaas@google.com \
--cc=izumi.taku@jp.fujitsu.com \
--cc=jiang.liu@huawei.com \
--cc=kaneshige.kenji@jp.fujitsu.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).