From: Bjorn Helgaas <helgaas@kernel.org>
To: "Raj, Ashok" <ashok.raj@intel.com>
Cc: linux-pci@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com>,
linux-kernel@vger.kernel.org, Keith Busch <keith.busch@intel.com>
Subject: Re: [PATCH] pciehp: Fix race condition handling surprise link-down
Date: Mon, 6 Mar 2017 18:24:17 -0600 [thread overview]
Message-ID: <20170307002417.GA21358@bhelgaas-glaptop.roam.corp.google.com> (raw)
In-Reply-To: <20170203165104.GC15080@bhelgaas-glaptop.roam.corp.google.com>
On Fri, Feb 03, 2017 at 10:51:04AM -0600, Bjorn Helgaas wrote:
> On Thu, Feb 02, 2017 at 10:00:53PM -0800, Raj, Ashok wrote:
> > ...
> > Just to summarize, we only queue the POWEROFF due to surprise link down
> > and another POWERON due to link becoming back up. The transient link-down
> > events are coveniently ignored.
>
> I'm leery about ignoring events, though it happens to be convenient in
> this case. I think we're ignoring them because we're running work
> items simultaneously with other items, and I think that concurrency is
> unnecessary complexity.
>
> I think it would be safer to queue every event and process every event
> serially.
Hi Ashok,
Just a ping to make sure we're not deadlocked. I'm waiting for you,
so I hope you're not also waiting for me :) I'm not trying to rush you;
I just don't want to drop this by mistake.
Bjorn
next prev parent reply other threads:[~2017-03-07 4:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-09 21:06 [PATCH] pciehp: Fix race condition handling surprise link-down Ashok Raj
2017-01-11 19:04 ` Raj, Ashok
2017-01-17 19:15 ` Raj, Ashok
2017-01-18 18:47 ` Keith Busch
2017-01-19 14:34 ` Bjorn Helgaas
2017-02-03 2:59 ` Bjorn Helgaas
2017-02-03 6:00 ` Raj, Ashok
2017-02-03 16:51 ` Bjorn Helgaas
2017-03-07 0:24 ` Bjorn Helgaas [this message]
2017-03-08 12:27 ` Raj, Ashok
2017-03-09 14:37 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170307002417.GA21358@bhelgaas-glaptop.roam.corp.google.com \
--to=helgaas@kernel.org \
--cc=ashok.raj@intel.com \
--cc=bhelgaas@google.com \
--cc=keith.busch@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).