From: "Raj, Ashok" <ashok.raj@intel.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: linux-pci@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com>,
linux-kernel@vger.kernel.org, Keith Busch <keith.busch@intel.com>,
ashok.raj@intel.com
Subject: Re: [PATCH] pciehp: Fix race condition handling surprise link-down
Date: Wed, 8 Mar 2017 04:27:26 -0800 [thread overview]
Message-ID: <20170308122726.6phvemtqgyowoa7l@araj-mobl1> (raw)
In-Reply-To: <20170307002417.GA21358@bhelgaas-glaptop.roam.corp.google.com>
On Mon, Mar 06, 2017 at 06:24:17PM -0600, Bjorn Helgaas wrote:
> On Fri, Feb 03, 2017 at 10:51:04AM -0600, Bjorn Helgaas wrote:
>
> Hi Ashok,
>
> Just a ping to make sure we're not deadlocked. I'm waiting for you,
> so I hope you're not also waiting for me :) I'm not trying to rush you;
> I just don't want to drop this by mistake.
>
Hi Bjorn
no we aren't deadlocked :-). I didn't get around changing it to ordered
queue yet, mostly worried about having to retest all the different
combinations with ATTN, POWER_CTL, SLD.
I'm depending on other folks to test SLD. They are tied up with other
issues ATM.
I have had another OEM test with several disks and multiple ATTN's
pressed/cancel and current code seems to be working well so far, except the
SLD case.
The change in the patch was only ensuring that we don't start another
POWER_ON or POWER_OFF before the earlier operation was complete.
Would it be alright to fix SLD with this version while we can probe a clean
approach that can give us sufficient time to test a clean approach that works
with all the different combinations and OEM systems?
Cheers
Ashok
next prev parent reply other threads:[~2017-03-08 12:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-09 21:06 [PATCH] pciehp: Fix race condition handling surprise link-down Ashok Raj
2017-01-11 19:04 ` Raj, Ashok
2017-01-17 19:15 ` Raj, Ashok
2017-01-18 18:47 ` Keith Busch
2017-01-19 14:34 ` Bjorn Helgaas
2017-02-03 2:59 ` Bjorn Helgaas
2017-02-03 6:00 ` Raj, Ashok
2017-02-03 16:51 ` Bjorn Helgaas
2017-03-07 0:24 ` Bjorn Helgaas
2017-03-08 12:27 ` Raj, Ashok [this message]
2017-03-09 14:37 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170308122726.6phvemtqgyowoa7l@araj-mobl1 \
--to=ashok.raj@intel.com \
--cc=bhelgaas@google.com \
--cc=helgaas@kernel.org \
--cc=keith.busch@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).