From: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
To: linux-pci@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, Matthew Minter <matt@masarand.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Arnd Bergmann <arnd@arndb.de>,
Bjorn Helgaas <bhelgaas@google.com>,
Tanmay Inamdar <tinamdar@apm.com>, Rich Felker <dalias@libc.org>,
Yoshinori Sato <ysato@users.sourceforge.jp>,
Richard Henderson <rth@twiddle.net>,
Ivan Kokshaysky <ink@jurassic.park.msu.ru>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Ralf Baechle <ralf@linux-mips.org>,
Paul Burton <paul.burton@imgtec.com>,
Chris Metcalf <cmetcalf@mellanox.com>,
Guan Xuetao <gxt@mprc.pku.edu.cn>,
"David S. Miller" <davem@davemloft.net>
Subject: [RFT PATCH 9/9] PCI: Remove pci_fixup_irqs() function
Date: Mon, 31 Jul 2017 17:37:57 +0100 [thread overview]
Message-ID: <20170731163757.22629-10-lorenzo.pieralisi@arm.com> (raw)
In-Reply-To: <20170731163757.22629-1-lorenzo.pieralisi@arm.com>
From: Matthew Minter <matt@masarand.com>
Now we have removed all callers of pci_fixup_irqs() and
migrated everything to pci_assign_irq() delete the
pci_fixup_irqs() function completely.
Signed-off-by: Matthew Minter <matt@masarand.com>
[lorenzo.pieralisi@arm.com: updated commit log]
Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
---
drivers/pci/setup-irq.c | 24 ------------------------
include/linux/pci.h | 2 --
2 files changed, 26 deletions(-)
diff --git a/drivers/pci/setup-irq.c b/drivers/pci/setup-irq.c
index 81eda3d..69e3b56 100644
--- a/drivers/pci/setup-irq.c
+++ b/drivers/pci/setup-irq.c
@@ -67,27 +67,3 @@ void pci_assign_irq(struct pci_dev *dev)
the real IRQ to use; the device does not use it. */
pcibios_update_irq(dev, irq);
}
-
-void pci_fixup_irqs(u8 (*swizzle)(struct pci_dev *, u8 *),
- int (*map_irq)(const struct pci_dev *, u8, u8))
-{
- /*
- * Implement pci_fixup_irqs() through pci_assign_irq().
- * This code should be remove eventually, it is a wrapper
- * around pci_assign_irq() interface to keep current
- * pci_fixup_irqs() behaviour unchanged on architecture
- * code still relying on its interface.
- */
- struct pci_dev *dev = NULL;
- struct pci_host_bridge *hbrg = NULL;
-
- for_each_pci_dev(dev) {
- hbrg = pci_find_host_bridge(dev->bus);
- hbrg->swizzle_irq = swizzle;
- hbrg->map_irq = map_irq;
- pci_assign_irq(dev);
- hbrg->swizzle_irq = NULL;
- hbrg->map_irq = NULL;
- }
-}
-EXPORT_SYMBOL_GPL(pci_fixup_irqs);
diff --git a/include/linux/pci.h b/include/linux/pci.h
index 4869e66..69034ab 100644
--- a/include/linux/pci.h
+++ b/include/linux/pci.h
@@ -1160,8 +1160,6 @@ void pci_assign_unassigned_bus_resources(struct pci_bus *bus);
void pci_assign_unassigned_root_bus_resources(struct pci_bus *bus);
void pdev_enable_device(struct pci_dev *);
int pci_enable_resources(struct pci_dev *, int mask);
-void pci_fixup_irqs(u8 (*)(struct pci_dev *, u8 *),
- int (*)(const struct pci_dev *, u8, u8));
void pci_assign_irq(struct pci_dev *dev);
struct resource *pci_find_resource(struct pci_dev *dev, struct resource *res);
#define HAVE_PCI_REQ_REGIONS 2
--
2.10.0
next prev parent reply other threads:[~2017-07-31 16:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-31 16:37 [RFT PATCH 0/9] PCI: Remove pci_fixup_irqs() Lorenzo Pieralisi
2017-07-31 16:37 ` [RFT PATCH 1/9] sh/PCI: Remove __init optimisations from IRQ mapping functions/data Lorenzo Pieralisi
2017-07-31 16:37 ` [RFT PATCH 2/9] sh/PCI: Replace pci_fixup_irqs() call with PCI host bridge IRQ mapping hooks Lorenzo Pieralisi
2017-07-31 16:37 ` [RFT PATCH 3/9] alpha/PCI: " Lorenzo Pieralisi
2017-07-31 16:37 ` [RFT PATCH 4/9] m68k/PCI: " Lorenzo Pieralisi
2017-07-31 16:37 ` [RFT PATCH 5/9] MIPS/PCI: " Lorenzo Pieralisi
2017-07-31 16:37 ` [RFT PATCH 6/9] tile/PCI: " Lorenzo Pieralisi
2017-07-31 16:37 ` [RFT PATCH 7/9] unicore32/PCI: " Lorenzo Pieralisi
2017-07-31 16:37 ` [RFT PATCH 8/9] sparc/PCI: " Lorenzo Pieralisi
2017-07-31 16:37 ` Lorenzo Pieralisi [this message]
2017-08-03 21:35 ` [RFT PATCH 0/9] PCI: Remove pci_fixup_irqs() Bjorn Helgaas
2017-08-04 15:08 ` Lorenzo Pieralisi
2017-08-10 17:52 ` [PATCH] PCI: Inline and remove pcibios_update_irq() Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170731163757.22629-10-lorenzo.pieralisi@arm.com \
--to=lorenzo.pieralisi@arm.com \
--cc=arnd@arndb.de \
--cc=bhelgaas@google.com \
--cc=cmetcalf@mellanox.com \
--cc=dalias@libc.org \
--cc=davem@davemloft.net \
--cc=geert@linux-m68k.org \
--cc=gxt@mprc.pku.edu.cn \
--cc=ink@jurassic.park.msu.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=matt@masarand.com \
--cc=paul.burton@imgtec.com \
--cc=ralf@linux-mips.org \
--cc=rth@twiddle.net \
--cc=tinamdar@apm.com \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).