* [PATCH] dt-bindings: PCI: MediaTek: fix dtc warnings
@ 2018-02-14 3:27 Ryder Lee
2018-02-19 3:10 ` Rob Herring
2018-03-01 14:50 ` Lorenzo Pieralisi
0 siblings, 2 replies; 3+ messages in thread
From: Ryder Lee @ 2018-02-14 3:27 UTC (permalink / raw)
To: Bjorn Helgaas, Rob Herring
Cc: devicetree, linux-kernel, linux-arm-kernel, linux-pci,
linux-mediatek, Ryder Lee
dtc recently added PCI bus checks. Fix these warnings:
Warning (pci_bridge): Node /pcie@1a140000/pcie@0,0 missing bus-range for PCI bridge
Warning (pci_bridge): Node /pcie@1a140000/pcie@1,0 missing bus-range for PCI bridge
Warning (pci_bridge): Node /pcie@1a140000/pcie@2,0 missing bus-range for PCI bridge
Warning (unit_address_format): Failed prerequisite 'pci_bridge'
Warning (pci_device_reg): Failed prerequisite 'pci_bridge'
Warning (pci_device_bus_num): Failed prerequisite 'pci_bridge'
Signed-off-by: Ryder Lee <ryder.lee@mediatek.com>
---
Documentation/devicetree/bindings/pci/mediatek-pcie.txt | 11 +++--------
1 file changed, 3 insertions(+), 8 deletions(-)
diff --git a/Documentation/devicetree/bindings/pci/mediatek-pcie.txt b/Documentation/devicetree/bindings/pci/mediatek-pcie.txt
index 3a6ce55..20227a8 100644
--- a/Documentation/devicetree/bindings/pci/mediatek-pcie.txt
+++ b/Documentation/devicetree/bindings/pci/mediatek-pcie.txt
@@ -78,7 +78,7 @@ Examples for MT7623:
#reset-cells = <1>;
};
- pcie: pcie-controller@1a140000 {
+ pcie: pcie@1a140000 {
compatible = "mediatek,mt7623-pcie";
device_type = "pci";
reg = <0 0x1a140000 0 0x1000>, /* PCIe shared registers */
@@ -111,7 +111,6 @@ Examples for MT7623:
0x83000000 0 0x60000000 0 0x60000000 0 0x10000000>; /* memory space */
pcie@0,0 {
- device_type = "pci";
reg = <0x0000 0 0 0 0>;
#address-cells = <3>;
#size-cells = <2>;
@@ -123,7 +122,6 @@ Examples for MT7623:
};
pcie@1,0 {
- device_type = "pci";
reg = <0x0800 0 0 0 0>;
#address-cells = <3>;
#size-cells = <2>;
@@ -135,7 +133,6 @@ Examples for MT7623:
};
pcie@2,0 {
- device_type = "pci";
reg = <0x1000 0 0 0 0>;
#address-cells = <3>;
#size-cells = <2>;
@@ -148,6 +145,7 @@ Examples for MT7623:
};
Examples for MT2712:
+
pcie: pcie@11700000 {
compatible = "mediatek,mt2712-pcie";
device_type = "pci";
@@ -169,7 +167,6 @@ Examples for MT2712:
ranges = <0x82000000 0 0x20000000 0x0 0x20000000 0 0x10000000>;
pcie0: pcie@0,0 {
- device_type = "pci";
reg = <0x0000 0 0 0 0>;
#address-cells = <3>;
#size-cells = <2>;
@@ -189,7 +186,6 @@ Examples for MT2712:
};
pcie1: pcie@1,0 {
- device_type = "pci";
reg = <0x0800 0 0 0 0>;
#address-cells = <3>;
#size-cells = <2>;
@@ -210,6 +206,7 @@ Examples for MT2712:
};
Examples for MT7622:
+
pcie: pcie@1a140000 {
compatible = "mediatek,mt7622-pcie";
device_type = "pci";
@@ -243,7 +240,6 @@ Examples for MT7622:
ranges = <0x82000000 0 0x20000000 0x0 0x20000000 0 0x10000000>;
pcie0: pcie@0,0 {
- device_type = "pci";
reg = <0x0000 0 0 0 0>;
#address-cells = <3>;
#size-cells = <2>;
@@ -263,7 +259,6 @@ Examples for MT7622:
};
pcie1: pcie@1,0 {
- device_type = "pci";
reg = <0x0800 0 0 0 0>;
#address-cells = <3>;
#size-cells = <2>;
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] dt-bindings: PCI: MediaTek: fix dtc warnings
2018-02-14 3:27 [PATCH] dt-bindings: PCI: MediaTek: fix dtc warnings Ryder Lee
@ 2018-02-19 3:10 ` Rob Herring
2018-03-01 14:50 ` Lorenzo Pieralisi
1 sibling, 0 replies; 3+ messages in thread
From: Rob Herring @ 2018-02-19 3:10 UTC (permalink / raw)
To: Ryder Lee
Cc: devicetree, linux-pci, linux-kernel, linux-mediatek,
Bjorn Helgaas, linux-arm-kernel
On Wed, Feb 14, 2018 at 11:27:58AM +0800, Ryder Lee wrote:
> dtc recently added PCI bus checks. Fix these warnings:
>
> Warning (pci_bridge): Node /pcie@1a140000/pcie@0,0 missing bus-range for PCI bridge
> Warning (pci_bridge): Node /pcie@1a140000/pcie@1,0 missing bus-range for PCI bridge
> Warning (pci_bridge): Node /pcie@1a140000/pcie@2,0 missing bus-range for PCI bridge
> Warning (unit_address_format): Failed prerequisite 'pci_bridge'
> Warning (pci_device_reg): Failed prerequisite 'pci_bridge'
> Warning (pci_device_bus_num): Failed prerequisite 'pci_bridge'
>
> Signed-off-by: Ryder Lee <ryder.lee@mediatek.com>
> ---
> Documentation/devicetree/bindings/pci/mediatek-pcie.txt | 11 +++--------
> 1 file changed, 3 insertions(+), 8 deletions(-)
Reviewed-by: Rob Herring <robh@kernel.org>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] dt-bindings: PCI: MediaTek: fix dtc warnings
2018-02-14 3:27 [PATCH] dt-bindings: PCI: MediaTek: fix dtc warnings Ryder Lee
2018-02-19 3:10 ` Rob Herring
@ 2018-03-01 14:50 ` Lorenzo Pieralisi
1 sibling, 0 replies; 3+ messages in thread
From: Lorenzo Pieralisi @ 2018-03-01 14:50 UTC (permalink / raw)
To: Ryder Lee
Cc: devicetree, linux-pci, linux-kernel, Rob Herring, linux-mediatek,
Bjorn Helgaas, linux-arm-kernel
On Wed, Feb 14, 2018 at 11:27:58AM +0800, Ryder Lee wrote:
> dtc recently added PCI bus checks. Fix these warnings:
>
> Warning (pci_bridge): Node /pcie@1a140000/pcie@0,0 missing bus-range for PCI bridge
> Warning (pci_bridge): Node /pcie@1a140000/pcie@1,0 missing bus-range for PCI bridge
> Warning (pci_bridge): Node /pcie@1a140000/pcie@2,0 missing bus-range for PCI bridge
> Warning (unit_address_format): Failed prerequisite 'pci_bridge'
> Warning (pci_device_reg): Failed prerequisite 'pci_bridge'
> Warning (pci_device_bus_num): Failed prerequisite 'pci_bridge'
>
> Signed-off-by: Ryder Lee <ryder.lee@mediatek.com>
> ---
> Documentation/devicetree/bindings/pci/mediatek-pcie.txt | 11 +++--------
> 1 file changed, 3 insertions(+), 8 deletions(-)
Given that changes to these bindings always went through the PCI tree,
I've applied this patch to pci/mediatek for v4.17, thanks.
Lorenzo
> diff --git a/Documentation/devicetree/bindings/pci/mediatek-pcie.txt b/Documentation/devicetree/bindings/pci/mediatek-pcie.txt
> index 3a6ce55..20227a8 100644
> --- a/Documentation/devicetree/bindings/pci/mediatek-pcie.txt
> +++ b/Documentation/devicetree/bindings/pci/mediatek-pcie.txt
> @@ -78,7 +78,7 @@ Examples for MT7623:
> #reset-cells = <1>;
> };
>
> - pcie: pcie-controller@1a140000 {
> + pcie: pcie@1a140000 {
> compatible = "mediatek,mt7623-pcie";
> device_type = "pci";
> reg = <0 0x1a140000 0 0x1000>, /* PCIe shared registers */
> @@ -111,7 +111,6 @@ Examples for MT7623:
> 0x83000000 0 0x60000000 0 0x60000000 0 0x10000000>; /* memory space */
>
> pcie@0,0 {
> - device_type = "pci";
> reg = <0x0000 0 0 0 0>;
> #address-cells = <3>;
> #size-cells = <2>;
> @@ -123,7 +122,6 @@ Examples for MT7623:
> };
>
> pcie@1,0 {
> - device_type = "pci";
> reg = <0x0800 0 0 0 0>;
> #address-cells = <3>;
> #size-cells = <2>;
> @@ -135,7 +133,6 @@ Examples for MT7623:
> };
>
> pcie@2,0 {
> - device_type = "pci";
> reg = <0x1000 0 0 0 0>;
> #address-cells = <3>;
> #size-cells = <2>;
> @@ -148,6 +145,7 @@ Examples for MT7623:
> };
>
> Examples for MT2712:
> +
> pcie: pcie@11700000 {
> compatible = "mediatek,mt2712-pcie";
> device_type = "pci";
> @@ -169,7 +167,6 @@ Examples for MT2712:
> ranges = <0x82000000 0 0x20000000 0x0 0x20000000 0 0x10000000>;
>
> pcie0: pcie@0,0 {
> - device_type = "pci";
> reg = <0x0000 0 0 0 0>;
> #address-cells = <3>;
> #size-cells = <2>;
> @@ -189,7 +186,6 @@ Examples for MT2712:
> };
>
> pcie1: pcie@1,0 {
> - device_type = "pci";
> reg = <0x0800 0 0 0 0>;
> #address-cells = <3>;
> #size-cells = <2>;
> @@ -210,6 +206,7 @@ Examples for MT2712:
> };
>
> Examples for MT7622:
> +
> pcie: pcie@1a140000 {
> compatible = "mediatek,mt7622-pcie";
> device_type = "pci";
> @@ -243,7 +240,6 @@ Examples for MT7622:
> ranges = <0x82000000 0 0x20000000 0x0 0x20000000 0 0x10000000>;
>
> pcie0: pcie@0,0 {
> - device_type = "pci";
> reg = <0x0000 0 0 0 0>;
> #address-cells = <3>;
> #size-cells = <2>;
> @@ -263,7 +259,6 @@ Examples for MT7622:
> };
>
> pcie1: pcie@1,0 {
> - device_type = "pci";
> reg = <0x0800 0 0 0 0>;
> #address-cells = <3>;
> #size-cells = <2>;
> --
> 1.9.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-03-01 14:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-02-14 3:27 [PATCH] dt-bindings: PCI: MediaTek: fix dtc warnings Ryder Lee
2018-02-19 3:10 ` Rob Herring
2018-03-01 14:50 ` Lorenzo Pieralisi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).